Do not silently clear a tie attempt, but notify the user that a tie
could not be created (typically either due to a typo or due to a missing
tieWaitForNote)
In a chord, a tie is only unterminated if none of the notes of the
chord create a tie. All other notes of that chord are possible
candidates for a tie start, but not neccesary. For this, I simply
suppress the warning if a note from the same moment already caused
a tie.
E.g. in <c e g>~ g, the g will create a tie, but the c and e should
not trigger a warning!
--- /dev/null
+\version "2.13.41"
+#(ly:set-option 'warning-as-error #f)
+
+\header {
+ texidoc = "When a tie is followed only by unmatching notes and the tie cannot
+ be created, lilypond prints out a warning unless @code{tieWaitForNote} is set."
+}
+
+\relative c' {
+ c1~ c |
+ c1~ <e c> |
+ c1~ d |
+ <c e>1~ c |
+}
SCM tie_definition_;
Stream_event *tie_stream_event_;
Stream_event *tie_event_;
SCM tie_definition_;
Stream_event *tie_stream_event_;
Stream_event *tie_event_;
+ // Indicate whether a tie from the same moment has been processed successfully
+ // This is needed for tied chords, e.g. <c e g>~ g, because otherwise the c
+ // and e will trigger a warning for an unterminated tie!
+ bool tie_from_chord_created;
tie_definition_ = SCM_EOL;
tie_event_ = 0;
tie_stream_event_ = 0;
tie_definition_ = SCM_EOL;
tie_event_ = 0;
tie_stream_event_ = 0;
+ tie_from_chord_created = false;
DECLARE_TRANSLATOR_LISTENER (tie);
void process_music ();
void typeset_tie (Grob *);
DECLARE_TRANSLATOR_LISTENER (tie);
void process_music ();
void typeset_tie (Grob *);
+ void report_unterminated_tie (Head_event_tuple const &);
public:
TRANSLATOR_DECLARATIONS (Tie_engraver);
};
public:
TRANSLATOR_DECLARATIONS (Tie_engraver);
};
ASSIGN_EVENT_ONCE (event_, ev);
}
ASSIGN_EVENT_ONCE (event_, ev);
}
+void Tie_engraver::report_unterminated_tie (Head_event_tuple const &tie_start)
+{
+ // If tie_from_chord_created is set, we have another note at the same
+ // moment that created a tie, so this is not necessarily an unterminated
+ // tie. Happens e.g. for <c e g>~ g
+ if (!tie_start.tie_from_chord_created)
+ tie_start.head_->warning (_("unterminated tie"));
+}
+
void
Tie_engraver::process_music ()
{
void
Tie_engraver::process_music ()
{
left_ev->get_property ("pitch")))
{
Grob *p = new Spanner (heads_to_tie_[i].tie_definition_);
left_ev->get_property ("pitch")))
{
Grob *p = new Spanner (heads_to_tie_[i].tie_definition_);
+ Moment end = heads_to_tie_[i].end_moment_;
SCM cause = heads_to_tie_[i].tie_event_
? heads_to_tie_[i].tie_event_->self_scm ()
SCM cause = heads_to_tie_[i].tie_event_
? heads_to_tie_[i].tie_event_->self_scm ()
ties_.push_back (p);
heads_to_tie_.erase (heads_to_tie_.begin () + i);
ties_.push_back (p);
heads_to_tie_.erase (heads_to_tie_.begin () + i);
+
+ // Prevent all other tied notes ending at the same moment (assume
+ // implicitly the notes have also started at the same moment!)
+ // from triggering an "unterminated tie" warning. Neede e.g. for
+ // <c e g>~ g
+ for (vsize j = heads_to_tie_.size (); j--;)
+ {
+ if (heads_to_tie_[j].end_moment_ == end)
+ heads_to_tie_[i].tie_from_chord_created = true;
+ }
for (vsize i = heads_to_tie_.size (); i--; )
{
if (now > heads_to_tie_[i].end_moment_)
for (vsize i = heads_to_tie_.size (); i--; )
{
if (now > heads_to_tie_[i].end_moment_)
- heads_to_tie_.erase (heads_to_tie_.begin () + i);
+ {
+ report_unterminated_tie (heads_to_tie_[i]);
+ heads_to_tie_.erase (heads_to_tie_.begin () + i);
+ }
if (ties_.size ())
{
if (!wait)
if (ties_.size ())
{
if (!wait)
- heads_to_tie_.clear ();
+ {
+ vector<Head_event_tuple>::iterator it = heads_to_tie_.begin ();
+ for (; it < heads_to_tie_.end (); it++)
+ report_unterminated_tie (*it);
+ heads_to_tie_.clear ();
+ }
for (vsize i = 0; i < ties_.size (); i++)
typeset_tie (ties_[i]);
for (vsize i = 0; i < ties_.size (); i++)
typeset_tie (ties_[i]);
}
if (!wait && new_heads_to_tie.size ())
}
if (!wait && new_heads_to_tie.size ())
- heads_to_tie_.clear ();
+ {
+ vector<Head_event_tuple>::iterator it=heads_to_tie_.begin ();
+ for (; it < heads_to_tie_.end (); it++)
+ report_unterminated_tie (*it);
+ heads_to_tie_.clear ();
+ }
// hmmm, how to do with copy () ?
for (vsize i = 0; i < new_heads_to_tie.size (); i++)
// hmmm, how to do with copy () ?
for (vsize i = 0; i < new_heads_to_tie.size (); i++)