]> git.donarmstrong.com Git - qmk_firmware.git/commit
projects / qmk_firmware.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2b38599) | patch
registering a weak_mods when using register_code16
authorSjB <steve@sagacity.ca>
Sun, 29 Jan 2017 17:06:24 +0000 (12:06 -0500)
committerSjB <steve@sagacity.ca>
Sun, 29 Jan 2017 17:29:43 +0000 (12:29 -0500)
commitf644b9a07a34ae19a6014b08db656a4eeca1dcda
tree5c2e1337433e5bd96c62f26a829589d970fd9b97tree | snapshot
parent2b3859937b1e7f96b684408d31ff12a4e682f7eecommit | diff
registering a weak_mods when using register_code16

Scenario:
Locking the KC_LSHIFT, and then using a tap dance key that registers a
S(KC_9) will unregister the KC_LSHIFT.

The tap dance or any keycode that is registered should not have the
side effect of cancelling a locked moditifier. We should be using a
similar logic as the TMK codes in tmk_core/comman/action.c:158.
quantum/quantum.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.