]> git.donarmstrong.com Git - lilypond.git/commit
Fix #1192.
authorNeil Puttock <n.puttock@gmail.com>
Mon, 26 Jul 2010 00:02:52 +0000 (01:02 +0100)
committerNeil Puttock <n.puttock@gmail.com>
Mon, 26 Jul 2010 00:02:52 +0000 (01:02 +0100)
commite65a2fb4c6e0e2e75f457531cab49aaf74364015
tree55fd69fc2c17cacffc0734b39aec3194b02d0bbe
parent95a0132b69f0d9d0d3cef870c1e4548a4d68b5c7
Fix #1192.

System separator positioning depends on correct calculation of the
paper-system property 'staff-refpoint-extent, but this is incorrect for
systems which include Staff-like contexts since the
Vertically_spaced_contexts_engraver fails to acknowledge axis-groups whose
origin context is aliased to Staff.

Though it's simple to enhance the axis-group acknowledger to detect aliased
contexts, a better solution is to remove the Vertically_spaced_context_engraver:
spaceability is now determined by 'staff-affinity, so the engraver's more
limited functionality can be folded into System::get_paper_system ().

* lily/system.cc (get_paper_system):

  calculate 'staff-refpoint-extent via VerticalAlignment and
  Page_layout_problem::is_spaceable ()

  remove 'spaceable-staves

* lily/vertically-spaced-context-engraver.cc:

  delete

* ly/engraver-init.ly:

  remove Vertically_spaced_context_engraver and verticallySpacedContexts

* scm/define-context-properties.scm (all-user-translation-properties):

  remove verticallySpacedContexts definition

* scm/define-grob-interfaces.scm:

  remove vertically-spaceable-interface

* scm/define-grob-properties.scm (all-internal-grob-properties):

  remove 'spaceable-staves definition

* scm/define-grobs.scm (all-grob-descriptions):

  remove vertically-spaceable-interface from VerticalAxisGroup
input/regression/system-separator-spaceable-staves.ly [new file with mode: 0644]
lily/system.cc
lily/vertically-spaced-context-engraver.cc [deleted file]
ly/engraver-init.ly
scm/define-context-properties.scm
scm/define-grob-interfaces.scm
scm/define-grob-properties.scm
scm/define-grobs.scm