X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=t%2Ftest.pm;h=1a7422945c06df796a1ee8959812b6d33146796f;hb=aa6d2faf4a09834c6d5d5c3cda646697aa346912;hp=fb2e334bf036995295b08bf8b3a15e33cda6b25a;hpb=d5721c97e419a66eb174f90b91ab1431b58ee075;p=term-progressbar.git diff --git a/t/test.pm b/t/test.pm index fb2e334..1a74229 100644 --- a/t/test.pm +++ b/t/test.pm @@ -82,14 +82,10 @@ The following symbols are exported upon request: =over 4 -=item check_req - =item compare =item evcheck -=item only_files - =item save_output =item restore_output @@ -104,8 +100,7 @@ The following symbols are exported upon request: =cut -@EXPORT_OK = qw( check_req compare evcheck only_files - save_output restore_output tempdir tmpnam ); +@EXPORT_OK = qw( evcheck save_output restore_output ); # Utility ----------------------------- @@ -128,22 +123,10 @@ sub rel2abs { if ( File::Spec->file_name_is_absolute($_[0]) ) { return $_[0]; } else { - return catdir(cwd, $_[0]); + return File::Spec->catdir(cwd, $_[0]); } } -sub catdir { - File::Spec->catdir(@_); -} - -sub catfile { - File::Spec->catfile(@_); -} - -sub updir { - File::Spec->updir(@_); -} - sub min { croak "Can't min over 0 args!\n" unless @_; @@ -160,13 +143,13 @@ sub min { # PACKAGE CONSTANTS # ------------------------------------- -use constant BUILD_SCRIPT_DIR => => catdir $Bin, updir, qw( blib script ); +use constant BUILD_SCRIPT_DIR => => File::Spec->catdir( $Bin, File::Spec->updir, qw( blib script ) ); sub find_exec { my ($exec) = @_; for (split /:/, $PATH) { - my $try = catfile $_, $exec; + my $try = File::Spec->catfile($_, $exec); return rel2abs($try) if -x $try; } @@ -196,69 +179,6 @@ chdir $tmpdn; # PACKAGE FUNCTIONS # ------------------------------------- -=head2 only_files - -=over 4 - -=item ARGUMENTS - -=over 4 - -=item expect - -Arrayref of names of files to expect to exist. - -=back - -=item RETURNS - -=over 4 - -=item ok - -1 if exactly expected files exist, false otherwise. - -=back - -=back - -=cut - -sub only_files { - my ($expect) = @_; - - local *MYDIR; - opendir MYDIR, '.'; - my %files = map { $_ => 1 } readdir MYDIR; - closedir MYDIR; - - my $ok = 1; - - for (@$expect, '.', '..') { - if ( exists $files{$_} ) { - delete $files{$_}; - } elsif ( ! -e $_ ) { # $_ might be absolute - carp "File not found: $_\n" - if $ENV{TEST_DEBUG}; - $ok = 0; - } - } - - for (keys %files) { - carp "Extra file found: $_\n" - if $ENV{TEST_DEBUG}; - $ok = 0; - } - - if ( $ok ) { - return 1; - } else { - return; - } -} - -# ------------------------------------- - =head2 evcheck Eval code, return status @@ -626,43 +546,6 @@ is equal. If the sort flag is present, each file is sorted prior to comparison. =cut -#XYZ sub _run { -#XYZ my ($cmd, $name, $in) = @_; -#XYZ -#XYZ my $infn = defined $in ? tmpnam : '/dev/null'; -#XYZ my $outfn = tmpnam; -#XYZ my $errfn = tmpnam; -#XYZ -#XYZ my $pid = fork; -#XYZ croak "Couldn't fork: $!\n" -#XYZ unless defined $pid; -#XYZ -#XYZ if ( $pid == 0 ) { # Child -#XYZ open STDOUT, '>', $outfn; -#XYZ open STDERR, '>', $errfn; -#XYZ open STDIN, '<', $infn; -#XYZ -#XYZ exec @$cmd; -#XYZ } -#XYZ -#XYZ my $rv = waitpid $pid, 0; -#XYZ my $status = $?; -#XYZ -#XYZ croak "Unexpected waitpid return from child $name: $rv (expected $pid)\n" -#XYZ unless $rv == $pid; -#XYZ -#XYZ local $/ = undef; -#XYZ local (OUT, ERR); -#XYZ open *OUT, '<', $outfn; -#XYZ open *ERR, '<', $errfn; -#XYZ my $out = ; -#XYZ my $err = ; -#XYZ close *OUT; -#XYZ close *ERR; -#XYZ -#XYZ return $status >> 8, $status & 127, $status & 128 , $out, $err -#XYZ } - # return codes and old-style call semantics left for backwards compatibility BEGIN { my $savewarn = $SIG{__WARN__}; @@ -914,120 +797,6 @@ END # ------------------------------------- -=head2 check_req - -Perform a requisite check on a given executable. This will skip if the -required modules are not present. - -4+(n+m)*2 tests are performed, where n is the number of prerequisites -expected, and m is the number of outputs expected. - -=over 4 - -=item SYNOPSIS - - check_req('ccu-touch', - ['/etc/passwd'], - [[REQ_FILE, '/etc/passwd']], - [[REQ_FILE, 'passwd.foo']], - 'requisites 1'); - - -=item ARGUMENTS - -=over 4 - -=item cmd_name - -The name of the command to run. It is assumed that this command is in -blib/script; hence it should be an executable in this package, and C -shuold have been run recently. - -=item args - -The arguments to pass to the cmd_name, as an arrayref. - -=item epres - -The expected prerequisites, as an arrayref, wherein every member is a -two-element arrayref, the members being the requisite type, and the requisite -value. - -=item eouts - -The expected outputs, in the same format as the L. - -=item testname - -The name to use in error messages. - -=back - -=back - -=cut - -sub check_req { - my ($cmd_name, $args, $epres, $eouts, $testname) = @_; - - eval "use Pipeline::DataFlow 1.03 qw( :req_types );"; - my $skip; - if ( $@ ) { - print STDERR "$@\n" - if $ENV{TEST_DEBUG}; - $skip = 'Skipped: Pipeline::DataFlow 1.03 not found'; - } else { - $skip = 0; - } - - my $count = 1; - my $test = sub { - my ($code, $expect) = @_; - my $name = sprintf "%s (%2d)", $testname, $count++; - my $value = UNIVERSAL::isa($code, 'CODE') ? $code->($name) : $code; - skip $skip, $value, $expect, $name; - }; - - # Initialize nicely to cope when read_reqs fails - my ($pres, $outs) = ([], []); - - $test->(sub { - evcheck(sub { - ($pres, $outs) = Pipeline::DataFlow->read_reqs - ([catfile($Bin, updir, 'blib', 'script', $cmd_name), - @$args]); - }, $_[0]),}, - 1); - - $test->(scalar @$pres, scalar @$epres); - - my (@epres, @pres); - @epres = sort { $a->[1] cmp $b->[1] } @$epres; - @pres = sort { $a->[1] cmp $b->[1] } @$pres; - - for (my $i = 0; $i < @epres; $i++) { - my ($type, $value) = @{$epres[$i]}; - $test->($type, @pres > $i ? $pres[$i]->[0] : undef); - $test->($value, @pres > $i ? $pres[$i]->[1] : undef); - } - - $test->(scalar @$outs, scalar @$eouts); - - my (@eouts, @outs); - @eouts = sort { $a->[1] cmp $b->[1] } @$eouts; - @outs = sort { $a->[1] cmp $b->[1] } @$outs; - - for (my $i = 0; $i < @eouts; $i++) { - my ($type, $value) = @{$eouts[$i]}; - $test->($type, @outs > $i ? $outs[$i]->[0] : undef); - $test->($value, @outs > $i ? $outs[$i]->[1] : undef); - } - - $test->(only_files([]), 1); -} - -# ------------------------------------- - =head2 find_exec =over 4