X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=src%2Fxo-file.c;h=7ff79749542b2dec4834df12d09d439cf6d970fa;hb=b471a5e1ffc9ad87400f079679fdf261875d513e;hp=7d2786036f38feb0e4a1231e176ba97d7f2dcca4;hpb=e648cece76b671b5b0e165acc6d14178e8de1000;p=xournal.git diff --git a/src/xo-file.c b/src/xo-file.c index 7d27860..7ff7974 100644 --- a/src/xo-file.c +++ b/src/xo-file.c @@ -219,6 +219,7 @@ gboolean close_journal(void) // free everything... reset_selection(); + reset_recognizer(); clear_redo_stack(); clear_undo_stack(); @@ -342,7 +343,7 @@ void xoj_parser_start_element(GMarkupParseContext *context, } // there's also the case of hex (#rrggbbaa) colors if (tmpPage->bg->color_no == COLOR_OTHER && **attribute_values == '#') { - tmpPage->bg->color_rgba = strtol(*attribute_values + 1, &ptr, 16); + tmpPage->bg->color_rgba = strtoul(*attribute_values + 1, &ptr, 16); if (*ptr!=0) *error = xoj_invalid(); } has_attr |= 2; @@ -484,7 +485,7 @@ void xoj_parser_start_element(GMarkupParseContext *context, } // there's also the case of hex (#rrggbbaa) colors if (tmpItem->brush.color_no == COLOR_OTHER && **attribute_values == '#') { - tmpItem->brush.color_rgba = strtol(*attribute_values + 1, &ptr, 16); + tmpItem->brush.color_rgba = strtoul(*attribute_values + 1, &ptr, 16); if (*ptr!=0) *error = xoj_invalid(); } has_attr |= 2; @@ -563,7 +564,7 @@ void xoj_parser_start_element(GMarkupParseContext *context, } // there's also the case of hex (#rrggbbaa) colors if (tmpItem->brush.color_no == COLOR_OTHER && **attribute_values == '#') { - tmpItem->brush.color_rgba = strtol(*attribute_values + 1, &ptr, 16); + tmpItem->brush.color_rgba = strtoul(*attribute_values + 1, &ptr, 16); if (*ptr!=0) *error = xoj_invalid(); } has_attr |= 16; @@ -664,7 +665,10 @@ gboolean user_wants_second_chance(char **filename) dialog = gtk_file_chooser_dialog_new(_("Open PDF"), GTK_WINDOW (winMain), GTK_FILE_CHOOSER_ACTION_OPEN, GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, GTK_STOCK_OPEN, GTK_RESPONSE_OK, NULL); - +#ifdef FILE_DIALOG_SIZE_BUGFIX + gtk_window_set_default_size(GTK_WINDOW(dialog), 500, 400); +#endif + filt_all = gtk_file_filter_new(); gtk_file_filter_set_name(filt_all, _("All files")); gtk_file_filter_add_pattern(filt_all, "*"); @@ -674,6 +678,8 @@ gboolean user_wants_second_chance(char **filename) gtk_file_chooser_add_filter(GTK_FILE_CHOOSER (dialog), filt_pdf); gtk_file_chooser_add_filter(GTK_FILE_CHOOSER (dialog), filt_all); + if (ui.default_path!=NULL) gtk_file_chooser_set_current_folder(GTK_FILE_CHOOSER (dialog), ui.default_path); + if (gtk_dialog_run(GTK_DIALOG(dialog)) != GTK_RESPONSE_OK) { gtk_widget_destroy(dialog); return FALSE; @@ -696,11 +702,25 @@ gboolean open_journal(char *filename) gzFile f; char buffer[1000]; int len; - gchar *tmpfn; + gchar *tmpfn, *tmpfn2, *p, *q; gboolean maybe_pdf; + tmpfn = g_strdup_printf("%s.xoj", filename); + if (ui.autoload_pdf_xoj && g_file_test(tmpfn, G_FILE_TEST_EXISTS) && + (g_str_has_suffix(filename, ".pdf") || g_str_has_suffix(filename, ".PDF"))) + { + valid = open_journal(tmpfn); + g_free(tmpfn); + return valid; + } + g_free(tmpfn); + f = gzopen(filename, "r"); if (f==NULL) return FALSE; + if (filename[0]=='/') { + if (ui.default_path != NULL) g_free(ui.default_path); + ui.default_path = g_path_get_dirname(filename); + } context = g_markup_parse_context_new(&parser, 0, NULL, NULL); valid = TRUE; @@ -755,7 +775,21 @@ gboolean open_journal(char *filename) else tmpfn = g_strdup(tmpBg_pdf->filename->s); valid = init_bgpdf(tmpfn, FALSE, tmpBg_pdf->file_domain); - // in case the file name became invalid + // if file name is invalid: first try in xoj file's directory + if (!valid && tmpBg_pdf->file_domain != DOMAIN_ATTACH) { + p = g_path_get_dirname(filename); + q = g_path_get_basename(tmpfn); + tmpfn2 = g_strdup_printf("%s/%s", p, q); + g_free(p); g_free(q); + valid = init_bgpdf(tmpfn2, FALSE, tmpBg_pdf->file_domain); + if (valid) { // change the file name... + printf("substituting %s -> %s\n", tmpfn, tmpfn2); + g_free(tmpBg_pdf->filename->s); + tmpBg_pdf->filename->s = tmpfn2; + } + else g_free(tmpfn2); + } + // if file name is invalid: next prompt user if (!valid && tmpBg_pdf->file_domain != DOMAIN_ATTACH) if (user_wants_second_chance(&tmpfn)) { valid = init_bgpdf(tmpfn, FALSE, tmpBg_pdf->file_domain); @@ -1011,13 +1045,13 @@ gboolean bgpdf_scheduler_callback(gpointer data) /* make a request */ -void add_bgpdf_request(int pageno, double zoom) +gboolean add_bgpdf_request(int pageno, double zoom) { struct BgPdfRequest *req, *cmp_req; GList *list; - + if (bgpdf.status == STATUS_NOT_INIT) - return; // don't accept requests + return FALSE; // don't accept requests req = g_new(struct BgPdfRequest, 1); req->pageno = pageno; req->dpi = 72*zoom; @@ -1033,6 +1067,7 @@ void add_bgpdf_request(int pageno, double zoom) // make the request bgpdf.requests = g_list_append(bgpdf.requests, req); if (!bgpdf.pid) bgpdf.pid = g_idle_add(bgpdf_scheduler_callback, NULL); + return TRUE; } /* shutdown the PDF reader */ @@ -1081,6 +1116,7 @@ gboolean init_bgpdf(char *pdfname, gboolean create_pages, int file_domain) struct Page *pg; PopplerPage *pdfpage; gdouble width, height; + gchar *uri; if (bgpdf.status != STATUS_NOT_INIT) return FALSE; @@ -1100,8 +1136,22 @@ gboolean init_bgpdf(char *pdfname, gboolean create_pages, int file_domain) bgpdf.pid = 0; bgpdf.has_failed = FALSE; - bgpdf.document = poppler_document_new_from_data(bgpdf.file_contents, bgpdf.file_length, NULL, NULL); - if (bgpdf.document == NULL) shutdown_bgpdf(); +/* poppler_document_new_from_data() starts at 0.6.1, but we want to + be compatible with poppler 0.5.4 = latest in CentOS as of sept 2009 */ + uri = g_filename_to_uri(pdfname, NULL, NULL); + if (!uri) uri = g_strdup_printf("file://%s", pdfname); + bgpdf.document = poppler_document_new_from_file(uri, NULL, NULL); + g_free(uri); +/* with poppler 0.6.1 or later, can replace the above 4 lines by: + bgpdf.document = poppler_document_new_from_data(bgpdf.file_contents, + bgpdf.file_length, NULL, NULL); +*/ + if (bgpdf.document == NULL) { shutdown_bgpdf(); return FALSE; } + + if (pdfname[0]=='/' && ui.filename == NULL) { + if (ui.default_path!=NULL) g_free(ui.default_path); + ui.default_path = g_path_get_dirname(pdfname); + } if (!create_pages) return TRUE; // we're done @@ -1204,7 +1254,8 @@ void update_mru_menu(void) for (i=0; icolor_no])); + (ui.default_page.bg->color_no>=0)? + g_strdup(bgcolor_names[ui.default_page.bg->color_no]): + g_strdup_printf("#%08x", ui.default_page.bg->color_rgba)); update_keyval("paper", "style", _(" the default paper style (plain, lined, ruled, or graph)"), g_strdup(bgstyle_names[ui.default_page.bg->ruling])); @@ -1472,9 +1537,6 @@ void save_config_to_file(void) update_keyval("paper", "print_ruling", _(" include paper ruling when printing or exporting to PDF (true/false)"), g_strdup(ui.print_ruling?"true":"false")); - update_keyval("paper", "antialias_bg", - _(" antialiased bitmap backgrounds (true/false)"), - g_strdup(ui.antialias_bg?"true":"false")); update_keyval("paper", "progressive_bg", _(" just-in-time update of page backgrounds (true/false)"), g_strdup(ui.progressive_bg?"true":"false")); @@ -1490,7 +1552,9 @@ void save_config_to_file(void) g_strdup(tool_names[ui.startuptool])); update_keyval("tools", "pen_color", _(" default pen color"), - g_strdup(color_names[ui.default_brushes[TOOL_PEN].color_no])); + (ui.default_brushes[TOOL_PEN].color_no>=0)? + g_strdup(color_names[ui.default_brushes[TOOL_PEN].color_no]): + g_strdup_printf("#%08x", ui.default_brushes[TOOL_PEN].color_rgba)); update_keyval("tools", "pen_thickness", _(" default pen thickness (fine = 1, medium = 2, thick = 3)"), g_strdup_printf("%d", ui.default_brushes[TOOL_PEN].thickness_no)); @@ -1508,7 +1572,9 @@ void save_config_to_file(void) g_strdup_printf("%d", ui.default_brushes[TOOL_ERASER].tool_options)); update_keyval("tools", "highlighter_color", _(" default highlighter color"), - g_strdup(color_names[ui.default_brushes[TOOL_HIGHLIGHTER].color_no])); + (ui.default_brushes[TOOL_HIGHLIGHTER].color_no>=0)? + g_strdup(color_names[ui.default_brushes[TOOL_HIGHLIGHTER].color_no]): + g_strdup_printf("#%08x", ui.default_brushes[TOOL_HIGHLIGHTER].color_rgba)); update_keyval("tools", "highlighter_thickness", _(" default highlighter thickness (fine = 1, medium = 2, thick = 3)"), g_strdup_printf("%d", ui.default_brushes[TOOL_HIGHLIGHTER].thickness_no)); @@ -1526,8 +1592,11 @@ void save_config_to_file(void) g_strdup((ui.linked_brush[1]==BRUSH_LINKED)?"true":"false")); update_keyval("tools", "btn2_color", _(" button 2 brush color (for pen or highlighter only)"), - g_strdup((ui.toolno[1]=0)? + g_strdup(color_names[ui.brushes[1][ui.toolno[1]].color_no]): + g_strdup_printf("#%08x", ui.brushes[1][ui.toolno[1]].color_rgba)): + g_strdup("white")); update_keyval("tools", "btn2_thickness", _(" button 2 brush thickness (pen, eraser, or highlighter only)"), g_strdup_printf("%d", (ui.toolno[1]=0)? + g_strdup(color_names[ui.brushes[2][ui.toolno[2]].color_no]): + g_strdup_printf("#%08x", ui.brushes[2][ui.toolno[2]].color_rgba)): + g_strdup("white")); update_keyval("tools", "btn3_thickness", _(" button 3 brush thickness (pen, eraser, or highlighter only)"), g_strdup_printf("%d", (ui.toolno[2]color_no), bgcolor_names, COLOR_MAX); - ui.default_page.bg->color_rgba = predef_bgcolors_rgba[ui.default_page.bg->color_no]; + parse_keyval_enum_color("paper", "color", + &(ui.default_page.bg->color_no), &(ui.default_page.bg->color_rgba), + bgcolor_names, predef_bgcolors_rgba, COLOR_MAX); parse_keyval_enum("paper", "style", &(ui.default_page.bg->ruling), bgstyle_names, 4); parse_keyval_boolean("paper", "apply_all", &ui.bg_apply_all_pages); parse_keyval_enum("paper", "default_unit", &ui.default_unit, unit_names, 4); - parse_keyval_boolean("paper", "antialias_bg", &ui.antialias_bg); parse_keyval_boolean("paper", "progressive_bg", &ui.progressive_bg); parse_keyval_boolean("paper", "print_ruling", &ui.print_ruling); parse_keyval_int("paper", "gs_bitmap_dpi", &GS_BITMAP_DPI, 1, 1200); @@ -1797,13 +1893,17 @@ void load_config_from_file(void) parse_keyval_enum("tools", "startup_tool", &ui.startuptool, tool_names, NUM_TOOLS); ui.toolno[0] = ui.startuptool; - parse_keyval_enum("tools", "pen_color", &(ui.brushes[0][TOOL_PEN].color_no), color_names, COLOR_MAX); + parse_keyval_enum_color("tools", "pen_color", + &(ui.brushes[0][TOOL_PEN].color_no), &(ui.brushes[0][TOOL_PEN].color_rgba), + color_names, predef_colors_rgba, COLOR_MAX); parse_keyval_int("tools", "pen_thickness", &(ui.brushes[0][TOOL_PEN].thickness_no), 0, 4); parse_keyval_boolean("tools", "pen_ruler", &(ui.brushes[0][TOOL_PEN].ruler)); parse_keyval_boolean("tools", "pen_recognizer", &(ui.brushes[0][TOOL_PEN].recognizer)); parse_keyval_int("tools", "eraser_thickness", &(ui.brushes[0][TOOL_ERASER].thickness_no), 1, 3); parse_keyval_int("tools", "eraser_mode", &(ui.brushes[0][TOOL_ERASER].tool_options), 0, 2); - parse_keyval_enum("tools", "highlighter_color", &(ui.brushes[0][TOOL_HIGHLIGHTER].color_no), color_names, COLOR_MAX); + parse_keyval_enum_color("tools", "highlighter_color", + &(ui.brushes[0][TOOL_HIGHLIGHTER].color_no), &(ui.brushes[0][TOOL_HIGHLIGHTER].color_rgba), + color_names, predef_colors_rgba, COLOR_MAX); parse_keyval_int("tools", "highlighter_thickness", &(ui.brushes[0][TOOL_HIGHLIGHTER].thickness_no), 0, 4); parse_keyval_boolean("tools", "highlighter_ruler", &(ui.brushes[0][TOOL_HIGHLIGHTER].ruler)); parse_keyval_boolean("tools", "highlighter_recognizer", &(ui.brushes[0][TOOL_HIGHLIGHTER].recognizer)); @@ -1822,7 +1922,9 @@ void load_config_from_file(void) if (ui.toolno[1]==TOOL_PEN || ui.toolno[1]==TOOL_HIGHLIGHTER) { parse_keyval_boolean("tools", "btn2_ruler", &(ui.brushes[1][ui.toolno[1]].ruler)); parse_keyval_boolean("tools", "btn2_recognizer", &(ui.brushes[1][ui.toolno[1]].recognizer)); - parse_keyval_enum("tools", "btn2_color", &(ui.brushes[1][ui.toolno[1]].color_no), color_names, COLOR_MAX); + parse_keyval_enum_color("tools", "btn2_color", + &(ui.brushes[1][ui.toolno[1]].color_no), &(ui.brushes[1][ui.toolno[1]].color_rgba), + color_names, predef_colors_rgba, COLOR_MAX); } if (ui.toolno[1]