X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=scm%2Ftranslation-functions.scm;h=901bff0944e40e0385d8ce81443de09a569fe599;hb=ae31643433214890db64b67587974a7290733aa5;hp=d4c84caf612f0cf1fff05b8fc766034c2411a78e;hpb=db1b4bee7d0792351e368e776f197b1bca7050cb;p=lilypond.git

diff --git a/scm/translation-functions.scm b/scm/translation-functions.scm
index d4c84caf61..901bff0944 100644
--- a/scm/translation-functions.scm
+++ b/scm/translation-functions.scm
@@ -7,39 +7,34 @@
 
 ;; metronome marks
 (define-public (format-metronome-markup text dur count context)
-  (let* ((hide_note (eq? #t (ly:context-property context 'tempoHideNote)))
-	 (note-mark (if (and (not hide_note) (ly:duration? dur))
+  (let* ((hide-note (eq? #t (ly:context-property context 'tempoHideNote)))
+	 (note-mark (if (and (not hide-note) (ly:duration? dur))
                       (make-smaller-markup
 		       (make-note-by-number-markup (ly:duration-log dur)
 						   (ly:duration-dot-count dur)
 						   1))
-		      #f))
-         (note-markup (if (and note-mark (number? count) (> count 0) )
+		      (make-null-markup)))
+         (note-markup (if (and (not hide-note) (number? count) (> count 0) )
                         (make-concat-markup (list
                           (make-general-align-markup Y DOWN note-mark)
                           (make-simple-markup " ")
                           (make-simple-markup  "=")
                           (make-simple-markup " ")
                           (make-simple-markup (number->string count))))
-                        #f))
+                      #f))
          (text-markup (if (not (null? text))
                         (make-bold-markup text)
                         #f)))
     (if text-markup
-      (if note-markup
+      (if (and note-markup (not hide-note))
         (make-line-markup (list text-markup
           (make-concat-markup (list (make-simple-markup "(")
                                     note-markup
                                     (make-simple-markup ")")))))
-        (make-line-markup (list text-markup))
-      )
+        (make-line-markup (list text-markup)))
       (if note-markup
         (make-line-markup (list note-markup))
-        #f
-      )
-    )
-  )
-)
+        (make-null-markup)))))
 
 (define-public (format-mark-alphabet mark context)
   (make-bold-markup (make-markalphabet-markup (1- mark))))
@@ -134,7 +129,7 @@
     ;;    (if (markup? fig-markup)
     ;;	(set!
     ;;	 fig-markup (markup #:translate (cons 1.0 0)
-    ;;			    #:hcenter fig-markup)))
+    ;;			    #:center-align fig-markup)))
 
     (if alt-markup
 	(set! fig-markup
@@ -241,9 +236,9 @@
   (define (note-pitch a)
     (ly:event-property a 'pitch))
 
-  (define (note-pitch<? a b)
-    (ly:pitch<? (note-pitch a)
-		(note-pitch b)))
+  (define (note-pitch>? a b)
+    (ly:pitch<? (note-pitch b)
+		(note-pitch a)))
 
   (define (note-finger ev)
     (let* ((articulations (ly:event-property ev 'articulations))
@@ -334,15 +329,16 @@
      (if (note-string note)
 	 (set-fret note (note-string note))
 	 (let*
-	     ((string (find (lambda (string) (string-qualifies string
-							       (note-pitch note)))
-			      (reverse free-strings))))
-	   (if string
-	       (set-fret note string)
-	       (ly:warning "No string for pitch ~a (given frets ~a)" (note-pitch note)
+	     ((fit-string (find (lambda (string) 
+                               (string-qualifies string (note-pitch note)))
+			    free-strings)))
+	   (if fit-string
+	       (set-fret note fit-string)
+	       (ly:warning "No string for pitch ~a (given frets ~a)" 
+                           (note-pitch note)
 			   specified-frets))
 			   
 	       )))
-   (sort notes note-pitch<?))
+   (sort notes note-pitch>?))
 
   string-fret-fingering-tuples)