X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=protocol%2Fps2_busywait.c;h=a64933219ec96e1b48d4f30edf5eb60191306a31;hb=abf482de8e62880f27c377c2bdbcb664fda0df0b;hp=5ab377877ec9a0e3e4e9046f00f03e68c81214a7;hpb=9d26053f1c14da79336a64f800305660d1a71180;p=qmk_firmware.git

diff --git a/protocol/ps2_busywait.c b/protocol/ps2_busywait.c
index 5ab377877..a64933219 100644
--- a/protocol/ps2_busywait.c
+++ b/protocol/ps2_busywait.c
@@ -35,16 +35,17 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGE.
 */
 
+/*
+ * PS/2 protocol busywait version
+ */
+
 #include <stdbool.h>
-#include <util/delay.h>
+#include "wait.h"
 #include "ps2.h"
+#include "ps2_io.h"
 #include "debug.h"
 
 
-/*
- * PS/2 protocol busywait version
- */
-
 #define WAIT(stat, us, err) do { \
     if (!wait_##stat(us)) { \
         ps2_error = err; \
@@ -52,33 +53,38 @@ POSSIBILITY OF SUCH DAMAGE.
     } \
 } while (0)
 
+
 uint8_t ps2_error = PS2_ERR_NONE;
 
 
 void ps2_host_init(void)
 {
+    clock_init();
+    data_init();
+
     // POR(150-2000ms) plus BAT(300-500ms) may take 2.5sec([3]p.20)
-    _delay_ms(2500);
+    wait_ms(2500);
 
     inhibit();
 }
 
 uint8_t ps2_host_send(uint8_t data)
 {
-    uint8_t res = 0;
     bool parity = true;
     ps2_error = PS2_ERR_NONE;
+
     /* terminate a transmission if we have */
     inhibit();
-    _delay_us(200); // at least 100us
+    wait_us(100); // 100us [4]p.13, [5]p.50
 
-    /* start bit [1] */
+    /* 'Request to Send' and Start bit */
     data_lo();
     clock_hi();
-    WAIT(clock_lo, 20000, 10);   // may take 15ms at most until device starts clocking
-    /* data [2-9] */
+    WAIT(clock_lo, 10000, 10);   // 10ms [5]p.50
+
+    /* Data bit */
     for (uint8_t i = 0; i < 8; i++) {
-        _delay_us(15);
+        wait_us(15);
         if (data&(1<<i)) {
             parity = !parity;
             data_hi();
@@ -88,15 +94,18 @@ uint8_t ps2_host_send(uint8_t data)
         WAIT(clock_hi, 50, 2);
         WAIT(clock_lo, 50, 3);
     }
-    /* parity [10] */
-    _delay_us(15);
+
+    /* Parity bit */
+    wait_us(15);
     if (parity) { data_hi(); } else { data_lo(); }
     WAIT(clock_hi, 50, 4);
     WAIT(clock_lo, 50, 5);
-    /* stop bit [11] */
-    _delay_us(15);
+
+    /* Stop bit */
+    wait_us(15);
     data_hi();
-    /* ack [12] */
+
+    /* Ack */
     WAIT(data_lo, 50, 6);
     WAIT(clock_lo, 50, 7);
 
@@ -105,17 +114,16 @@ uint8_t ps2_host_send(uint8_t data)
     WAIT(data_hi, 50, 9);
 
     inhibit();
-    res = ps2_host_recv_response();
+    return ps2_host_recv_response();
 ERROR:
     inhibit();
-    return res;
+    return 0;
 }
 
 /* receive data when host want else inhibit communication */
 uint8_t ps2_host_recv_response(void)
 {
-    // Command might take 20ms to response([3]p.21)
-    // TrackPoint might take 25ms ([5]2.7)
+    // Command may take 25ms/20ms at most([5]p.46, [3]p.21)
     // 250 * 100us(wait for start bit in ps2_host_recv)
     uint8_t data = 0;
     uint8_t try = 250;
@@ -125,14 +133,6 @@ uint8_t ps2_host_recv_response(void)
     return data;
 }
 
-/* send LED state to keyboard */
-void ps2_host_set_led(uint8_t led)
-{
-    ps2_host_send(0xED);
-    ps2_host_send(led);
-}
-
-
 /* called after start bit comes */
 uint8_t ps2_host_recv(void)
 {
@@ -180,3 +180,10 @@ ERROR:
     inhibit();
     return 0;
 }
+
+/* send LED state to keyboard */
+void ps2_host_set_led(uint8_t led)
+{
+    ps2_host_send(0xED);
+    ps2_host_send(led);
+}