X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fvolta-engraver.cc;h=5d8b0107df85e5a4a3093998ef334fcbd0b5ae44;hb=811be522d0b79493159f47789e5621dc85493495;hp=a988218ca0a6c2739f96f81a4393aee4c7dde723;hpb=1e1fa5221ca359326b073626168c6b7cda6453e1;p=lilypond.git diff --git a/lily/volta-engraver.cc b/lily/volta-engraver.cc index a988218ca0..5d8b0107df 100644 --- a/lily/volta-engraver.cc +++ b/lily/volta-engraver.cc @@ -1,37 +1,41 @@ -/* - volta-engraver.cc -- implement Volta_engraver - +/* + volta-engraver.cc -- implement Volta_engraver + source file of the GNU LilyPond music typesetter - - (c) 2000--2004 Han-Wen Nienhuys - - */ + + (c) 2000--2005 Han-Wen Nienhuys +*/ #include "engraver.hh" #include "context.hh" #include "volta-bracket.hh" -#include "item.hh" #include "note-column.hh" #include "bar-line.hh" #include "side-position-interface.hh" #include "warn.hh" #include "staff-symbol.hh" +#include "translator.icc" + /* Create Volta spanners, by reading repeatCommands property, usually set by Unfolded_repeat_iterator. - */ +*/ class Volta_engraver : public Engraver { public: TRANSLATOR_DECLARATIONS (Volta_engraver); protected: - virtual void acknowledge_grob (Grob_info); - virtual void finalize (); - virtual void stop_translation_timestep (); - virtual void process_music (); + DECLARE_ACKNOWLEDGER (staff_symbol); + DECLARE_ACKNOWLEDGER (note_column); + DECLARE_ACKNOWLEDGER (bar_line); + virtual void finalize (); + + void stop_translation_timestep (); + void process_music (); + Moment started_mom_; Spanner *volta_span_; Spanner *end_volta_span_; @@ -39,7 +43,6 @@ protected: SCM start_string_; bool staff_eligible (); - }; Volta_engraver::Volta_engraver () @@ -49,24 +52,22 @@ Volta_engraver::Volta_engraver () end_volta_span_ = 0; } - /* TODO: this logic should be rewritten, it is buggy. One of the problems is that we can't determine wether or not to print the volta bracket during the first step, since that requires acknowledging the staff. - */ +*/ bool Volta_engraver::staff_eligible () { - SCM doit =get_property ("voltaOnThisStaff"); + SCM doit = get_property ("voltaOnThisStaff"); if (scm_is_bool (doit)) { return to_boolean (doit); } - if (!unsmob_grob (staff_)) return false; @@ -76,36 +77,28 @@ Volta_engraver::staff_eligible () */ SCM staffs = get_property ("stavesFound"); - /* - only put a volta on the top staff. - - May be this is a bit convoluted, and we should have a single - volta engraver in score context or somesuch. - - */ + /* Only put a volta on the top staff. + Maybe this is a bit convoluted, and we should have a single + volta engraver in score context or somesuch. */ if (!scm_is_pair (staffs)) { - programming_error ("Huh? Volta engraver can't find staffs?"); + programming_error ("volta engraver can't find staffs"); return false; } else if (scm_car (scm_last_pair (staffs)) != staff_) - { - return false; - } + return false; return true; } - void Volta_engraver::process_music () { SCM cs = get_property ("repeatCommands"); if (!staff_eligible ()) - return ; + return; - - bool end = false; + bool end = false; start_string_ = SCM_EOL; while (scm_is_pair (cs)) { @@ -115,12 +108,12 @@ Volta_engraver::process_music () && scm_car (c) == ly_symbol2scm ("volta") && scm_is_pair (scm_cdr (c))) { - if (scm_cadr (c) == SCM_BOOL_F) + if (scm_cadr (c) == SCM_BOOL_F) end = true; else start_string_ = scm_cadr (c); } - + cs = scm_cdr (cs); } @@ -128,81 +121,76 @@ Volta_engraver::process_music () { SCM l (get_property ("voltaSpannerDuration")); Moment now = now_mom (); - + bool early_stop = unsmob_moment (l) && *unsmob_moment (l) <= now - started_mom_; - + end = end || early_stop; } - if (end && !volta_span_) - { - warning (_ ("No volta spanner to end")); // fixme: be more verbose. - } + /* fixme: be more verbose. */ + warning (_ ("can't end volta spanner")); else if (end) { end_volta_span_ = volta_span_; - volta_span_ =0; + volta_span_ = 0; } - if (volta_span_ && - (scm_is_string (start_string_) || scm_is_pair (start_string_))) + if (volta_span_ + && (scm_is_string (start_string_) || scm_is_pair (start_string_))) { - warning (_ ("Already have a volta spanner. Stopping that one prematurely.")); - + warning (_ ("already have a volta spanner, ending that one prematurely")); + if (end_volta_span_) { - warning (_ ("Also have a stopped spanner. Giving up.")); - return ; + warning (_ ("also already have an ended spanner")); + warning (_ ("giving up")); + return; } end_volta_span_ = volta_span_; volta_span_ = 0; } - if (!volta_span_ && - (scm_is_string (start_string_) || scm_is_pair (start_string_))) + if (!volta_span_ + && (scm_is_string (start_string_) || scm_is_pair (start_string_))) { - started_mom_ = now_mom () ; + started_mom_ = now_mom (); volta_span_ = make_spanner ("VoltaBracket", SCM_EOL); - volta_span_->set_property ("text", start_string_); } } +void +Volta_engraver::acknowledge_note_column (Grob_info i) +{ + if (volta_span_) + Volta_bracket_interface::add_column (volta_span_, i.grob()); +} void -Volta_engraver::acknowledge_grob (Grob_info i) +Volta_engraver::acknowledge_bar_line (Grob_info i) { - if (Item* item = dynamic_cast (i.grob_)) - { - if (Note_column::has_interface (item)) - { - if (volta_span_) - Volta_bracket_interface::add_column (volta_span_,item); - } - if (Bar_line::has_interface (item)) - { - if (volta_span_) - Volta_bracket_interface::add_bar (volta_span_, item); - if (end_volta_span_) - Volta_bracket_interface::add_bar (end_volta_span_ , item); - } - } - else if (Staff_symbol::has_interface (i.grob_)) - { - /* - We only want to know about a single staff: then we add to the - support. */ - if (staff_ != SCM_EOL) - staff_ = SCM_UNDEFINED; + if (volta_span_) + Volta_bracket_interface::add_bar (volta_span_, i.item ()); + if (end_volta_span_) + Volta_bracket_interface::add_bar (end_volta_span_, i.item ()); +} + +void +Volta_engraver::acknowledge_staff_symbol (Grob_info i) +{ + /* + We only want to know about a single staff: then we add to the + support. */ + if (staff_ != SCM_EOL) + staff_ = SCM_UNDEFINED; - if (staff_ != SCM_UNDEFINED) - staff_ = i.grob_->self_scm (); - } + if (staff_ != SCM_UNDEFINED) + staff_ = i.grob ()->self_scm (); } void @@ -210,9 +198,7 @@ Volta_engraver::finalize () { } - - -void +void Volta_engraver::stop_translation_timestep () { if (volta_span_ && !staff_eligible ()) @@ -223,37 +209,37 @@ Volta_engraver::stop_translation_timestep () we need to do this here, because STAFF_ is not initialized yet in the 1st call of process_music () */ - - volta_span_->suicide ( ); + + volta_span_->suicide (); volta_span_ = 0; } - + if (end_volta_span_ && !end_volta_span_->get_bound (RIGHT)) { - Grob * cc = unsmob_grob (get_property ("currentCommandColumn")); - Item * ci = dynamic_cast (cc); + Grob *cc = unsmob_grob (get_property ("currentCommandColumn")); + Item *ci = dynamic_cast (cc); end_volta_span_->set_bound (RIGHT, ci); } - end_volta_span_ =0; + end_volta_span_ = 0; if (volta_span_ && !volta_span_->get_bound (LEFT)) { - Grob * cc = unsmob_grob (get_property ("currentCommandColumn")); - Item * ci = dynamic_cast (cc); + Grob *cc = unsmob_grob (get_property ("currentCommandColumn")); + Item *ci = dynamic_cast (cc); volta_span_->set_bound (LEFT, ci); } - } /* TODO: should attach volta to paper-column if no bar is found. - */ - -ENTER_DESCRIPTION (Volta_engraver, -/* descr */ "Make volta brackets.", -/* creats*/ "VoltaBracket", -/* accepts */ "", -/* acks */ "bar-line-interface staff-symbol-interface note-column-interface", -/* reads */ "repeatCommands voltaSpannerDuration stavesFound", -/* write */ ""); +*/ +ADD_ACKNOWLEDGER (Volta_engraver, staff_symbol); +ADD_ACKNOWLEDGER (Volta_engraver, note_column); +ADD_ACKNOWLEDGER (Volta_engraver, bar_line); +ADD_TRANSLATOR (Volta_engraver, + /* descr */ "Make volta brackets.", + /* creats*/ "VoltaBracket", + /* accepts */ "", + /* reads */ "repeatCommands voltaSpannerDuration stavesFound", + /* write */ "");