X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Ftie-engraver.cc;h=98eac4b19b81355b595133986f4bbf47565f40a5;hb=2bbacb364aa29041af9cbbbd32cfad2e8e387cb3;hp=fa1617612a39b44531f946e045efdb7b7f0b24df;hpb=f4abbfff5f0d985a457e15586dbcc3ae473b0dee;p=lilypond.git diff --git a/lily/tie-engraver.cc b/lily/tie-engraver.cc index fa1617612a..98eac4b19b 100644 --- a/lily/tie-engraver.cc +++ b/lily/tie-engraver.cc @@ -1,7 +1,7 @@ /* This file is part of LilyPond, the GNU music typesetter. - Copyright (C) 1998--2014 Han-Wen Nienhuys + Copyright (C) 1998--2015 Han-Wen Nienhuys LilyPond is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -23,6 +23,7 @@ #include "international.hh" #include "item.hh" #include "note-head.hh" +#include "pitch.hh" #include "protected-scm.hh" #include "spanner.hh" #include "staff-symbol-referencer.hh" @@ -74,32 +75,33 @@ class Tie_engraver : public Engraver Stream_event *event_; vector now_heads_; vector heads_to_tie_; - vector ties_; + vector ties_; Spanner *tie_column_; + bool tie_notehead (Grob *h, bool enharmonic); protected: void process_acknowledged (); void stop_translation_timestep (); void start_translation_timestep (); - DECLARE_ACKNOWLEDGER (note_head); - DECLARE_TRANSLATOR_LISTENER (tie); + void acknowledge_note_head (Grob_info); + void listen_tie (Stream_event *); void process_music (); - void typeset_tie (Grob *); + void typeset_tie (Spanner *); void report_unterminated_tie (Head_event_tuple const &); bool has_autosplit_end (Stream_event *event); public: TRANSLATOR_DECLARATIONS (Tie_engraver); }; -Tie_engraver::Tie_engraver () +Tie_engraver::Tie_engraver (Context *c) + : Engraver (c) { event_ = 0; tie_column_ = 0; event_processed_ = false; } -IMPLEMENT_TRANSLATOR_LISTENER (Tie_engraver, tie); void Tie_engraver::listen_tie (Stream_event *ev) { @@ -145,17 +147,16 @@ Tie_engraver::process_music () context ()->set_property ("tieMelismaBusy", SCM_BOOL_T); } -void -Tie_engraver::acknowledge_note_head (Grob_info i) +bool +Tie_engraver::tie_notehead (Grob *h, bool enharmonic) { - Grob *h = i.grob (); + bool found = false; - now_heads_.push_back (h); - for (vsize i = heads_to_tie_.size (); i--;) + for (vsize i = 0; i < heads_to_tie_.size (); i++) { Grob *th = heads_to_tie_[i].head_; - Stream_event *right_ev = Stream_event::unsmob (h->get_property ("cause")); - Stream_event *left_ev = Stream_event::unsmob (th->get_property ("cause")); + Stream_event *right_ev = unsmob (h->get_property ("cause")); + Stream_event *left_ev = unsmob (th->get_property ("cause")); /* maybe should check positions too. @@ -167,10 +168,15 @@ Tie_engraver::acknowledge_note_head (Grob_info i) Make a tie only if pitches are equal or if event end was not generated by Completion_heads_engraver. */ - if (ly_is_equal (right_ev->get_property ("pitch"), left_ev->get_property ("pitch")) + SCM p1 = left_ev->get_property ("pitch"); + SCM p2 = right_ev->get_property ("pitch"); + if ((enharmonic + ? (unsmob (p1) && unsmob (p2) && + unsmob (p1)->tone_pitch () == unsmob (p2)->tone_pitch ()) + : ly_is_equal (p1, p2)) && (!Tie_engraver::has_autosplit_end (left_ev))) { - Grob *p = heads_to_tie_[i].tie_; + Spanner *p = heads_to_tie_[i].tie_; Moment end = heads_to_tie_[i].end_moment_; Stream_event *cause = heads_to_tie_[i].tie_event_ @@ -191,6 +197,7 @@ Tie_engraver::acknowledge_note_head (Grob_info i) ties_.push_back (p); heads_to_tie_.erase (heads_to_tie_.begin () + i); + found = true; /* Prevent all other tied notes ending at the same moment (assume implicitly the notes have also started at the same moment!) @@ -202,14 +209,27 @@ Tie_engraver::acknowledge_note_head (Grob_info i) if (heads_to_tie_[j].end_moment_ == end) heads_to_tie_[j].tie_from_chord_created = true; } + break; } } + return found; +} + +void +Tie_engraver::acknowledge_note_head (Grob_info i) +{ + Grob *h = i.grob (); + + now_heads_.push_back (h); + + if (!tie_notehead (h, false)) + tie_notehead (h, true); if (ties_.size () && ! tie_column_) tie_column_ = make_spanner ("TieColumn", ties_[0]->self_scm ()); if (tie_column_) - for (vsize i = ties_.size (); i--;) + for (vsize i = 0; i < ties_.size (); i++) Tie_column::add_tie (tie_column_, ties_[i]); } @@ -261,7 +281,7 @@ Tie_engraver::process_acknowledged () { Grob *head = now_heads_[i]; Stream_event *left_ev - = Stream_event::unsmob (head->get_property ("cause")); + = unsmob (head->get_property ("cause")); if (!left_ev) { @@ -281,7 +301,7 @@ Tie_engraver::process_acknowledged () !tie_event && !tie_stream_event && scm_is_pair (s); s = scm_cdr (s)) { - Stream_event *ev = Stream_event::unsmob (scm_car (s)); + Stream_event *ev = unsmob (scm_car (s)); if (!ev) continue; @@ -347,26 +367,31 @@ Tie_engraver::stop_translation_timestep () } void -Tie_engraver::typeset_tie (Grob *her) +Tie_engraver::typeset_tie (Spanner *her) { - if (! (Tie::head (her, LEFT) && Tie::head (her, RIGHT))) - warning (_ ("lonely tie")); + Grob *left_head = Tie::head (her, LEFT); + Grob *right_head = Tie::head (her, RIGHT); - Drul_array new_head_drul; - new_head_drul[LEFT] = Tie::head (her, LEFT); - new_head_drul[RIGHT] = Tie::head (her, RIGHT); - for (LEFT_and_RIGHT (d)) + if (!left_head || !right_head) { - if (!Tie::head (her, d)) - new_head_drul[d] = Tie::head (her, (Direction) - d); + warning (_ ("lonely tie")); + if (!left_head) + left_head = right_head; + else + right_head = left_head; } - Spanner *sp = dynamic_cast (her); - sp->set_bound (LEFT, new_head_drul[LEFT]); - sp->set_bound (RIGHT, new_head_drul[RIGHT]); + her->set_bound (LEFT, left_head); + her->set_bound (RIGHT, right_head); +} + +void +Tie_engraver::boot () +{ + ADD_LISTENER (Tie_engraver, tie); + ADD_ACKNOWLEDGER (Tie_engraver, note_head); } -ADD_ACKNOWLEDGER (Tie_engraver, note_head); ADD_TRANSLATOR (Tie_engraver, /* doc */ "Generate ties between note heads of equal pitch.",