X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fstem.cc;h=9ef07652e33bff3df8fc314e793fbed3a4e51c11;hb=f0e148170da8ff23b8f5647e83a323bf4d62a918;hp=09786b750b5d205d4b7f834b6c6fa69fe507453b;hpb=c5a3f0c024f4cb629811cff9eb04abff36e94138;p=lilypond.git diff --git a/lily/stem.cc b/lily/stem.cc index 09786b750b..9ef07652e3 100644 --- a/lily/stem.cc +++ b/lily/stem.cc @@ -275,8 +275,6 @@ Stem::calc_stem_end_position (SCM smob) return me->get_property ("stem-end-position"); } - Real ss = Staff_symbol_referencer::staff_space (me); - int durlog = duration_log (me); vector a; /* WARNING: IN HALF SPACES */ @@ -291,41 +289,6 @@ Stem::calc_stem_end_position (SCM smob) if (!no_extend_b && dir * stem_end < 0) stem_end = 0.0; - - /* Make a little room if we have a upflag and there is a dot. - previous approach was to lengthen the stem. This is not - good typesetting practice. */ - if (!get_beam (me) && dir == UP - && durlog > 2) - { - Grob *closest_to_flag = extremal_heads (me)[dir]; - Grob *dots = closest_to_flag - ? Rhythmic_head::get_dots (closest_to_flag) : 0; - - if (dots) - { - Real dp = Staff_symbol_referencer::get_position (dots); - Interval flag_yext = flag (me).extent (Y_AXIS) * (2 / ss) + stem_end; - - /* Very gory: add myself to the X-support of the parent, - which should be a dot-column. */ - - if (flag_yext.distance (dp) < 0.5) - { - Grob *par = dots->get_parent (X_AXIS); - - if (Dot_column::has_interface (par)) - { - Side_position_interface::add_support (par, me); - - /* TODO: apply some better logic here. The flag is - curved inwards, so this will typically be too - much. */ - } - } - } - } - return scm_from_double (stem_end); } @@ -406,7 +369,7 @@ Stem::duration_log (Grob *me) return (scm_is_number (s)) ? scm_to_int (s) : 2; } -MAKE_SCHEME_CALLBACK(Stem, calc_positioning_done, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_positioning_done, 1); SCM Stem::calc_positioning_done (SCM smob) { @@ -512,7 +475,7 @@ Stem::calc_positioning_done (SCM smob) return SCM_BOOL_T; } -MAKE_SCHEME_CALLBACK(Stem, calc_direction, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_direction, 1); SCM Stem::calc_direction (SCM smob) { @@ -535,7 +498,7 @@ Stem::calc_direction (SCM smob) return scm_from_int (dir); } -MAKE_SCHEME_CALLBACK(Stem, calc_default_direction, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_default_direction, 1); SCM Stem::calc_default_direction (SCM smob) { @@ -574,11 +537,11 @@ Stem::height (SCM smob) } /* - Can't get_stencil(), since that would cache stencils too early. + Can't get_stencil (), since that would cache stencils too early. This causes problems with beams. */ Stencil *stencil = unsmob_stencil (print (smob)); - Interval iv = stencil ? stencil->extent (Y_AXIS) : Interval(); + Interval iv = stencil ? stencil->extent (Y_AXIS) : Interval (); if (beam) { if (dir == CENTER) @@ -606,6 +569,9 @@ Stem::flag (Grob *me) || unsmob_grob (me->get_object ("beam"))) return Stencil (); + if (!is_normal_stem (me)) + return Stencil (); + /* TODO: maybe property stroke-style should take different values, e.g. "" (i.e. no stroke), "single" and "double" (currently, it's @@ -861,7 +827,7 @@ Stem::get_stem_info (Grob *me) return si; } -MAKE_SCHEME_CALLBACK(Stem, calc_stem_info, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_stem_info, 1); SCM Stem::calc_stem_info (SCM smob) { @@ -1012,9 +978,9 @@ Stem::is_cross_staff (Grob *stem) return beam && Beam::is_cross_staff (beam); } -MAKE_SCHEME_CALLBACK (Stem, cross_staff, 1) +MAKE_SCHEME_CALLBACK (Stem, calc_cross_staff, 1) SCM -Stem::cross_staff (SCM smob) +Stem::calc_cross_staff (SCM smob) { return scm_from_bool (is_cross_staff (unsmob_grob (smob))); }