X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fstem.cc;h=6016eebbb439b7b067201225a0f7adcdd84d85b0;hb=5bd2d1080a904b9171ccf67520f5a172a8c3014b;hp=3f1bf40f333f84a4ccf05c512d49de4bfede2a2b;hpb=efea3f8523188cd038ea051d85827260efd420d7;p=lilypond.git diff --git a/lily/stem.cc b/lily/stem.cc index 3f1bf40f33..6016eebbb4 100644 --- a/lily/stem.cc +++ b/lily/stem.cc @@ -3,7 +3,7 @@ source file of the GNU LilyPond music typesetter - (c) 1996--2005 Han-Wen Nienhuys + (c) 1996--2007 Han-Wen Nienhuys Jan Nieuwenhuizen TODO: This is way too hairy @@ -14,26 +14,28 @@ */ #include "stem.hh" +#include "spanner.hh" #include // rint using namespace std; -#include "lookup.hh" +#include "beam.hh" #include "directional-element-interface.hh" +#include "dot-column.hh" +#include "font-interface.hh" +#include "international.hh" +#include "lookup.hh" +#include "misc.hh" #include "note-head.hh" -#include "warn.hh" #include "output-def.hh" -#include "rhythmic-head.hh" -#include "font-interface.hh" #include "paper-column.hh" -#include "misc.hh" -#include "beam.hh" -#include "rest.hh" #include "pointer-group-interface.hh" -#include "staff-symbol-referencer.hh" +#include "rest.hh" +#include "rhythmic-head.hh" #include "side-position-interface.hh" -#include "dot-column.hh" +#include "staff-symbol-referencer.hh" #include "stem-tremolo.hh" +#include "warn.hh" void Stem::set_beaming (Grob *me, int beam_count, Direction d) @@ -47,8 +49,12 @@ Stem::set_beaming (Grob *me, int beam_count, Direction d) } SCM lst = index_get_cell (pair, d); - for (int i = 0; i < beam_count; i++) - lst = scm_cons (scm_from_int (i), lst); + if (beam_count) + for (int i = 0; i < beam_count; i++) + lst = scm_cons (scm_from_int (i), lst); + else + lst = SCM_BOOL_F; + index_set_cell (pair, d, lst); } @@ -60,7 +66,9 @@ Stem::get_beaming (Grob *me, Direction d) return 0; SCM lst = index_get_cell (pair, d); - return scm_ilength (lst); + + int len = scm_ilength (lst); + return max (len, 0); } Interval @@ -80,48 +88,20 @@ Stem::chord_start_y (Grob *me) { Interval hp = head_positions (me); if (!hp.is_empty ()) - return hp[get_direction (me)] * Staff_symbol_referencer::staff_space (me) + return hp[get_grob_direction (me)] * Staff_symbol_referencer::staff_space (me) * 0.5; return 0; } -Real -Stem::stem_end_position (Grob *me) -{ - SCM p = me->get_property ("stem-end-position"); - Real pos; - if (!scm_is_number (p)) - { - pos = get_default_stem_end_position (me); - me->set_property ("stem-end-position", scm_from_double (pos)); - } - else - pos = scm_to_double (p); - - return pos; -} - -Direction -Stem::get_direction (Grob *me) -{ - Direction d = get_grob_direction (me); - if (!d) - { - d = get_default_dir (me); - // urg, AAARGH! - set_grob_direction (me, d); - } - return d; -} void Stem::set_stemend (Grob *me, Real se) { // todo: margins - Direction d = get_direction (me); + Direction d = get_grob_direction (me); - if (d && d * head_positions (me)[get_direction (me)] >= se * d) + if (d && d * head_positions (me)[get_grob_direction (me)] >= se * d) me->warning (_ ("weird stem size, check for narrow beams")); me->set_property ("stem-end-position", scm_from_double (se)); @@ -150,7 +130,7 @@ Stem::head_count (Grob *me) Grob * Stem::first_head (Grob *me) { - Direction d = get_direction (me); + Direction d = get_grob_direction (me); if (d) return extremal_heads (me)[-d]; return 0; @@ -160,7 +140,7 @@ Stem::first_head (Grob *me) Grob * Stem::last_head (Grob *me) { - Direction d = get_direction (me); + Direction d = get_grob_direction (me); if (d) return extremal_heads (me)[d]; return 0; @@ -174,7 +154,7 @@ Stem::last_head (Grob *me) Drul_array Stem::extremal_heads (Grob *me) { - const int inf = 1000000; + const int inf = INT_MAX; Drul_array extpos; extpos[DOWN] = inf; extpos[UP] = -inf; @@ -182,7 +162,7 @@ Stem::extremal_heads (Grob *me) Drul_array exthead (0, 0); extract_grob_set (me, "note-heads", heads); - for (int i = heads.size (); i--;) + for (vsize i = heads.size (); i--;) { Grob *n = heads[i]; int p = Staff_symbol_referencer::get_rounded_position (n); @@ -201,28 +181,22 @@ Stem::extremal_heads (Grob *me) return exthead; } -static int -integer_compare (int const &a, int const &b) -{ - return a - b; -} - /* The positions, in ascending order. */ -Array +vector Stem::note_head_positions (Grob *me) { - Array ps; + vector ps; extract_grob_set (me, "note-heads", heads); - for (int i = heads.size (); i--;) + for (vsize i = heads.size (); i--;) { Grob *n = heads[i]; int p = Staff_symbol_referencer::get_rounded_position (n); - ps.push (p); + ps.push_back (p); } - ps.sort (integer_compare); + vector_sort (ps, less ()); return ps; } @@ -240,62 +214,113 @@ Stem::add_head (Grob *me, Grob *n) bool Stem::is_invisible (Grob *me) { - Real stemlet_length = robust_scm2double (me->get_property ("stemlet-length"), - 0.0); + return !is_normal_stem (me) + && (robust_scm2double (me->get_property ("stemlet-length"), + 0.0) == 0.0); +} + - return !((head_count (me) - || stemlet_length > 0.0) - && scm_to_int (me->get_property ("duration-log")) >= 1); +bool +Stem::is_normal_stem (Grob *me) +{ + return head_count (me) && scm_to_int (me->get_property ("duration-log")) >= 1; } -Direction -Stem::get_default_dir (Grob *me) + +MAKE_SCHEME_CALLBACK (Stem, pure_height, 3) +SCM +Stem::pure_height (SCM smob, SCM start, SCM end) { - int staff_center = 0; - Interval hp = head_positions (me); - if (hp.is_empty ()) - return CENTER; + (void) start; + (void) end; + + Grob *me = unsmob_grob (smob); + Interval iv; + + if (!is_normal_stem (me)) + return ly_interval2scm (iv); + + Real ss = Staff_symbol_referencer::staff_space (me); + + if (!to_boolean (me->get_property ("cross-staff"))) + { + Real len = scm_to_double (calc_length (smob)) * ss / 2; + Direction dir = get_grob_direction (me); + + Interval hp = head_positions (me); + if (dir == UP) + iv = Interval (0, len); + else + iv = Interval (-len, 0); - int udistance = (int) (UP *hp[UP] - staff_center); - int ddistance = (int) (DOWN *hp[DOWN] - staff_center); + if (!hp.is_empty ()) + iv.translate (hp[dir] * ss / 2); + } - if (sign (ddistance - udistance)) - return Direction (sign (ddistance - udistance)); + /* at a minimum, make the pure-height cover the staff symbol */ + Real rad = Staff_symbol_referencer::staff_radius (me); + iv.add_point (-rad * ss); + iv.add_point (rad * ss); - return to_dir (me->get_property ("neutral-direction")); + return ly_interval2scm (iv); } +MAKE_SCHEME_CALLBACK (Stem, calc_stem_end_position, 1) +SCM +Stem::calc_stem_end_position (SCM smob) +{ + Grob *me = unsmob_grob (smob); + + if (!head_count (me)) + return scm_from_double (0.0); -Real -Stem::get_default_stem_end_position (Grob *me) + if (Grob *beam = get_beam (me)) + { + (void) beam->get_property ("quantized-positions"); + return me->get_property ("stem-end-position"); + } + + vector a; + + /* WARNING: IN HALF SPACES */ + Real length = robust_scm2double (me->get_property ("length"), 7); + + Direction dir = get_grob_direction (me); + Interval hp = head_positions (me); + Real stem_end = dir ? hp[dir] + dir * length : 0; + + /* TODO: change name to extend-stems to staff/center/'() */ + bool no_extend = to_boolean (me->get_property ("no-stem-extend")); + if (!no_extend && dir * stem_end < 0) + stem_end = 0.0; + + return scm_from_double (stem_end); +} + +/* Length is in half-spaces (or: positions) here. */ +MAKE_SCHEME_CALLBACK (Stem, calc_length, 1) +SCM +Stem::calc_length (SCM smob) { - Real ss = Staff_symbol_referencer::staff_space (me); + Grob *me = unsmob_grob (smob); + + SCM details = me->get_property ("details"); int durlog = duration_log (me); - SCM s; - Array a; - /* WARNING: IN HALF SPACES */ + Real ss = Staff_symbol_referencer::staff_space (me); Real length = 7; - SCM scm_len = me->get_property ("length"); - if (scm_is_number (scm_len)) - length = scm_to_double (scm_len); - else - { - s = me->get_property ("lengths"); - if (scm_is_pair (s)) - length = 2 * scm_to_double (robust_list_ref (durlog - 2, s)); - } + SCM s = scm_cdr (scm_assq (ly_symbol2scm ("lengths"), details)); + if (scm_is_pair (s)) + length = 2 * scm_to_double (robust_list_ref (durlog - 2, s)); - /* URGURGURG - 'set-default-stemlen' sets direction too. */ - Direction dir = get_direction (me); + Direction dir = get_grob_direction (me); /* Stems in unnatural (forced) direction should be shortened, according to [Roush & Gourlay] */ Interval hp = head_positions (me); if (dir && dir * hp[dir] >= 0) { - SCM sshorten = me->get_property ("stem-shorten"); + SCM sshorten = scm_cdr (scm_assq (ly_symbol2scm ("stem-shorten"), details)); SCM scm_shorten = scm_is_pair (sshorten) ? robust_list_ref (max (duration_log (me) - 2, 0), sshorten) : SCM_EOL; Real shorten = 2* robust_scm2double (scm_shorten, 0); @@ -307,6 +332,8 @@ Stem::get_default_stem_end_position (Grob *me) length -= shorten; } + length *= robust_scm2double (me->get_property ("length-fraction"), 1.0); + /* Tremolo stuff. */ Grob *t_flag = unsmob_grob (me->get_object ("tremolo-flag")); if (t_flag && !unsmob_grob (me->get_object ("beam"))) @@ -317,65 +344,28 @@ Stem::get_default_stem_end_position (Grob *me) (Stem_tremolo::raw_stencil () looks at the beam.) --hwn */ Real minlen = 1.0 - + 2 * Stem_tremolo::raw_stencil (t_flag).extent (Y_AXIS).length () - / ss; + + 2 * Stem_tremolo::vertical_length (t_flag) / ss; + /* We don't want to add the whole extent of the flag because the trem + and the flag can overlap partly. beam_translation gives a good + approximation */ if (durlog >= 3) - { - Interval flag_ext = flag (me).extent (Y_AXIS); - if (!flag_ext.is_empty ()) - minlen += 2 * flag_ext.length () / ss; - - /* The clash is smaller for down stems (since the tremolo is - angled up.) */ - if (dir == DOWN) - minlen -= 1.0; - } + { + Real beam_trans = Stem_tremolo::get_beam_translation (t_flag); + /* the obvious choice is (durlog - 2) here, but we need a bit more space. */ + minlen += 2 * (durlog - 1.5) * beam_trans; + + /* up-stems need even a little more space to avoid collisions. This + needs to be in sync with the tremolo positioning code in + Stem_tremolo::print */ + if (dir == UP) + minlen += beam_trans; + } length = max (length, minlen + 1.0); } - - Real st = dir ? hp[dir] + dir * length : 0; - - /* TODO: change name to extend-stems to staff/center/'() */ - bool no_extend_b = to_boolean (me->get_property ("no-stem-extend")); - if (!no_extend_b && dir * st < 0) - st = 0.0; - - /* Make a little room if we have a upflag and there is a dot. - previous approach was to lengthen the stem. This is not - good typesetting practice. */ - if (!get_beam (me) && dir == UP - && durlog > 2) - { - Grob *closest_to_flag = extremal_heads (me)[dir]; - Grob *dots = closest_to_flag - ? Rhythmic_head::get_dots (closest_to_flag) : 0; - - if (dots) - { - Real dp = Staff_symbol_referencer::get_position (dots); - Real flagy = flag (me).extent (Y_AXIS)[-dir] * 2 / ss; - - /* Very gory: add myself to the X-support of the parent, - which should be a dot-column. */ - if (dir * (st + flagy - dp) < 0.5) - { - Grob *par = dots->get_parent (X_AXIS); - - if (Dot_column::has_interface (par)) - { - Side_position_interface::add_support (par, me); - - /* TODO: apply some better logic here. The flag is - curved inwards, so this will typically be too - much. */ - } - } - } - } - return st; + + return scm_from_double (length); } - /* The log of the duration (Number of hooks on the flag minus two) */ int Stem::duration_log (Grob *me) @@ -384,7 +374,7 @@ Stem::duration_log (Grob *me) return (scm_is_number (s)) ? scm_to_int (s) : 2; } -MAKE_SCHEME_CALLBACK(Stem, calc_positioning_done, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_positioning_done, 1); SCM Stem::calc_positioning_done (SCM smob) { @@ -392,25 +382,47 @@ Stem::calc_positioning_done (SCM smob) if (!head_count (me)) return SCM_BOOL_T; + me->set_property ("positioning-done", SCM_BOOL_T); + extract_grob_set (me, "note-heads", ro_heads); - Link_array heads (ro_heads); - heads.sort (compare_position); - Direction dir = get_direction (me); + vector heads (ro_heads); + vector_sort (heads, position_less); + Direction dir = get_grob_direction (me); if (dir < 0) - heads.reverse (); + reverse (heads); Real thick = thickness (me); Grob *hed = support_head (me); - Real w = hed->extent (hed, X_AXIS)[dir]; - for (int i = 0; i < heads.size (); i++) - heads[i]->translate_axis (w - heads[i]->extent (heads[i], X_AXIS)[dir], - X_AXIS); + if (!dir) + { + programming_error ("Stem dir must be up or down."); + dir = UP; + set_grob_direction (me, dir); + } + bool is_harmonic_centered = false; + for (vsize i = 0; i < heads.size (); i++) + is_harmonic_centered = is_harmonic_centered + || heads[i]->get_property ("style") == ly_symbol2scm ("harmonic"); + is_harmonic_centered = is_harmonic_centered && is_invisible (me); + + Real w = hed->extent (hed, X_AXIS)[dir]; + for (vsize i = 0; i < heads.size (); i++) + { + Real amount = w - heads[i]->extent (heads[i], X_AXIS)[dir]; + + if (is_harmonic_centered) + amount = + hed->extent (hed, X_AXIS).linear_combination (CENTER) + - heads[i]->extent (heads[i], X_AXIS).linear_combination (CENTER); + + heads[i]->translate_axis (amount, X_AXIS); + } bool parity = true; Real lastpos = Real (Staff_symbol_referencer::get_position (heads[0])); - for (int i = 1; i < heads.size (); i++) + for (vsize i = 1; i < heads.size (); i++) { Real p = Staff_symbol_referencer::get_position (heads[i]); Real dy = fabs (lastpos- p); @@ -425,7 +437,7 @@ Stem::calc_positioning_done (SCM smob) { Real ell = heads[i]->extent (heads[i], X_AXIS).length (); - Direction d = get_direction (me); + Direction d = get_grob_direction (me); /* Reversed head should be shifted ell-thickness, but this looks too crowded, so we only shift ell-0.5*thickness. @@ -468,9 +480,7 @@ Stem::calc_positioning_done (SCM smob) return SCM_BOOL_T; } - - -MAKE_SCHEME_CALLBACK(Stem, calc_direction, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_direction, 1); SCM Stem::calc_direction (SCM smob) { @@ -483,52 +493,60 @@ Stem::calc_direction (SCM smob) dir = get_grob_direction (me); } else - dir = get_default_dir (me); - + { + SCM dd = me->get_property ("default-direction"); + dir = to_dir (dd); + if (!dir) + return me->get_property ("neutral-direction"); + } + return scm_from_int (dir); } -MAKE_SCHEME_CALLBACK (Stem, calc_stem_end_position, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_default_direction, 1); SCM -Stem::calc_stem_end_position (SCM smob) +Stem::calc_default_direction (SCM smob) { Grob *me = unsmob_grob (smob); - /* - Do the calculations for visible stems, but also for invisible stems - with note heads (i.e. half notes.) - */ - Real pos = 0.0; - if (head_count (me)) + Direction dir = CENTER; + int staff_center = 0; + Interval hp = head_positions (me); + if (!hp.is_empty ()) { - pos = stem_end_position (me); // ugh. Trigger direction calc. + int udistance = (int) (UP * hp[UP] - staff_center); + int ddistance = (int) (DOWN * hp[DOWN] - staff_center); + + dir = Direction (sign (ddistance - udistance)); } - - return scm_from_double (pos); + + return scm_from_int (dir); } -MAKE_SCHEME_CALLBACK (Stem, height, 2); + +MAKE_SCHEME_CALLBACK (Stem, height, 1); SCM -Stem::height (SCM smob, SCM ax) +Stem::height (SCM smob) { - Axis a = (Axis)scm_to_int (ax); Grob *me = unsmob_grob (smob); - assert (a == Y_AXIS); - + if (!is_normal_stem (me)) + return ly_interval2scm (Interval ()); + Direction dir = get_grob_direction (me); - /* Trigger callback. - - UGH. Should be automatic - */ Grob *beam = get_beam (me); if (beam) { - beam->get_property ("positions"); + /* trigger set-stem-lengths. */ + beam->get_property ("quantized-positions"); } - /* FIXME uncached? */ - Interval iv = me->get_stencil () ? me->get_stencil ()->extent (a) : Interval(); + /* + Can't get_stencil (), since that would cache stencils too early. + This causes problems with beams. + */ + Stencil *stencil = unsmob_stencil (print (smob)); + Interval iv = stencil ? stencil->extent (Y_AXIS) : Interval (); if (beam) { if (dir == CENTER) @@ -542,6 +560,12 @@ Stem::height (SCM smob, SCM ax) return ly_interval2scm (iv); } +Real +Stem::stem_end_position (Grob *me) +{ + return robust_scm2double (me->get_property ("stem-end-position"), 0); +} + Stencil Stem::flag (Grob *me) { @@ -550,11 +574,14 @@ Stem::flag (Grob *me) || unsmob_grob (me->get_object ("beam"))) return Stencil (); + if (!is_normal_stem (me)) + return Stencil (); + /* TODO: maybe property stroke-style should take different values, e.g. "" (i.e. no stroke), "single" and "double" (currently, it's '() or "grace"). */ - String flag_style; + string flag_style; SCM flag_style_scm = me->get_property ("flag-style"); if (scm_is_symbol (flag_style_scm)) @@ -565,8 +592,8 @@ Stem::flag (Grob *me) bool adjust = true; - String staffline_offs; - if (String::compare (flag_style, "mensural") == 0) + string staffline_offs; + if (flag_style == "mensural") /* Mensural notation: For notes on staff lines, use different flags than for notes between staff lines. The idea is that flags are always vertically aligned with the staff lines, @@ -579,7 +606,7 @@ Stem::flag (Grob *me) { int p = (int) (rint (stem_end_position (me))); staffline_offs - = Staff_symbol_referencer::on_staffline (me, p) ? "0" : "1"; + = Staff_symbol_referencer::on_line (me, p) ? "0" : "1"; } else staffline_offs = "2"; @@ -587,8 +614,8 @@ Stem::flag (Grob *me) else staffline_offs = ""; - char dir = (get_direction (me) == UP) ? 'u' : 'd'; - String font_char = flag_style + char dir = (get_grob_direction (me) == UP) ? 'u' : 'd'; + string font_char = flag_style + to_string (dir) + staffline_offs + to_string (log); Font_metric *fm = Font_interface::get_default_font (me); Stencil flag = fm->find_by_name ("flags." + font_char); @@ -598,10 +625,10 @@ Stem::flag (Grob *me) SCM stroke_style_scm = me->get_property ("stroke-style"); if (scm_is_string (stroke_style_scm)) { - String stroke_style = ly_scm2string (stroke_style_scm); - if (!stroke_style.is_empty ()) + string stroke_style = ly_scm2string (stroke_style_scm); + if (!stroke_style.empty ()) { - String font_char = to_string (dir) + stroke_style; + string font_char = to_string (dir) + stroke_style; Stencil stroke = fm->find_by_name ("flags." + font_char); if (stroke.is_empty ()) me->warning (_f ("flag stroke `%s' not found", font_char)); @@ -613,12 +640,10 @@ Stem::flag (Grob *me) return flag; } -MAKE_SCHEME_CALLBACK (Stem, width_callback, 2); +MAKE_SCHEME_CALLBACK (Stem, width, 1); SCM -Stem::width_callback (SCM e, SCM ax) +Stem::width (SCM e) { - (void) ax; - assert (scm_to_int (ax) == X_AXIS); Grob *me = unsmob_grob (e); Interval r; @@ -651,8 +676,10 @@ SCM Stem::print (SCM smob) { Grob *me = unsmob_grob (smob); + Grob *beam = get_beam (me); + Stencil mol; - Direction d = get_direction (me); + Direction d = get_grob_direction (me); Real stemlet_length = robust_scm2double (me->get_property ("stemlet-length"), 0.0); @@ -664,7 +691,6 @@ Stem::print (SCM smob) = to_boolean (me->get_property ("avoid-note-head")) ? last_head (me) : first_head (me); - Grob *beam = get_beam (me); if (!lh && !stemlet) return SCM_EOL; @@ -675,7 +701,7 @@ Stem::print (SCM smob) if (is_invisible (me)) return SCM_EOL; - Real y2 = stem_end_position (me); + Real y2 = robust_scm2double (me->get_property ("stem-end-position"), 0.0); Real y1 = y2; Real half_space = Staff_symbol_referencer::staff_space (me) * 0.5; @@ -695,13 +721,13 @@ Stem::print (SCM smob) Interval stem_y (min (y1, y2), max (y2, y1)); - if (Grob *hed = support_head (me)) + if (Grob *head = support_head (me)) { /* must not take ledgers into account. */ - Interval head_height = hed->extent (hed, Y_AXIS); - Real y_attach = Note_head::stem_attachment_coordinate (hed, Y_AXIS); + Interval head_height = head->extent (head, Y_AXIS); + Real y_attach = Note_head::stem_attachment_coordinate (head, Y_AXIS); y_attach = head_height.linear_combination (y_attach); stem_y[Direction (-d)] += d * y_attach / half_space; @@ -710,7 +736,7 @@ Stem::print (SCM smob) // URG Real stem_width = thickness (me); Real blot - = me->get_layout ()->get_dimension (ly_symbol2scm ("blotdiameter")); + = me->layout ()->get_dimension (ly_symbol2scm ("blot-diameter")); Box b = Box (Interval (-stem_width / 2, stem_width / 2), Interval (stem_y[DOWN] * half_space, stem_y[UP] * half_space)); @@ -729,12 +755,12 @@ Stem::get_translated_flag (Grob *me) Stencil fl = flag (me); if (!fl.is_empty ()) { - Direction d = get_direction (me); + Direction d = get_grob_direction (me); Real blot - = me->get_layout ()->get_dimension (ly_symbol2scm ("blotdiameter")); + = me->layout ()->get_dimension (ly_symbol2scm ("blot-diameter")); Real stem_width = thickness (me); Real half_space = Staff_symbol_referencer::staff_space (me) * 0.5; - Real y2 = stem_end_position (me); + Real y2 = robust_scm2double (me->get_property ("stem-end-position"), 0.0); fl.translate_axis (y2 * half_space - d * blot / 2, Y_AXIS); fl.translate_axis (stem_width / 2, X_AXIS); } @@ -745,13 +771,21 @@ Stem::get_translated_flag (Grob *me) /* move the stem to right of the notehead if it is up. */ -MAKE_SCHEME_CALLBACK (Stem, offset_callback, 2); +MAKE_SCHEME_CALLBACK (Stem, offset_callback, 1); SCM -Stem::offset_callback (SCM element_smob, SCM) +Stem::offset_callback (SCM smob) { - Grob *me = unsmob_grob (element_smob); - Real r = 0.0; + Grob *me = unsmob_grob (smob); + extract_grob_set (me, "rests", rests); + if (rests.size ()) + { + Grob *rest = rests.back (); + Real r = rest->extent (rest, X_AXIS).center (); + return scm_from_double (r); + } + + if (Grob *f = first_head (me)) { Interval head_wid = f->extent (f, X_AXIS); @@ -762,9 +796,9 @@ Stem::offset_callback (SCM element_smob, SCM) else attach = Note_head::stem_attachment_coordinate (f, X_AXIS); - Direction d = get_direction (me); + Direction d = get_grob_direction (me); Real real_attach = head_wid.linear_combination (d * attach); - r = real_attach; + Real r = real_attach; /* If not centered: correct for stem thickness. */ if (attach) @@ -772,17 +806,11 @@ Stem::offset_callback (SCM element_smob, SCM) Real rule_thick = thickness (me); r += -d * rule_thick * 0.5; } + return scm_from_double (r); } - else - { - extract_grob_set (me, "rests", rests); - if (rests.size ()) - { - Grob *rest = rests.top (); - r = rest->extent (rest, X_AXIS).center (); - } - } - return scm_from_double (r); + + programming_error ("Weird stem."); + return scm_from_double (0.0); } Spanner * @@ -804,8 +832,7 @@ Stem::get_stem_info (Grob *me) return si; } -/* TODO: add extra space for tremolos! */ -MAKE_SCHEME_CALLBACK(Stem, calc_stem_info, 1); +MAKE_SCHEME_CALLBACK (Stem, calc_stem_info, 1); SCM Stem::calc_stem_info (SCM smob) { @@ -820,26 +847,50 @@ Stem::calc_stem_info (SCM smob) Real staff_space = Staff_symbol_referencer::staff_space (me); Grob *beam = get_beam (me); + + if (beam) + { + (void) beam->get_property ("beaming"); + } + Real beam_translation = Beam::get_beam_translation (beam); Real beam_thickness = Beam::get_thickness (beam); int beam_count = Beam::get_direction_beam_count (beam, my_dir); + Real length_fraction + = robust_scm2double (me->get_property ("length-fraction"), 1.0); /* Simple standard stem length */ - SCM lengths = me->get_property ("beamed-lengths"); + SCM details = me->get_property ("details"); + SCM lengths = scm_cdr (scm_assq (ly_symbol2scm ("beamed-lengths"), details)); + Real ideal_length = scm_to_double (robust_list_ref (beam_count - 1, lengths)) - * staff_space + * length_fraction + /* stem only extends to center of beam */ - 0.5 * beam_thickness; /* Condition: sane minimum free stem length (chord to beams) */ - lengths = me->get_property ("beamed-minimum-free-lengths"); + lengths = scm_cdr (scm_assq (ly_symbol2scm ("beamed-minimum-free-lengths"), details)); + Real ideal_minimum_free = scm_to_double (robust_list_ref (beam_count - 1, lengths)) - * staff_space; + * staff_space + * length_fraction; + Real height_of_my_trem = 0.0; + Grob *trem = unsmob_grob (me->get_object ("tremolo-flag")); + if (trem) + { + height_of_my_trem + = Stem_tremolo::vertical_length (trem) + /* hack a bit of space around the trem. */ + + beam_translation; + } + + /* UGH It seems that also for ideal minimum length, we must use the maximum beam count (for this direction): @@ -852,6 +903,7 @@ Stem::calc_stem_info (SCM smob) Real ideal_minimum_length = ideal_minimum_free + height_of_my_beams + + height_of_my_trem /* stem only extends to center of beam */ - 0.5 * beam_thickness; @@ -879,9 +931,9 @@ Stem::calc_stem_info (SCM smob) Obviously not for grace beams. Also, not for knees. Seems to be a good thing. */ - bool no_extend_b = to_boolean (me->get_property ("no-stem-extend")); + bool no_extend = to_boolean (me->get_property ("no-stem-extend")); bool is_knee = to_boolean (beam->get_property ("knee")); - if (!no_extend_b && !is_knee) + if (!no_extend && !is_knee) { /* Highest beam of (UP) beam must never be lower than middle staffline */ @@ -893,25 +945,19 @@ Stem::calc_stem_info (SCM smob) ideal_y -= robust_scm2double (beam->get_property ("shorten"), 0); + SCM bemfl = scm_cdr (scm_assq (ly_symbol2scm ("beamed-extreme-minimum-free-lengths"), + details)); + Real minimum_free - = scm_to_double (robust_list_ref - (beam_count - 1, - me->get_property - ("beamed-extreme-minimum-free-lengths"))) - * staff_space; + = scm_to_double (robust_list_ref (beam_count - 1, bemfl)) + * staff_space + * length_fraction; - Real minimum_length = minimum_free + Real minimum_length = max (minimum_free, height_of_my_trem) + height_of_my_beams /* stem only extends to center of beam */ - 0.5 * beam_thickness; - if (Grob *tremolo = unsmob_grob (me->get_object ("tremolo-flag"))) - { - Interval y_ext = tremolo->extent (tremolo, Y_AXIS); - y_ext.widen (0.5); // FIXME. Should be tunable? - minimum_length = max (minimum_length, y_ext.length ()); - } - ideal_y *= my_dir; Real minimum_y = note_start + minimum_length; Real shortest_y = minimum_y * my_dir; @@ -930,27 +976,57 @@ Stem::beam_multiplicity (Grob *stem) return le; } +bool +Stem::is_cross_staff (Grob *stem) +{ + Grob *beam = unsmob_grob (stem->get_object ("beam")); + return beam && Beam::is_cross_staff (beam); +} + +MAKE_SCHEME_CALLBACK (Stem, calc_cross_staff, 1) +SCM +Stem::calc_cross_staff (SCM smob) +{ + return scm_from_bool (is_cross_staff (unsmob_grob (smob))); +} + /* FIXME: Too many properties */ -ADD_INTERFACE (Stem, "stem-interface", +ADD_INTERFACE (Stem, "The stem represent the graphical stem. " "In addition, it internally connects note heads, beams and" "tremolos. " - "Rests and whole notes have invisible stems.", + "Rests and whole notes have invisible stems." + + "\n\nThe following properties may be set in the details list." + "@table @code\n" + "@item beamed-lengths \n" + "list of stem lengths given beam multiplicity. \n" + "@item beamed-minimum-free-lengths \n" + "list of normal minimum free stem lengths (chord to beams) given beam multiplicity.\n" + "@item beamed-extreme-minimum-free-lengths\n" + "list of extreme minimum free stem lengths (chord to beams) given beam multiplicity.\n" + "@item lengths\n" + "Default stem lengths. The list gives a length for each flag-count.\n" + "@item stem-shorten\n" + "How much a stem in a forced direction " + "should be shortened. The list gives an amount depending on the number " + "of flags/beams." + "@end table\n" + , /* properties */ - "avoid-note-head " "beam " - "beamed-extreme-minimum-free-lengths " - "beamed-lengths " - "beamed-minimum-free-lengths " "beaming " + "default-direction " + "details " "direction " "duration-log " "flag-style " "french-beaming " "length " - "lengths " + "length-fraction " + "max-beam-connect " "neutral-direction " "no-stem-extend " "note-heads " @@ -958,7 +1034,6 @@ ADD_INTERFACE (Stem, "stem-interface", "rests " "stem-end-position " "stem-info " - "stem-shorten " "stemlet-length " "stroke-style " "thickness "