X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fslur-engraver.cc;h=57068e6225945da903f2a264840bc7124ded6f2a;hb=82e98bb5d304b87749261f2054b219a5ab78433f;hp=55080f092b5f219f664f11a3763d4964fc763f0c;hpb=5d7f3453a3060d227d9c30b44bf66164f7a674c8;p=lilypond.git diff --git a/lily/slur-engraver.cc b/lily/slur-engraver.cc index 55080f092b..57068e6225 100644 --- a/lily/slur-engraver.cc +++ b/lily/slur-engraver.cc @@ -3,7 +3,7 @@ source file of the GNU LilyPond music typesetter - (c) 1997--2006 Han-Wen Nienhuys + (c) 1997--2007 Han-Wen Nienhuys */ #include "engraver.hh" @@ -47,7 +47,6 @@ class Slur_engraver : public Engraver protected: DECLARE_TRANSLATOR_LISTENER (slur); DECLARE_ACKNOWLEDGER (accidental); - DECLARE_ACKNOWLEDGER (dynamic_line_spanner); DECLARE_ACKNOWLEDGER (fingering); DECLARE_ACKNOWLEDGER (note_column); DECLARE_ACKNOWLEDGER (script); @@ -80,7 +79,8 @@ Slur_engraver::listen_slur (Stream_event *ev) ASSIGN_EVENT_ONCE (events_[START], ev); else if (d == STOP) ASSIGN_EVENT_ONCE (events_[STOP], ev); - else ev->origin ()->warning (_ ("Invalid direction of slur-event")); + else ev->origin ()->warning (_f ("direction of %s invalid: %d", + "slur-event", int (d))); } void @@ -111,12 +111,6 @@ Slur_engraver::acknowledge_accidental (Grob_info info) acknowledge_extra_object (info); } -void -Slur_engraver::acknowledge_dynamic_line_spanner (Grob_info info) -{ - acknowledge_extra_object (info); -} - void Slur_engraver::acknowledge_fingering (Grob_info info) { @@ -153,7 +147,11 @@ void Slur_engraver::finalize () { if (slurs_.size ()) - slurs_[0]->warning (_ ("unterminated slur")); + { + slurs_[0]->warning (_ ("unterminated slur")); + for (vsize i = 0; i < slurs_.size (); i++) + slurs_[i]->suicide (); + } } void @@ -162,7 +160,7 @@ Slur_engraver::process_music () if (events_[STOP]) { if (slurs_.size () == 0) - events_[STOP]->origin ()->warning (_ ("can't end slur")); + events_[STOP]->origin ()->warning (_ ("cannot end slur")); end_slurs_ = slurs_; @@ -196,14 +194,29 @@ Slur_engraver::process_music () void Slur_engraver::stop_translation_timestep () { + if (Grob *g = unsmob_grob (get_property ("currentCommandColumn"))) + { + for (vsize i = 0; i < end_slurs_.size (); i++) + Slur::add_extra_encompass (end_slurs_[i], g); + + if (!events_[START]) + for (vsize i = 0; i < slurs_.size (); i++) + Slur::add_extra_encompass (slurs_[i], g); + } + + for (vsize i = 0; i < end_slurs_.size (); i++) - announce_end_grob (end_slurs_[i], SCM_EOL); + { + Spanner * s = dynamic_cast (end_slurs_[i]); + if (!s->get_bound (RIGHT)) + s->set_bound (RIGHT, unsmob_grob (get_property ("currentMusicalColumn"))); + announce_end_grob (s, SCM_EOL); + } end_slurs_.clear (); events_[START] = events_[STOP] = 0; } ADD_ACKNOWLEDGER (Slur_engraver, accidental); -ADD_ACKNOWLEDGER (Slur_engraver, dynamic_line_spanner); ADD_ACKNOWLEDGER (Slur_engraver, fingering); ADD_ACKNOWLEDGER (Slur_engraver, note_column); ADD_ACKNOWLEDGER (Slur_engraver, script); @@ -213,6 +226,8 @@ ADD_ACKNOWLEDGER (Slur_engraver, tuplet_number); ADD_TRANSLATOR (Slur_engraver, /* doc */ "Build slur grobs from slur events", /* create */ "Slur", - /* accept */ "slur-event", - /* read */ "slurMelismaBusy doubleSlurs", + /* read */ + "slurMelismaBusy " + "doubleSlurs ", + /* write */ "");