X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fseparating-group-spanner.cc;h=14e457b6ef047a3caf2bb245d44210e44aa79b18;hb=730c54a571ab3b6c30e02be5f93c876abee0f9a7;hp=d102e35bdb4c36945d71eb7424d673c5ceab69a9;hpb=54404c570a48ddf9772c5ca64a154d0c0149e61e;p=lilypond.git diff --git a/lily/separating-group-spanner.cc b/lily/separating-group-spanner.cc index d102e35bdb..14e457b6ef 100644 --- a/lily/separating-group-spanner.cc +++ b/lily/separating-group-spanner.cc @@ -1,138 +1,118 @@ -/* - separating-group-spanner.cc -- implement Separating_group_spanner - +/* + separating-group-spanner.cc -- implement Separating_group_spanner + source file of the GNU LilyPond music typesetter - - (c) 1998--2001 Han-Wen Nienhuys - - */ + + (c) 1998--2006 Han-Wen Nienhuys +*/ #include "separating-group-spanner.hh" + #include "separation-item.hh" #include "paper-column.hh" -#include "paper-def.hh" +#include "output-def.hh" #include "dimensions.hh" -#include "group-interface.hh" +#include "pointer-group-interface.hh" void -Separating_group_spanner::find_rods (Item * r, SCM next) +Separating_group_spanner::find_rods (Item *r, + vector const &separators, + vsize idx, + Real padding) { - Interval ri (Separation_item::my_width (r)); - if (ri.empty_b ()) - return; /* - This is an inner loop, however, in most cases, the interesting L - will just be the first entry of NEXT, making it linear in most of - the cases. */ - for(; gh_pair_p (next); next = gh_cdr (next)) + This is an inner loop: look for the first normal (unbroken) Left + grob. This looks like an inner loop (ie. quadratic total), but in + most cases, the interesting L will just be the first entry of + NEXT, making it linear in most of the cases. + */ + for (; idx != VPOS; idx--) { - Item *l = dynamic_cast (unsmob_grob (gh_car( next))); + Item *l = dynamic_cast (separators[idx]); Item *lb = l->find_prebroken_piece (RIGHT); if (lb) { - Interval li (Separation_item::my_width (lb)); - - if (!li.empty_b ()) + Interval li (Separation_item::width (lb)); + Interval ri (Separation_item::conditional_width (r, lb)); + if (!li.is_empty () && !ri.is_empty ()) { Rod rod; - rod.item_l_drul_[LEFT] = lb; - rod.item_l_drul_[RIGHT] = r; + rod.item_drul_[LEFT] = lb; + rod.item_drul_[RIGHT] = r; - rod.distance_f_ = li[RIGHT] - ri[LEFT]; - - rod.columnize (); + rod.distance_ = li[RIGHT] - ri[LEFT] + padding; rod.add_to_cols (); } } - Interval li (Separation_item::my_width (l)); - if (!li.empty_b ()) + Interval li (Separation_item::width (l)); + Interval ri (Separation_item::conditional_width (r, l)); + if (!li.is_empty () && !ri.is_empty ()) { Rod rod; - rod.item_l_drul_[LEFT] =l; - rod.item_l_drul_[RIGHT]=r; + rod.item_drul_[LEFT] = l; + rod.item_drul_[RIGHT] = r; - rod.distance_f_ = li[RIGHT] - ri[LEFT]; - - rod.columnize (); - rod.add_to_cols (); + rod.distance_ = li[RIGHT] - ri[LEFT] + padding; + if (rod.distance_ > 0.0) + rod.add_to_cols (); break; } - else - /* - this grob doesn't cause a constraint. We look further until we - find one that does. */ - ; + + /* + this grob doesn't cause a constraint. We look further until we + find one that does. + */ } } -MAKE_SCHEME_CALLBACK (Separating_group_spanner,set_spacing_rods,1); +MAKE_SCHEME_CALLBACK (Separating_group_spanner, set_spacing_rods, 1); SCM Separating_group_spanner::set_spacing_rods (SCM smob) { - Grob*me = unsmob_grob (smob); - - for (SCM s = me->get_grob_property ("elements"); gh_pair_p (s) && gh_pair_p (gh_cdr (s)); s = gh_cdr (s)) - { - /* - Order of elements is reversed! - */ - SCM elt = gh_car (s); - Item *r = dynamic_cast (unsmob_grob (elt)); + Grob *me = unsmob_grob (smob); + + /* + Ugh: padding is added doubly, also for SeparationItem + */ + Real padding = robust_scm2double (me->get_property ("padding"), 0.1); + extract_grob_set (me, "elements", elts); + for (vsize i = elts.size (); i-- > 1;) + { + Item *r = dynamic_cast (elts[i]); if (!r) continue; + if (Separation_item::width (r).is_empty ()) + continue; + Item *rb - = dynamic_cast (r->find_prebroken_piece (LEFT)); - - find_rods (r, gh_cdr (s)); + = dynamic_cast (r->find_prebroken_piece (LEFT)); + + find_rods (r, elts, i - 1, padding); if (rb) - find_rods (rb, gh_cdr (s)); + find_rods (rb, elts, i - 1, padding); } -#if 0 - /* - TODO; restore this. - */ - /* - We've done our job, so we get lost. - */ - for (SCM s = me->get_grob_property ("elements"); gh_pair_p (s); s = gh_cdr (s)) - { - Item * it =dynamic_cast (unsmob_grob (gh_car (s))); - if (it && it->broken_b ()) - { - it->find_prebroken_piece (LEFT) ->suicide (); - it->find_prebroken_piece (RIGHT)->suicide (); - } - it->suicide (); - } - me->suicide (); -#endif - return SCM_UNSPECIFIED ; + return SCM_UNSPECIFIED; } void -Separating_group_spanner::add_spacing_unit (Grob* me ,Item*i) +Separating_group_spanner::add_spacing_unit (Grob *me, Item *i) { - Pointer_group_interface::add_element (me, "elements",i); - me->add_dependency (i); + Pointer_group_interface::add_unordered_grob (me, ly_symbol2scm ("elements"), i); } +ADD_INTERFACE (Separating_group_spanner, "separation-spanner-interface", + "A spanner that calculates spacing constraints (\"rods\") " + "using the @code{separation-item-interface} grobs in @code{elements}.", -void -Separating_group_spanner::set_interface (Grob*) -{ -} - -bool -Separating_group_spanner::has_interface (Grob*) -{//todo - assert (false); -} + /* properties */ + "elements " + "padding ");