X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fseparating-group-spanner.cc;h=05c5264b1da57550f1752859a0727c1c94262263;hb=015bb3813eb4ac879df0561e5c6e28e9d1146792;hp=c00bfd8e13368ee3a3e2c46d60c5bfd90aace86c;hpb=bb36bac02a64770871780231ecc709cb18b20932;p=lilypond.git

diff --git a/lily/separating-group-spanner.cc b/lily/separating-group-spanner.cc
index c00bfd8e13..05c5264b1d 100644
--- a/lily/separating-group-spanner.cc
+++ b/lily/separating-group-spanner.cc
@@ -3,93 +3,121 @@
   
   source file of the GNU LilyPond music typesetter
   
-  (c) 1998--2000 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+  (c) 1998--2005 Han-Wen Nienhuys <hanwen@cs.uu.nl>
   
  */
 
 #include "separating-group-spanner.hh"
-#include "single-malt-grouping-item.hh"
+
+#include "separation-item.hh"
 #include "paper-column.hh"
-#include "paper-def.hh"
+#include "output-def.hh"
 #include "dimensions.hh"
+#include "group-interface.hh"
 
-static Rod
-make_rod (Single_malt_grouping_item *l, Single_malt_grouping_item *r)
+void
+Separating_group_spanner::find_rods (Item * r, SCM next, Real padding)
 {
-  Rod rod;
-  rod.item_l_drul_[LEFT] =l;
-  rod.item_l_drul_[RIGHT]=r;
 
-  Interval li (l->my_width ());
-  Interval ri (r->my_width ());
-  
-  if (li.empty_b () || ri.empty_b ())
-    rod.distance_f_ = 0;
-  else
-    rod.distance_f_ = li[RIGHT] - ri[LEFT];
+  /*
+    This is an inner loop: look for the first normal (unbroken) Left
+    grob.  This looks like an inner loop (ie. quadratic total), but in
+    most cases, the interesting L will just be the first entry of
+    NEXT, making it linear in most of the cases.
+  */
+  if (Separation_item::width (r).is_empty ())
+    return; 
+
+
+  for (; scm_is_pair (next); next = scm_cdr (next))
+    {
+      Item *l = dynamic_cast<Item*> (unsmob_grob (scm_car ( next)));
+      Item *lb = l->find_prebroken_piece (RIGHT);
+
+      if (lb)
+	{
+	  Interval li (Separation_item::width (lb));
+	  Interval ri (Separation_item::conditional_width (r, lb));
+	  if (!li.is_empty () && !ri.is_empty ())
+	    {
+	      Rod rod;
+
+	      rod.item_l_drul_[LEFT] = lb;
+	      rod.item_l_drul_[RIGHT] = r;
 
-  return rod;
+	      rod.distance_ = li[RIGHT] - ri[LEFT] + padding;
+	      rod.add_to_cols ();
+	    }
+	}
+
+      Interval li (Separation_item::width (l));
+      Interval ri (Separation_item::conditional_width (r, l));
+      if (!li.is_empty () && !ri.is_empty ())
+	{
+	  Rod rod;
+
+	  rod.item_l_drul_[LEFT] = l;
+	  rod.item_l_drul_[RIGHT]= r;
+
+	  rod.distance_ = li[RIGHT] - ri[LEFT] + padding;
+	
+	  rod.add_to_cols ();
+	  break;
+	}
+
+      /*
+	this grob doesn't cause a constraint. We look further until we
+	find one that does.
+      */
+
+    }
 }
-  
 
-Array<Rod>
-Separating_group_spanner::get_rods () const
+MAKE_SCHEME_CALLBACK (Separating_group_spanner, set_spacing_rods, 1);
+SCM
+Separating_group_spanner::set_spacing_rods (SCM smob)
 {
-  Array<Rod> a;
+  Grob*me = unsmob_grob (smob);
+
+  /*
+    Ugh: padding is added doubly, also for SeparationItem
+   */
+  Real padding = robust_scm2double (me->get_property ("padding"), 0.1);
   
-  for (SCM s = get_elt_property ("elements"); gh_pair_p (s) && gh_pair_p (gh_cdr (s)); s = gh_cdr (s))
+  for (SCM s = me->get_property ("elements"); scm_is_pair (s) && scm_is_pair (scm_cdr (s)); s = scm_cdr (s))
     {
       /*
 	Order of elements is reversed!
        */
-      SCM elt = gh_cadr (s);
-      SCM next_elt = gh_car (s);
-
-      Single_malt_grouping_item *l = dynamic_cast<Single_malt_grouping_item*> (unsmob_element (elt));
-      Single_malt_grouping_item *r = dynamic_cast<Single_malt_grouping_item*> (unsmob_element ( next_elt));
+      SCM elt = scm_car (s);
+      Item *r = unsmob_item (elt);
 
-      if (!r || !l)
+      if (!r)
 	continue;
-      
-      Single_malt_grouping_item *lb
-	= dynamic_cast<Single_malt_grouping_item*>(l->find_broken_piece (RIGHT));
 
-      Single_malt_grouping_item *rb
-	= dynamic_cast<Single_malt_grouping_item*>(r->find_broken_piece (LEFT));
-      
-      a.push (make_rod(l,  r));
-      if (lb)
-	{
-	  Rod rod(make_rod (lb, r));
-	  a.push (rod);
-	}
+      Item *rb
+	= dynamic_cast<Item*> (r->find_prebroken_piece (LEFT));
       
+      find_rods (r, scm_cdr (s), padding);
       if (rb)
-	{
-	  a.push (make_rod (l, rb));
-	}
-      
-      if (lb && rb)
-	{
-	  Rod rod(make_rod (lb, rb));
-	  a.push (rod);
-	}
+	find_rods (rb, scm_cdr (s), padding);
     }
-      
-  return a;
+
+  return SCM_UNSPECIFIED ;
 }
 
 void
-Separating_group_spanner::add_spacing_unit (Single_malt_grouping_item*i)
+Separating_group_spanner::add_spacing_unit (Grob* me , Item*i)
 {
-  set_elt_property ("elements",
-		    gh_cons (i->self_scm_,
-			     get_elt_property ("elements")));
-  add_dependency (i);
+  Pointer_group_interface::add_grob (me, ly_symbol2scm ("elements"), i);
+  me->add_dependency (i);
 }
 
 
-Separating_group_spanner::Separating_group_spanner ()
-{
-  set_elt_property ("elements", SCM_EOL);
-}
+
+
+
+ADD_INTERFACE (Separating_group_spanner, "separation-spanner-interface",
+	       "A spanner that calculates spacing constraints (\"rods\") "
+	       "using the @code{separation-item-interface} grobs in @code{elements}.",
+	       "elements padding");