X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Frhythmic-column-engraver.cc;h=fc21e618eb202059a234c64e33e29101aed22721;hb=8f5514f91a6d721dcacd9f868bd704b738798dc5;hp=5483ff9ace026a385bee7646257e81806ee3836a;hpb=d36e8ced83cfeabcf4ec3840ffe93a717a17ac4d;p=lilypond.git

diff --git a/lily/rhythmic-column-engraver.cc b/lily/rhythmic-column-engraver.cc
index 5483ff9ace..fc21e618eb 100644
--- a/lily/rhythmic-column-engraver.cc
+++ b/lily/rhythmic-column-engraver.cc
@@ -1,105 +1,136 @@
 /*
-  rhythmic-column-grav.cc -- implement Rhythmic_column_engraver
+  rhythmic-column-engraver.cc -- implement Rhythmic_column_engraver
 
   source file of the GNU LilyPond music typesetter
 
-  (c)  1997--1999 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+  (c) 1997--2007 Han-Wen Nienhuys <hanwen@xs4all.nl>
 */
 
-#include "rhythmic-column-engraver.hh"
-#include "note-head.hh"
+#include "engraver.hh"
+#include "rhythmic-head.hh"
 #include "stem.hh"
 #include "note-column.hh"
+#include "item.hh"
 #include "dot-column.hh"
-#include "musical-request.hh"
+#include "pointer-group-interface.hh"
 
-Rhythmic_column_engraver::Rhythmic_column_engraver()
+#include "translator.icc"
+
+/*
+  this engraver  glues together stems, rests and note heads into a NoteColumn
+  grob.
+
+  It also generates spacing objects.  Originally, we have tried to
+  have the spacing functionality at different levels.
+
+  - by simply using the sequence of Separation-item as
+  spacing-sequences (at staff level). Unfortunately, this fucks up if
+  there are different kinds of tuplets in different voices (8th and
+  8ths triplets combined made the program believe there were 1/12 th
+  notes.).
+
+  Doing it in a separate engraver using timing info is generally
+  complicated (start/end time management), and fucks up if a voice
+  changes staff.
+
+  Now we do it from here again. This has the problem that voices can
+  appear and disappear at will, leaving lots of loose ends (the note
+  spacing engraver don't know where to connect the last note of the
+  voice on the right with), but we don't complain about those, and let
+  the default spacing do its work.
+*/
+
+class Rhythmic_column_engraver : public Engraver
+{
+  vector<Grob*> rheads_;
+  Grob *stem_;
+  Grob *note_column_;
+  Grob *dotcol_;
+
+  TRANSLATOR_DECLARATIONS (Rhythmic_column_engraver);
+protected:
+
+  DECLARE_ACKNOWLEDGER (dot_column);
+  DECLARE_ACKNOWLEDGER (stem);
+  DECLARE_ACKNOWLEDGER (rhythmic_head);
+  void process_acknowledged ();
+  void stop_translation_timestep ();
+};
+
+Rhythmic_column_engraver::Rhythmic_column_engraver ()
 {
-  stem_l_ =0;
-  ncol_p_=0;
-  dotcol_l_ =0;
+
+  stem_ = 0;
+  note_column_ = 0;
+  dotcol_ = 0;
 }
 
 
 void
 Rhythmic_column_engraver::process_acknowledged ()
 {
-  if (rhead_l_arr_.size ())
+  if (rheads_.size ())
     {
-      if (!ncol_p_)
+      if (!note_column_)
 	{
-	  ncol_p_ = new Note_column;
-	  announce_element (Score_element_info (ncol_p_, 0));
+	  note_column_ = make_item ("NoteColumn", rheads_[0]->self_scm ());
 	}
 
-      for (int i=0; i < rhead_l_arr_.size (); i++)
+      for (vsize i = 0; i < rheads_.size (); i++)
 	{
-	  ncol_p_->add_head (rhead_l_arr_[i]);
+	  if (!rheads_[i]->get_parent (X_AXIS))
+	    Note_column::add_head (note_column_, rheads_[i]);
 	}
-      rhead_l_arr_.set_size (0);
+      rheads_.resize (0);
     }
 
-  
-  if (ncol_p_)
+  if (note_column_)
     {
-      if (dotcol_l_)
-	{
-	  ncol_p_->set_dotcol (dotcol_l_);
-	}
+      if (dotcol_
+	  && !dotcol_->get_parent (X_AXIS))
+	Note_column::set_dotcol (note_column_, dotcol_);
 
-      if (stem_l_)
+      if (stem_
+	  && !stem_->get_parent (X_AXIS))
 	{
-	  ncol_p_->set_stem (stem_l_);
-	  stem_l_ = 0;
+	  Note_column::set_stem (note_column_, stem_);
+	  stem_ = 0;
 	}
     }
 }
 
 void
-Rhythmic_column_engraver::acknowledge_element (Score_element_info i)
+Rhythmic_column_engraver::acknowledge_stem (Grob_info i)
 {
-  Item * item =  dynamic_cast <Item *> (i.elem_l_);
-  if (!item)
-    return;
- if (Stem*s=dynamic_cast<Stem *> (item))
-    {
-      stem_l_ = s;
-    }
-      else if (Rhythmic_head*r=dynamic_cast<Rhythmic_head *> (item))
-    {
-      rhead_l_arr_.push (r);
-    }
-      else if (Dot_column*d =dynamic_cast<Dot_column *> (item))
-    {
-      dotcol_l_ = d;
-    }
+  stem_ = i.grob ();
 }
 
 void
-Rhythmic_column_engraver::do_pre_move_processing()
+Rhythmic_column_engraver::acknowledge_rhythmic_head (Grob_info i)
 {
-  if (ncol_p_) 
-    {
-      // egcs
-      if (get_property ("hshift", 0).operator bool ())
-	{
-	  ncol_p_->set_elt_property (horizontal_shift_scm_sym, SCM_BOOL_T);
-	}
-
-      typeset_element (ncol_p_);
-      ncol_p_ =0;
-    }
+  rheads_.push_back (i.grob ());
 }
 
 void
-Rhythmic_column_engraver::do_post_move_processing()
+Rhythmic_column_engraver::acknowledge_dot_column (Grob_info i)
 {
-  dotcol_l_ =0;
-  stem_l_ =0;
+  dotcol_ = i.grob ();
 }
 
+void
+Rhythmic_column_engraver::stop_translation_timestep ()
+{
+  note_column_ = 0;
+  dotcol_ = 0;
+  stem_ = 0;
+}
 
+ADD_ACKNOWLEDGER (Rhythmic_column_engraver, dot_column);
+ADD_ACKNOWLEDGER (Rhythmic_column_engraver, stem);
+ADD_ACKNOWLEDGER (Rhythmic_column_engraver, rhythmic_head);
 
-
-
-ADD_THIS_TRANSLATOR(Rhythmic_column_engraver);
+ADD_TRANSLATOR (Rhythmic_column_engraver,
+		/* doc */ "Generates NoteColumn, an objects that groups stems, noteheads and rests.",
+		/* create */ "NoteColumn",
+		/* read */ "",
+		/* write */ "");