X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Frhythmic-column-engraver.cc;h=af4f263aa15e29b0283d11c17581bd31d1daa4d8;hb=9fc8eafc925fc7481d1163a43fb02c9b1f28fb9c;hp=152352ac82ae6b9d93a45caf95c12714dc6516a4;hpb=1d7d22c0171288be6009b68e611beaed18be993c;p=lilypond.git diff --git a/lily/rhythmic-column-engraver.cc b/lily/rhythmic-column-engraver.cc index 152352ac82..af4f263aa1 100644 --- a/lily/rhythmic-column-engraver.cc +++ b/lily/rhythmic-column-engraver.cc @@ -1,125 +1,154 @@ /* - rhythmic-column-grav.cc -- implement Rhythmic_column_engraver + rhythmic-column-engraver.cc -- implement Rhythmic_column_engraver source file of the GNU LilyPond music typesetter - (c) 1997--1999 Han-Wen Nienhuys + (c) 1997--2005 Han-Wen Nienhuys */ -#include "rhythmic-column-engraver.hh" -#include "note-head.hh" +#include "engraver.hh" +#include "rhythmic-head.hh" #include "stem.hh" #include "note-column.hh" -#include "script.hh" #include "dot-column.hh" -#include "musical-request.hh" +#include "group-interface.hh" -Rhythmic_column_engraver::Rhythmic_column_engraver() +/* + this engraver glues together stems, rests and note heads into a NoteColumn + grob. + + It also generates spacing objects. Originally, we have tried to + have the spacing functionality at different levels. + + - by simply using the sequence of Separation-item as + spacing-sequences (at staff level). Unfortunately, this fucks up if + there are different kinds of tuplets in different voices (8th and + 8ths triplets combined made the program believe there were 1/12 th + notes.). + + Doing it in a separate engraver using timing info is generally + complicated (start/end time management), and fucks up if a voice + changes staff. + + Now we do it from here again. This has the problem that voices can + appear and disappear at will, leaving lots of loose ends (the note + spacing engraver don't know where to connect the last note of the + voice on the right with), but we don't complain about those, and let + the default spacing do its work. +*/ + +class Rhythmic_column_engraver : public Engraver { - stem_l_ =0; - ncol_p_=0; - dotcol_l_ =0; -} + Link_array rheads_; + Grob *stem_; + Grob *note_column_; + Grob *dotcol_; + Grob *last_spacing_; + Grob *spacing_; + + TRANSLATOR_DECLARATIONS (Rhythmic_column_engraver); +protected: + + virtual void acknowledge_grob (Grob_info); + virtual void process_acknowledged_grobs (); + virtual void stop_translation_timestep (); +}; + +Rhythmic_column_engraver::Rhythmic_column_engraver () +{ + spacing_ = 0; + last_spacing_ = 0; + + stem_ = 0; + note_column_ = 0; + dotcol_ = 0; +} void -Rhythmic_column_engraver::process_acknowledged () +Rhythmic_column_engraver::process_acknowledged_grobs () { - if (rhead_l_arr_.size ()) + if (rheads_.size ()) { - if (!ncol_p_) + if (!note_column_) { - ncol_p_ = new Note_column; - announce_element (Score_element_info (ncol_p_, 0)); + note_column_ = make_item ("NoteColumn", rheads_[0]->self_scm ()); + + spacing_ = make_item ("NoteSpacing", SCM_EOL); + spacing_->set_property ("left-items", scm_cons (note_column_->self_scm (), SCM_EOL)); + + if (last_spacing_) + { + Pointer_group_interface::add_grob (last_spacing_, + ly_symbol2scm ("right-items"), + note_column_); + } } - for (int i=0; i < rhead_l_arr_.size (); i++) + for (int i = 0; i < rheads_.size (); i++) { - ncol_p_->add_head (rhead_l_arr_[i]); + if (!rheads_[i]->get_parent (X_AXIS)) + Note_column::add_head (note_column_, rheads_[i]); } - rhead_l_arr_.set_size (0); + rheads_.set_size (0); } - - if (ncol_p_) + if (note_column_) { - if (dotcol_l_) + if (dotcol_ + && !dotcol_->get_parent (X_AXIS)) { - ncol_p_->set_dotcol (dotcol_l_); + Note_column::set_dotcol (note_column_, dotcol_); } - if (stem_l_) + if (stem_ + && !stem_->get_parent (X_AXIS)) { - ncol_p_->set_stem (stem_l_); - stem_l_ = 0; + Note_column::set_stem (note_column_, stem_); + stem_ = 0; } - - for (int i=0; i < script_l_arr_.size(); i++) - { - if (ncol_p_) - ncol_p_->add_script (script_l_arr_[i]); - } - - script_l_arr_.clear(); } } void -Rhythmic_column_engraver::acknowledge_element (Score_element_info i) +Rhythmic_column_engraver::acknowledge_grob (Grob_info i) { - Item * item = dynamic_cast (i.elem_l_); - if (!item) + Item *item = dynamic_cast (i.grob ()); + if (!item || item->get_parent (X_AXIS)) return; - if (Script *s=dynamic_cast