X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Frhythmic-column-engraver.cc;h=3c63236546d9a36980a3fe308bcf91395c087caa;hb=61bba8a98a53e424054b26d63ead26b0696ea29d;hp=f5287f998c96dbe382ababbe3988559e3e99b544;hpb=fc3e875d6bf06f0680e897faffdcab36ad975a03;p=lilypond.git diff --git a/lily/rhythmic-column-engraver.cc b/lily/rhythmic-column-engraver.cc index f5287f998c..3c63236546 100644 --- a/lily/rhythmic-column-engraver.cc +++ b/lily/rhythmic-column-engraver.cc @@ -3,7 +3,7 @@ source file of the GNU LilyPond music typesetter - (c) 1997--2001 Han-Wen Nienhuys + (c) 1997--2004 Han-Wen Nienhuys */ @@ -13,134 +13,161 @@ #include "stem.hh" #include "note-column.hh" #include "dot-column.hh" -#include "musical-request.hh" +#include "event.hh" #include "item.hh" +#include "group-interface.hh" + + + +/* + this engraver glues together stems, rests and note heads into a NoteColumn + grob. + + It also generates spacing objects. Originally, we have tried to + have the spacing functionality at different levels. + + - by simply using the sequence of Separation-item as + spacing-sequences (at staff level). Unfortunately, this fucks up if + there are different kinds of tuplets in different voices (8th and + 8ths triplets combined made the program believe there were 1/12 th + notes.). + + Doing it in a separate engraver using timing info is generally + complicated (start/end time management), and fucks up if a voice + changes staff. + + Now we do it from here again. This has the problem that voices can + appear and disappear at will, leaving lots of loose ends (the note + spacing engraver don't know where to connect the last note of the + voice on the right with), but we don't complain about those, and let + the default spacing do its work. + + */ + class Rhythmic_column_engraver :public Engraver { - Link_array rhead_l_arr_; - Link_array grace_slur_endings_; - Grob * stem_l_; - Grob *ncol_p_; - Grob *dotcol_l_; + Link_array rheads_; + Grob * stem_; + Grob * note_column_; + Grob * dotcol_; + Grob * last_spacing_; + Grob * spacing_; + + TRANSLATOR_DECLARATIONS (Rhythmic_column_engraver); protected: - VIRTUAL_COPY_CONS (Translator); + virtual void acknowledge_grob (Grob_info); - virtual void create_grobs (); + virtual void process_acknowledged_grobs (); virtual void stop_translation_timestep (); - virtual void start_translation_timestep (); -public: - Rhythmic_column_engraver (); - }; Rhythmic_column_engraver::Rhythmic_column_engraver () { - stem_l_ =0; - ncol_p_=0; - dotcol_l_ =0; + spacing_ =0 ; + last_spacing_ = 0; + + stem_ =0; + note_column_=0; + dotcol_ =0; } void -Rhythmic_column_engraver::create_grobs () +Rhythmic_column_engraver::process_acknowledged_grobs () { - if (rhead_l_arr_.size ()) + if (rheads_.size ()) { - if (!ncol_p_) + if (!note_column_) { - ncol_p_ = new Item (get_property ("NoteColumn")); - Note_column::set_interface (ncol_p_); - announce_grob (ncol_p_, 0); + note_column_ = make_item ("NoteColumn",rheads_[0]->self_scm ()); + + spacing_ = make_item ("NoteSpacing", SCM_EOL); + spacing_->set_property ("left-items", scm_cons (note_column_->self_scm (), SCM_EOL)); + + + + + if (last_spacing_) + { + Pointer_group_interface::add_grob (last_spacing_, + ly_symbol2scm ("right-items" ), + note_column_); + } + } - for (int i=0; i < rhead_l_arr_.size (); i++) + for (int i=0; i < rheads_.size (); i++) { - if (!rhead_l_arr_[i]->parent_l (X_AXIS)) - Note_column::add_head (ncol_p_, rhead_l_arr_[i]); + if (!rheads_[i]->get_parent (X_AXIS)) + Note_column::add_head (note_column_, rheads_[i]); } - rhead_l_arr_.set_size (0); + rheads_.set_size (0); } - if (ncol_p_) + if (note_column_) { - if (dotcol_l_ - && !dotcol_l_->parent_l (X_AXIS)) + if (dotcol_ + && !dotcol_->get_parent (X_AXIS)) { - Note_column::set_dotcol (ncol_p_, dotcol_l_); + Note_column::set_dotcol (note_column_, dotcol_); } - if (stem_l_ - && !stem_l_->parent_l (X_AXIS)) + if (stem_ + && !stem_->get_parent (X_AXIS)) { - Note_column::set_stem (ncol_p_, stem_l_); - stem_l_ = 0; + Note_column::set_stem (note_column_, stem_); + stem_ = 0; } - SCM wg = get_property ("weAreGraceContext"); - bool wegrace = to_boolean (wg); - - if (!wegrace) - for (int i=0; i < grace_slur_endings_.size (); i++) - Slur::add_column (grace_slur_endings_[i], ncol_p_); - grace_slur_endings_.clear (); } } void Rhythmic_column_engraver::acknowledge_grob (Grob_info i) { - SCM wg = get_property ("weAreGraceContext"); - bool wegrace = to_boolean (wg); - if (wegrace != to_boolean (i.elem_l_->get_grob_property ("grace")) - && !Slur::has_interface (i.elem_l_)) - return ; - - Item * item = dynamic_cast (i.elem_l_); - if (item && Stem::has_interface (item)) + Item * item = dynamic_cast (i.grob_); + if (!item || item->get_parent (X_AXIS)) + return ; + if (Stem::has_interface (item)) { - stem_l_ = item; + stem_ = item; } - else if (item && Rhythmic_head::has_interface (item)) + else if (Rhythmic_head::has_interface (item)) { - rhead_l_arr_.push (item); + rheads_.push (item); } - else if (item && Dot_column::has_interface (item)) + else if (Dot_column::has_interface (item)) { - dotcol_l_ = item; + dotcol_ = item; } - else if (Slur::has_interface (i.elem_l_)) - { - /* - end slurs starting on grace notes - */ - - if (to_boolean (i.elem_l_->get_grob_property ("grace"))) - grace_slur_endings_.push (i.elem_l_); - } } void Rhythmic_column_engraver::stop_translation_timestep () { - if (ncol_p_) + note_column_ =0; + + if (spacing_) { - typeset_grob (ncol_p_); - ncol_p_ =0; + last_spacing_ = spacing_; + spacing_ =0; } + + dotcol_ =0; + stem_ =0; } -void -Rhythmic_column_engraver::start_translation_timestep () -{ - grace_slur_endings_.clear (); - dotcol_l_ =0; - stem_l_ =0; -} -ADD_THIS_TRANSLATOR (Rhythmic_column_engraver); +ENTER_DESCRIPTION (Rhythmic_column_engraver, +/* descr */ "Generates NoteColumn, an objects that groups stems, noteheads and rests.", +/* creats*/ "NoteColumn NoteSpacing", +/* accepts */ "", +/* acks */ "stem-interface rhythmic-head-interface dot-column-interface", +/* reads */ "", +/* write */ "");