X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fpitched-trill-engraver.cc;h=30d734346e53df7565c419817a9637ad1524afc0;hb=c7358ca08d062adbc9710f158fe0f965c79fc638;hp=113e13a55b1aa31c210199b914a3175e8491b675;hpb=a6bd229f7fe1dc4a03478e14ccc0c0c66b225061;p=lilypond.git diff --git a/lily/pitched-trill-engraver.cc b/lily/pitched-trill-engraver.cc index 113e13a55b..30d734346e 100644 --- a/lily/pitched-trill-engraver.cc +++ b/lily/pitched-trill-engraver.cc @@ -1,7 +1,7 @@ /* This file is part of LilyPond, the GNU music typesetter. - Copyright (C) 2005--2010 Han-Wen Nienhuys + Copyright (C) 2005--2015 Han-Wen Nienhuys LilyPond is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -30,6 +30,8 @@ #include "stream-event.hh" #include "warn.hh" +#include "translator.icc" + class Pitched_trill_engraver : public Engraver { public: @@ -38,6 +40,8 @@ public: protected: DECLARE_ACKNOWLEDGER (note_head); DECLARE_ACKNOWLEDGER (dots); + DECLARE_ACKNOWLEDGER (stem); + DECLARE_ACKNOWLEDGER (flag); DECLARE_ACKNOWLEDGER (trill_spanner); void stop_translation_timestep (); @@ -46,7 +50,7 @@ private: Item *trill_group_; Item *trill_accidental_; - vector heads_; + vector heads_; void make_trill (Stream_event *); }; @@ -64,6 +68,16 @@ Pitched_trill_engraver::acknowledge_dots (Grob_info info) heads_.push_back (info.grob ()); } void +Pitched_trill_engraver::acknowledge_stem (Grob_info info) +{ + heads_.push_back (info.grob ()); +} +void +Pitched_trill_engraver::acknowledge_flag (Grob_info info) +{ + heads_.push_back (info.grob ()); +} +void Pitched_trill_engraver::acknowledge_note_head (Grob_info info) { heads_.push_back (info.grob ()); @@ -76,7 +90,7 @@ Pitched_trill_engraver::acknowledge_trill_spanner (Grob_info info) if (ev && ev->in_event_class ("trill-span-event") && to_dir (ev->get_property ("span-direction")) == START - && unsmob_pitch (ev->get_property ("pitch"))) + && unsmob (ev->get_property ("pitch"))) make_trill (ev); } @@ -84,29 +98,29 @@ void Pitched_trill_engraver::make_trill (Stream_event *ev) { SCM scm_pitch = ev->get_property ("pitch"); - Pitch *p = unsmob_pitch (scm_pitch); + Pitch *p = unsmob (scm_pitch); - SCM keysig = get_property ("localKeySignature"); + SCM keysig = get_property ("localAlterations"); SCM key = scm_cons (scm_from_int (p->get_octave ()), - scm_from_int (p->get_notename ())); + scm_from_int (p->get_notename ())); - int bn = measure_number (context()); + int bn = measure_number (context ()); SCM handle = scm_assoc (key, keysig); - if (handle != SCM_BOOL_F) + if (scm_is_true (handle)) { bool same_bar = (bn == robust_scm2int (scm_caddr (handle), 0)); bool same_alt - = (p->get_alteration () == robust_scm2rational (scm_cadr (handle), 0)); + = (p->get_alteration () == robust_scm2rational (scm_cadr (handle), 0)); if (!same_bar || (same_bar && !same_alt)) - handle = SCM_BOOL_F; + handle = SCM_BOOL_F; } - bool print_acc - = (handle == SCM_BOOL_F) || p->get_alteration () == Rational (0) - || (ev->get_property ("force-accidental") == SCM_BOOL_T); + bool print_acc = scm_is_false (handle) + || p->get_alteration () == Rational (0) + || to_boolean (ev->get_property ("force-accidental")); if (trill_head_) { @@ -120,8 +134,8 @@ Pitched_trill_engraver::make_trill (Stream_event *ev) int c0 = scm_is_number (c0scm) ? scm_to_int (c0scm) : 0; trill_head_->set_property ("staff-position", - scm_from_int (unsmob_pitch (scm_pitch)->steps () - + c0)); + scm_from_int (unsmob (scm_pitch)->steps () + + c0)); trill_group_ = make_item ("TrillPitchGroup", ev->self_scm ()); trill_group_->set_parent (trill_head_, Y_AXIS); @@ -135,7 +149,7 @@ Pitched_trill_engraver::make_trill (Stream_event *ev) // fixme: naming -> alterations trill_accidental_->set_property ("alteration", ly_rational2scm (p->get_alteration ())); Side_position_interface::add_support (trill_accidental_, trill_head_); - + trill_head_->set_object ("accidental-grob", trill_accidental_->self_scm ()); trill_accidental_->set_parent (trill_head_, Y_AXIS); Axis_group_interface::add_element (trill_group_, trill_accidental_); @@ -155,25 +169,24 @@ Pitched_trill_engraver::stop_translation_timestep () trill_accidental_ = 0; } - -#include "translator.icc" - ADD_ACKNOWLEDGER (Pitched_trill_engraver, note_head); ADD_ACKNOWLEDGER (Pitched_trill_engraver, dots); +ADD_ACKNOWLEDGER (Pitched_trill_engraver, stem); +ADD_ACKNOWLEDGER (Pitched_trill_engraver, flag); ADD_ACKNOWLEDGER (Pitched_trill_engraver, trill_spanner); ADD_TRANSLATOR (Pitched_trill_engraver, - /* doc */ - "Print the bracketed note head after a note head with trill.", + /* doc */ + "Print the bracketed note head after a note head with trill.", - /* create */ - "TrillPitchHead " - "TrillPitchAccidental " - "TrillPitchGroup ", + /* create */ + "TrillPitchHead " + "TrillPitchAccidental " + "TrillPitchGroup ", - /* read */ - "", + /* read */ + "", - /* write */ - "" - ); + /* write */ + "" + );