X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fottava-engraver.cc;h=cfb88a2c3a69083c7966b68f077fde7f3303ef96;hb=5b4b0d6e9a197e8f9eb085b7c2ad78b8be3e5cfc;hp=bb771d67610036ac37f5b073cc7c6c2ff25dd032;hpb=c659cb200486c2f908703696a1b2873e78c8160a;p=lilypond.git

diff --git a/lily/ottava-engraver.cc b/lily/ottava-engraver.cc
index bb771d6761..cfb88a2c3a 100644
--- a/lily/ottava-engraver.cc
+++ b/lily/ottava-engraver.cc
@@ -1,45 +1,50 @@
 /*
-  text-spanner-engraver.cc -- implement Ottava_spanner_engraver
+  ottava-engraver.cc -- implement Ottava_spanner_engraver
 
   source file of the GNU LilyPond music typesetter
 
-  (c) 2000--2004 Han-Wen Nienhuys
+  (c) 2000--2008 Han-Wen Nienhuys
 */
 
 #include "protected-scm.hh"
 #include "note-column.hh"
 #include "side-position-interface.hh"
 #include "engraver.hh"
+#include "spanner.hh"
+#include "text-interface.hh"
+#include "item.hh"
 
 class Ottava_spanner_engraver : public Engraver
 {
 public:
-  TRANSLATOR_DECLARATIONS (Ottava_spanner_engraver);  
+  TRANSLATOR_DECLARATIONS (Ottava_spanner_engraver);
 protected:
   virtual void finalize ();
-  virtual void acknowledge_grob (Grob_info);
-  virtual void process_music ();
-  virtual void stop_translation_timestep ();
+
+  DECLARE_ACKNOWLEDGER (note_column);
+
+  void process_music ();
+  void stop_translation_timestep ();
   virtual void derived_mark () const;
 private:
   Spanner *span_;
   Spanner *finished_;
-  
+
   SCM last_ottavation_;
-  
+
   void typeset_all ();
 };
 
 void
 Ottava_spanner_engraver::derived_mark () const
 {
-  scm_gc_mark (last_ottavation_ );
+  scm_gc_mark (last_ottavation_);
 }
 
 Ottava_spanner_engraver::Ottava_spanner_engraver ()
 {
   finished_ = 0;
-  span_ =0;
+  span_ = 0;
   last_ottavation_ = SCM_EOL;
 }
 
@@ -49,28 +54,26 @@ Ottava_spanner_engraver::process_music ()
   SCM ott = get_property ("ottavation");
   if (ott != last_ottavation_)
     {
-      finished_= span_;
+      finished_ = span_;
       span_ = 0;
-      if (scm_is_string (ott))
+      if (Text_interface::is_markup (ott))
 	{
-	  span_  = make_spanner ("OttavaBracket", SCM_EOL);
+	  span_ = make_spanner ("OttavaBracket", SCM_EOL);
 	  span_->set_property ("text", ott);
-	  
 
-	  SCM c0 (get_property ("middleCPosition"));
-	  SCM oc0 (get_property ("originalCentralCPosition"));
-	  if (scm_less_p (oc0, c0) == SCM_BOOL_T)
-	    span_->set_property ("direction", scm_int2num (DOWN));
+	  SCM offset (get_property ("middleCOffset"));
+	  if (robust_scm2double (offset, 0) > 0)
+	    span_->set_property ("direction", scm_from_int (DOWN));
 	}
     }
   last_ottavation_ = ott;
 }
 
 void
-Ottava_spanner_engraver::acknowledge_grob (Grob_info info)
+Ottava_spanner_engraver::acknowledge_note_column (Grob_info info)
 {
-  Item *it = dynamic_cast<Item*> (info.grob_);
-  if (span_ && it && Note_column::has_interface (info.grob_))
+  Item *it = info.item ();
+  if (span_ && it)
     {
       Side_position_interface::add_support (span_, it);
 
@@ -82,7 +85,7 @@ Ottava_spanner_engraver::acknowledge_grob (Grob_info info)
 
 void
 Ottava_spanner_engraver::typeset_all ()
-{  
+{
   if (finished_)
     {
       Direction d = LEFT;
@@ -90,12 +93,12 @@ Ottava_spanner_engraver::typeset_all ()
 	{
 	  if (!finished_->get_bound (RIGHT))
 	    {
-	      Grob* e = unsmob_grob (get_property ("currentMusicalColumn"));
+	      Grob *e = unsmob_grob (get_property ("currentMusicalColumn"));
 	      finished_->set_bound (d, e);
 	    }
 	}
       while (flip (&d) != LEFT);
-      
+
       finished_ = 0;
     }
 }
@@ -105,7 +108,7 @@ Ottava_spanner_engraver::stop_translation_timestep ()
 {
   if (span_ && !span_->get_bound (LEFT))
     {
-      Grob* e = unsmob_grob (get_property ("currentMusicalColumn"));
+      Grob *e = unsmob_grob (get_property ("currentMusicalColumn"));
       span_->set_bound (LEFT, e);
     }
 
@@ -122,10 +125,22 @@ Ottava_spanner_engraver::finalize ()
   last_ottavation_ = SCM_EOL;
 }
 
-ENTER_DESCRIPTION (Ottava_spanner_engraver,
-/* descr */       "Create a text spanner when the ottavation property changes..",
-/* creats*/       "OttavaBracket",
-/* accepts */     "",
-/* acks  */      "note-column-interface",
-/* reads */       "ottavation",
-/* write */       "");
+#include "translator.icc"
+
+ADD_ACKNOWLEDGER (Ottava_spanner_engraver, note_column);
+
+ADD_TRANSLATOR (Ottava_spanner_engraver,
+		/* doc */
+		"Create a text spanner when the ottavation property changes.",
+
+		/* create */
+		"OttavaBracket ",
+
+		/* read */
+		"ottavation "
+		"originalMiddleCPosition "
+		"currentMusicalColumn ",
+		
+		/* write */
+		""
+		);