X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fnote-column.cc;h=a53c06006943921f0f8b594e73f4025908003468;hb=c750e9b0ef41267a9b6be0300c880047f48b9353;hp=974f220b79de2803b1ab656379e7cfaf69ff2021;hpb=4ecdbd7d70ca7441be4dddd15ac01cc255bc2a35;p=lilypond.git diff --git a/lily/note-column.cc b/lily/note-column.cc index 974f220b79..a53c060069 100644 --- a/lily/note-column.cc +++ b/lily/note-column.cc @@ -3,7 +3,7 @@ source file of the GNU LilyPond music typesetter - (c) 1997--2005 Han-Wen Nienhuys + (c) 1997--2006 Han-Wen Nienhuys */ #include "note-column.hh" @@ -11,15 +11,18 @@ #include // ceil using namespace std; +#include "accidental-placement.hh" #include "axis-group-interface.hh" -#include "stem.hh" -#include "warn.hh" -#include "output-def.hh" -#include "staff-symbol-referencer.hh" -#include "rest.hh" +#include "directional-element-interface.hh" +#include "international.hh" +#include "item.hh" #include "note-head.hh" -#include "accidental-placement.hh" +#include "output-def.hh" #include "pointer-group-interface.hh" +#include "rest.hh" +#include "staff-symbol-referencer.hh" +#include "stem.hh" +#include "warn.hh" /* TODO: figure out if we can prune this class. This is just an @@ -32,15 +35,15 @@ Note_column::has_rests (Grob *me) return unsmob_grob (me->get_object ("rest")); } -int -Note_column::shift_compare (Grob *const &p1, Grob *const &p2) +bool +Note_column::shift_less (Grob *const &p1, Grob *const &p2) { SCM s1 = p1->get_property ("horizontal-shift"); SCM s2 = p2->get_property ("horizontal-shift"); int h1 = (scm_is_number (s1)) ? scm_to_int (s1) : 0; int h2 = (scm_is_number (s2)) ? scm_to_int (s2) : 0; - return h1 - h2; + return h1 < h2; } Item * @@ -58,7 +61,7 @@ Note_column::head_positions_interval (Grob *me) iv.set_empty (); extract_grob_set (me, "note-heads", heads); - for (int i = 0; i < heads.size (); i++) + for (vsize i = 0; i < heads.size (); i++) { Grob *se = heads[i]; @@ -73,7 +76,7 @@ Note_column::dir (Grob *me) { Grob *stem = unsmob_grob (me->get_object ("stem")); if (stem && Stem::has_interface (stem)) - return Stem::get_direction (stem); + return get_grob_direction (stem); else { extract_grob_set (me, "note-heads", heads); @@ -89,7 +92,6 @@ void Note_column::set_stem (Grob *me, Grob *stem) { me->set_object ("stem", stem->self_scm ()); - me->add_dependency (stem); Axis_group_interface::add_element (me, stem); } @@ -161,7 +163,7 @@ Note_column::accidentals (Grob *me) { extract_grob_set (me, "note-heads", heads); Grob *acc = 0; - for (int i = 0; i < heads.size (); i++) + for (vsize i = 0; i < heads.size (); i++) { Grob *h = heads[i]; acc = h ? unsmob_grob (h->get_object ("accidental-grob")) : 0; @@ -185,6 +187,16 @@ Note_column::arpeggio (Grob *me) return unsmob_grob (me->get_object ("arpeggio")); } -ADD_INTERFACE (Note_column, "note-column-interface", +ADD_INTERFACE (Note_column, "Stem and noteheads combined", - "arpeggio note-heads rest-collision rest horizontal-shift stem accidentals force-hshift"); + + /* properties */ + "accidentals " + "arpeggio " + "force-hshift " + "horizontal-shift " + "note-heads " + "rest " + "rest-collision " + "stem " + );