X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fmusic-iterator.cc;h=a7a06ff0d82a1ba88ac1f1a67a4346f2fc00ceb0;hb=97a0169312a260933246ab224e4f8b0969871dd5;hp=ed778323b9ed1bad88beb219b91ad76120c2465a;hpb=90d3233da87b372e02690978f89b2add3863fba6;p=lilypond.git

diff --git a/lily/music-iterator.cc b/lily/music-iterator.cc
index ed778323b9..a7a06ff0d8 100644
--- a/lily/music-iterator.cc
+++ b/lily/music-iterator.cc
@@ -30,7 +30,6 @@ using namespace std;
 #include "music-wrapper-iterator.hh"
 #include "simple-music-iterator.hh"
 
-ADD_SMOB_INIT (Music_iterator);
 
 Music_iterator::Music_iterator ()
 {
@@ -86,7 +85,7 @@ Music_iterator::get_static_get_iterator (Music *m)
   if (ly_is_procedure (ctor))
     {
       iter = scm_call_0 (ctor);
-      p = Music_iterator::unsmob (iter);
+      p = unsmob<Music_iterator> (iter);
     }
   else
     {
@@ -133,9 +132,12 @@ Music_iterator::init_context (Music *m, Context *report)
 void
 Music_iterator::substitute_outlet (Context *f, Context *t)
 {
-  if (get_outlet () == f)
-    set_context (t);
-  derived_substitute (f, t);
+  if (f != t)
+    {
+      if (get_outlet () == f)
+        set_context (t);
+      derived_substitute (f, t);
+    }
 }
 
 void
@@ -147,7 +149,7 @@ SCM
 Music_iterator::get_iterator (Music *m) const
 {
   SCM ip = get_static_get_iterator (m);
-  Music_iterator *p = Music_iterator::unsmob (ip);
+  Music_iterator *p = unsmob<Music_iterator> (ip);
 
   p->init_context (m, get_outlet ());
 
@@ -188,10 +190,10 @@ Music_iterator::get_music () const
 
 /****************************************************************/
 
-const char Music_iterator::type_p_name_[] = "ly:iterator?";
+const char * const Music_iterator::type_p_name_ = "ly:iterator?";
 
 SCM
-Music_iterator::mark_smob ()
+Music_iterator::mark_smob () const
 {
   derived_mark ();
   /*
@@ -210,7 +212,7 @@ Music_iterator::mark_smob ()
 }
 
 int
-Music_iterator::print_smob (SCM port, scm_print_state *)
+Music_iterator::print_smob (SCM port, scm_print_state *) const
 {
   char s[1000];