X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Flyric-engraver.cc;h=1c206a81fd9fc9b16b24652f2aa03a98ed1d5d46;hb=5b4b0d6e9a197e8f9eb085b7c2ad78b8be3e5cfc;hp=06ffce0d50ad4cc354015a88e4e623beb2d1da53;hpb=0b14e8b2e122df7adf340cc85e92ffd9b184098a;p=lilypond.git diff --git a/lily/lyric-engraver.cc b/lily/lyric-engraver.cc index 06ffce0d50..1c206a81fd 100644 --- a/lily/lyric-engraver.cc +++ b/lily/lyric-engraver.cc @@ -3,7 +3,7 @@ source file of the GNU LilyPond music typesetter - (c) 1997--2006 Han-Wen Nienhuys + (c) 1997--2008 Han-Wen Nienhuys Jan Nieuwenhuizen */ @@ -59,7 +59,7 @@ Lyric_engraver::process_music () { SCM text = event_->get_property ("text"); - if (ly_is_equal (text, scm_makfrom0str (" "))) + if (ly_is_equal (text, scm_from_locale_string (" "))) { if (last_text_) last_text_->set_property ("self-alignment-X", scm_from_int (LEFT)); @@ -83,6 +83,10 @@ get_voice_to_lyrics (Context *lyrics) if (scm_is_string (voice_name)) nm = ly_scm2string (voice_name); + else if (nm == "") + { + return 0; + } else { ssize idx = nm.rfind ('-'); @@ -115,12 +119,20 @@ get_voice_to_lyrics (Context *lyrics) Grob * get_current_note_head (Context *voice) { + Moment now = voice->now_mom (); for (SCM s = voice->get_property ("busyGrobs"); scm_is_pair (s); s = scm_cdr (s)) { - Item *g = dynamic_cast (unsmob_grob (scm_cdar (s))); - - if (g && !g->get_column () + Grob *g = unsmob_grob (scm_cdar (s));; + Moment *end_mom = unsmob_moment (scm_caar (s)); + if (!end_mom || !g) + { + programming_error ("busyGrobs invalid"); + continue; + } + + if (end_mom->main_part_ > now.main_part_ + && dynamic_cast (g) && Note_head::has_interface (g)) return g; } @@ -134,7 +146,7 @@ Lyric_engraver::stop_translation_timestep () if (text_) { Context *voice = get_voice_to_lyrics (context ()); - + if (voice) { Grob *head = get_current_note_head (voice); @@ -143,7 +155,7 @@ Lyric_engraver::stop_translation_timestep () { text_->set_parent (head, X_AXIS); if (melisma_busy (voice)) - text_->set_property ("self-alignment-X", scm_from_int (LEFT)); + text_->set_property ("self-alignment-X", get_property("lyricMelismaAlignment")); } else { @@ -159,7 +171,14 @@ Lyric_engraver::stop_translation_timestep () } ADD_TRANSLATOR (Lyric_engraver, - /* doc */ "", - /* create */ "LyricText", - /* read */ "", - /* write */ ""); + /* doc */ + "Engrave text for lyrics.", + + /* create */ + "LyricText ", + /* read */ + "lyricMelismaAlignment ", + + /* write */ + "" + );