X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fkey-engraver.cc;h=fd60570821e05dc37f875d0255942d82b63f7284;hb=31ae5880931a923a88c3a12a66d113436dfb97af;hp=17735e0d2b7d2f9832940fbf50b46d5179ffc11f;hpb=92ae3c64da38e2136f9d146429ca8c1b04c1ab91;p=lilypond.git diff --git a/lily/key-engraver.cc b/lily/key-engraver.cc index 17735e0d2b..fd60570821 100644 --- a/lily/key-engraver.cc +++ b/lily/key-engraver.cc @@ -1,35 +1,40 @@ /* - key-engraver.cc -- implement Key_engraver + This file is part of LilyPond, the GNU music typesetter. - source file of the GNU LilyPond music typesetter + Copyright (C) 1997--2012 Han-Wen Nienhuys - (c) 1997--2005 Han-Wen Nienhuys + LilyPond is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + LilyPond is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with LilyPond. If not, see . */ -#include "item.hh" #include "bar-line.hh" -#include "staff-symbol-referencer.hh" +#include "clef.hh" #include "context.hh" #include "engraver.hh" -#include "protected-scm.hh" -#include "clef.hh" +#include "item.hh" #include "pitch.hh" +#include "protected-scm.hh" +#include "staff-symbol-referencer.hh" +#include "stream-event.hh" #include "translator.icc" -/* - TODO: The representation of key sigs is all fucked. -*/ - -/** - Make the key signature. -*/ class Key_engraver : public Engraver { void create_key (bool); - void read_event (Music const *r); + void read_event (Stream_event const *r); - Music *key_event_; + Stream_event *key_event_; Item *item_; Item *cancellation_; public: @@ -38,10 +43,10 @@ public: protected: virtual void initialize (); virtual void finalize (); - virtual bool try_music (Music *event); void stop_translation_timestep (); void process_music (); + DECLARE_TRANSLATOR_LISTENER (key_change); DECLARE_ACKNOWLEDGER (clef); DECLARE_ACKNOWLEDGER (bar_line); }; @@ -64,39 +69,48 @@ Key_engraver::create_key (bool is_default) if (!item_) { item_ = make_item ("KeySignature", - key_event_ ? key_event_->self_scm () : SCM_EOL); + key_event_ ? key_event_->self_scm () : SCM_EOL); + /* Use middleCClefPosition rather than middleCPosition, because cue + * notes with a different clef will modify middleCPosition. The + * Key signature, however, should still be printed at the original + * position. */ item_->set_property ("c0-position", - get_property ("middleCPosition")); + get_property ("middleCClefPosition")); SCM last = get_property ("lastKeySignature"); SCM key = get_property ("keySignature"); if ((to_boolean (get_property ("printKeyCancellation")) - || key == SCM_EOL) - && !scm_is_eq (last, key)) - { - cancellation_ = make_item ("KeyCancellation", - key_event_ - ? key_event_->self_scm () : SCM_EOL); - - SCM restore = SCM_EOL; - SCM *tail = &restore; - for (SCM s = last; scm_is_pair (s); s = scm_cdr (s)) - { - if (scm_assoc (scm_caar (s), key) == SCM_BOOL_F) - { - *tail = scm_acons (scm_caar (s), - scm_from_int (0), *tail); - tail = SCM_CDRLOC(*tail); - } - } - - cancellation_->set_property ("alteration-alist", restore); - cancellation_->set_property ("c0-position", - get_property ("middleCPosition")); - } - item_->set_property ("alteration-alist", key); + || key == SCM_EOL) + && !scm_is_eq (last, key)) + { + SCM restore = SCM_EOL; + for (SCM s = last; scm_is_pair (s); s = scm_cdr (s)) + { + SCM new_alter_pair = scm_assoc (scm_caar (s), key); + Rational old_alter = robust_scm2rational (scm_cdar (s), 0); + if (new_alter_pair == SCM_BOOL_F + || ((ly_scm2rational (scm_cdr (new_alter_pair)) - old_alter) * old_alter + < Rational (0))) + { + restore = scm_cons (scm_car (s), restore); + } + } + + if (scm_is_pair (restore)) + { + cancellation_ = make_item ("KeyCancellation", + key_event_ + ? key_event_->self_scm () : SCM_EOL); + + cancellation_->set_property ("alteration-alist", restore); + cancellation_->set_property ("c0-position", + get_property ("middleCPosition")); + } + } + + item_->set_property ("alteration-alist", scm_reverse (key)); } if (!is_default) @@ -106,41 +120,28 @@ Key_engraver::create_key (bool is_default) } } -bool -Key_engraver::try_music (Music *event) +IMPLEMENT_TRANSLATOR_LISTENER (Key_engraver, key_change); +void +Key_engraver::listen_key_change (Stream_event *ev) { - if (event->is_mus_type ("key-change-event")) - { - /* do this only once, just to be on the safe side. */ - if (!key_event_) - { - key_event_ = event; - read_event (key_event_); - } - return true; - } - return false; + /* do this only once, just to be on the safe side. */ + if (ASSIGN_EVENT_ONCE (key_event_, ev)) + read_event (key_event_); } void -Key_engraver::acknowledge_clef (Grob_info info) +Key_engraver::acknowledge_clef (Grob_info /* info */) { - (void)info; SCM c = get_property ("createKeyOnClefChange"); if (to_boolean (c)) - { - create_key (false); - } + create_key (false); } void -Key_engraver::acknowledge_bar_line (Grob_info info) +Key_engraver::acknowledge_bar_line (Grob_info /* info */) { - (void)info; if (scm_is_pair (get_property ("keySignature"))) - { - create_key (true); - } + create_key (true); } void @@ -161,31 +162,45 @@ Key_engraver::stop_translation_timestep () } void -Key_engraver::read_event (Music const *r) +Key_engraver::read_event (Stream_event const *r) { SCM p = r->get_property ("pitch-alist"); if (!scm_is_pair (p)) return; - SCM n = scm_list_copy (p); SCM accs = SCM_EOL; - for (SCM s = get_property ("keyAlterationOrder"); - scm_is_pair (s); s = scm_cdr (s)) + + SCM alist = scm_list_copy (p); + SCM order = get_property ("keyAlterationOrder"); + for (SCM s = order; + scm_is_pair (s) && scm_is_pair (alist); s = scm_cdr (s)) { - if (scm_is_pair (scm_member (scm_car (s), n))) - { - accs = scm_cons (scm_car (s), accs); - n = scm_delete_x (scm_car (s), n); - } + SCM head = scm_member (scm_car (s), alist); + + if (scm_is_pair (head)) + { + accs = scm_cons (scm_car (head), accs); + alist = scm_delete_x (scm_car (head), alist); + } } - for (SCM s = n; scm_is_pair (s); s = scm_cdr (s)) - if (scm_to_int (scm_cdar (s))) - accs = scm_cons (scm_car (s), accs); + if (scm_is_pair (alist)) + { + bool warn = false; + for (SCM s = alist; scm_is_pair (s); s = scm_cdr (s)) + if (ly_scm2rational (scm_cdar (s))) + { + warn = true; + accs = scm_cons (scm_car (s), accs); + } + + if (warn) + r->origin ()->warning ("Incomplete keyAlterationOrder for key signature"); + } - context ()->set_property ("keySignature", accs); + context ()->set_property ("keySignature", scm_reverse_x (accs, SCM_EOL)); context ()->set_property ("tonic", - r->get_property ("tonic")); + r->get_property ("tonic")); } void @@ -198,15 +213,29 @@ Key_engraver::initialize () context ()->set_property ("tonic", p.smobbed_copy ()); } - -ADD_ACKNOWLEDGER (Key_engraver,clef); -ADD_ACKNOWLEDGER (Key_engraver,bar_line); +ADD_ACKNOWLEDGER (Key_engraver, clef); +ADD_ACKNOWLEDGER (Key_engraver, bar_line); ADD_TRANSLATOR (Key_engraver, - /* descr */ "", - /* creats*/ "KeySignature", - /* accepts */ "key-change-event", - /* reads */ "keySignature printKeyCancellation lastKeySignature " - "explicitKeySignatureVisibility createKeyOnClefChange " - "keyAlterationOrder keySignature", - /* write */ "lastKeySignature tonic keySignature"); + /* doc */ + "Engrave a key signature.", + + /* create */ + "KeyCancellation " + "KeySignature ", + + /* read */ + "createKeyOnClefChange " + "explicitKeySignatureVisibility " + "extraNatural " + "keyAlterationOrder " + "keySignature " + "lastKeySignature " + "printKeyCancellation " + "middleCClefPosition ", + + /* write */ + "keySignature " + "lastKeySignature " + "tonic " + );