X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Finput.cc;h=ea8bbe7813609d7bef0b1659090f182063ec5ae1;hb=47db9a3883d726ca53e2133a3b2298f78dd6a32e;hp=6cc8a182a540bdc29ecfe96d763af0dcf70f42b3;hpb=f93e4199873c91ae32f0e84a610d14853dc379df;p=lilypond.git

diff --git a/lily/input.cc b/lily/input.cc
index 6cc8a182a5..ea8bbe7813 100644
--- a/lily/input.cc
+++ b/lily/input.cc
@@ -1,7 +1,7 @@
 /*
   This file is part of LilyPond, the GNU music typesetter.
 
-  Copyright (C) 1997--2011 Han-Wen Nienhuys <hanwen@xs4all.nl>
+  Copyright (C) 1997--2015 Han-Wen Nienhuys <hanwen@xs4all.nl>
 
   LilyPond is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -78,48 +78,56 @@ Input::set_location (Input const &i_start, Input const &i_end)
 
   [file:line:column:][warning:]message
 */
-void
-Input::message (string s) const
+string
+Input::message_string (const string &msg) const
 {
   if (source_file_)
-    s = location_string () + ": " + s + "\n"
-        + source_file_->quote_input (start_) + "\n";
-  ::message (s);
+    return msg + "\n" + source_file_->quote_input (start_);
+  else
+    return msg;
 }
 
+string
+Input::message_location () const
+{
+  return (source_file_) ? location_string () : "";
+}
 void
-Input::programming_error (string s) const
+Input::error (const string &s) const
 {
-  if (get_program_option ("warning-as-error"))
-    ::error (s);
-  else
-    {
-      message (_f ("programming error: %s", s.c_str ()));
-      message (_ ("continuing, cross fingers") + "\n");
-    }
+  ::non_fatal_error (message_string (s), message_location ());
+  // UGH, fix naming or usage (use non_fatal_error in most places, instead)
+  // exit (1);
 }
 
 void
-Input::warning (string s) const
+Input::programming_error (const string &s) const
 {
-  if (get_program_option ("warning-as-error"))
-    ::error (s);
-  else
-    message (_f ("warning: %s", s));
+  ::programming_error (message_string (s), message_location ());
 }
 
 void
-Input::error (string s) const
+Input::non_fatal_error (const string &s) const
 {
-  message (_f ("error: %s", s));
-  // UGH, fix naming or usage
-  // exit (1);
+  ::non_fatal_error (message_string (s), message_location ());
+}
+
+void
+Input::warning (const string &s) const
+{
+  ::warning (message_string (s), message_location ());
+}
+
+void
+Input::message (const string &s) const
+{
+  ::message (message_string (s), true, message_location ());
 }
 
 void
-Input::non_fatal_error (string s) const
+Input::debug_output (const string &s) const
 {
-  message (_f ("error: %s", s));
+  ::debug_output (message_string (s), true, message_location ());
 }
 
 string
@@ -134,7 +142,7 @@ string
 Input::line_number_string () const
 {
   if (source_file_)
-    return to_string (source_file_->get_line (start_));
+    return ::to_string (source_file_->get_line (start_));
   return "?";
 }