X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fgrob-pq-engraver.cc;h=f83866ac4c18b33ed0665640e8fba27ea372b6a9;hb=a501f5946426488804ca2b03ab986f9c2b94ab99;hp=c681814026be960f235b4c2dc1e9ec5590b0469d;hpb=7e72a1e50e94a7f9738d62599de79fe7745f600c;p=lilypond.git

diff --git a/lily/grob-pq-engraver.cc b/lily/grob-pq-engraver.cc
index c681814026..f83866ac4c 100644
--- a/lily/grob-pq-engraver.cc
+++ b/lily/grob-pq-engraver.cc
@@ -6,40 +6,15 @@
   (c) 2001--2004  Han-Wen Nienhuys <hanwen@cs.uu.nl>
 */
 
-#include "translator-group.hh"
+#include "context.hh"
 #include "engraver.hh"
 #include "grob.hh"
 #include "warn.hh"
 
-/*
-  TODO: should junk this engraver.
- */
-
-struct Grob_mom
-{
-  Grob * grob_ ;
-  Moment end_;
-  Grob_mom () {}
-  Grob_mom (Grob*gr, Moment e)
-  {
-    grob_ = gr;
-    end_ = e;
-  }
-};
-
-int compare  (Grob_mom const &a, Grob_mom const &b)
-{
-  return Moment::compare (a.end_, b.end_);
-}
-
-/****************/
-
 class Grob_pq_engraver: public Engraver
 {
 public:
-  TRANSLATOR_DECLARATIONS(Grob_pq_engraver);
-
-  Array<Grob_mom> current_grobs_;
+  TRANSLATOR_DECLARATIONS (Grob_pq_engraver);
 protected:
   virtual void initialize ();
   virtual void acknowledge_grob (Grob_info);
@@ -48,17 +23,27 @@ protected:
 };
 
 
-Grob_pq_engraver::Grob_pq_engraver()
+Grob_pq_engraver::Grob_pq_engraver ()
 {
 }
 
-
 void
 Grob_pq_engraver::initialize ()
 {
-  daddy_trans_->set_property ("busyGrobs", SCM_EOL); 
+  get_parent_context ()->set_property ("busyGrobs", SCM_EOL); 
 }
 
+LY_DEFINE (ly_grob_pq_less_p, "ly:grob-pq-less?",
+	  2, 0 ,0, (SCM a, SCM b), 
+	  "Compare 2 grob priority queue entries. Internal")
+{
+  if (Moment::compare (*unsmob_moment (ly_car (a)),
+		       *unsmob_moment (ly_car (b))) < 0)
+    return SCM_BOOL_T;
+  else
+    return SCM_BOOL_F;
+}
+	  
 void
 Grob_pq_engraver::acknowledge_grob (Grob_info gi)
 {
@@ -79,72 +64,55 @@ Grob_pq_engraver::acknowledge_grob (Grob_info gi)
 	  l.main_part_ = 0;
 	}
 
-      current_grobs_.push (Grob_mom (gi.grob_, n + l));
+      Moment end = n + l;
+      SCM lst = scm_acons (end.smobbed_copy (),
+			 gi.grob_->self_scm (),
+			 SCM_EOL);
+
+      SCM busy= get_property ("busyGrobs");
+      busy = scm_merge_x (lst, busy, ly_grob_pq_less_p_proc);
+      get_parent_context ()->set_property ("busyGrobs", busy);
     }
 }
 
-LY_DEFINE(ly_grob_pq_less_p, 
-	  "ly:grob-pq-less?", 2 , 0 ,0, (SCM a, SCM b), 
-	  "Compare 2 Grob PQ entries. Internal")
-{
-  if ( Moment::compare (*unsmob_moment (gh_car (a)),
-				      *unsmob_moment (gh_car (b))) < 0)
-    return SCM_BOOL_T;
-  else
-    return SCM_BOOL_F;
-}
-	  
 
 void
 Grob_pq_engraver::stop_translation_timestep ()
 {
-  Moment now = now_mom();
-
-  current_grobs_.sort (&compare);
-  SCM current_list = SCM_EOL;
-  for (int i = current_grobs_.size(); i--;)
-    current_list = scm_cons (scm_cons (current_grobs_[i].end_.smobbed_copy(), 
-				       current_grobs_[i].grob_->self_scm ()), current_list);
-
-  /*
-    We generate some garbage here.
-   */
-  SCM busy = get_property ("busyGrobs");
-  while (gh_pair_p (busy) && *unsmob_moment (gh_caar (busy)) == now)
+  Moment now = now_mom ();
+  SCM start_busy = get_property ("busyGrobs");
+  SCM busy = start_busy;
+  while (is_pair (busy) && *unsmob_moment (ly_caar (busy)) == now)
     {
-      busy = gh_cdr (busy);
+      busy = ly_cdr (busy);
     }
-  
-  busy = scm_merge_x (current_list, busy, ly_grob_pq_less_p_proc);
-  current_grobs_.clear ();
-  daddy_trans_->set_property ("busyGrobs", busy);
+
+  if (start_busy != busy)
+    get_parent_context ()->set_property ("busyGrobs", busy);
 }
 
 void
 Grob_pq_engraver::start_translation_timestep ()
 {
-  Moment now = now_mom();
+  Moment now = now_mom ();
 
   SCM start_busy = get_property ("busyGrobs");
   SCM busy = start_busy;
-  while (gh_pair_p (busy) && *unsmob_moment (gh_caar (busy)) < now)
+  while (is_pair (busy) && *unsmob_moment (ly_caar (busy)) < now)
     {
       /*
-	Todo: do something sensible. The grob-pq-engraver is not water
-	tight, and stuff like tupletSpannerDuration confuses it.
+	The grob-pq-engraver is not water tight, and stuff like
+	tupletSpannerDuration confuses it.
        */
-      programming_error (_f("Skipped something?\nGrob %s ended before I expected it to end.", unsmob_grob (gh_cdar (busy))->name().to_str0()));
-      
-      busy = gh_cdr (busy);
+      busy = ly_cdr (busy);
     }
 
   if (start_busy != busy)
-    daddy_trans_->set_property ("busyGrobs", busy);
-
+    get_parent_context ()->set_property ("busyGrobs", busy);
 }
 
 
-ENTER_DESCRIPTION(Grob_pq_engraver,
+ENTER_DESCRIPTION (Grob_pq_engraver,
 
 /* descr */       "Administrate when certain grobs (eg. note heads) stop playing; this \
 engraver is a sort-of a failure, since it doesn't handle all sorts of \