X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fgrob-closure.cc;h=4c63fe3c0c55436c4a608e0747582ff026c6ffd7;hb=762d6f176d7b2eda90378f351b132727f896740e;hp=a3075e2cd1e4eb2ad733ab71f6884132728519e5;hpb=a5dd8f857c7857aaa4acfbddf0c2c46088e69259;p=lilypond.git diff --git a/lily/grob-closure.cc b/lily/grob-closure.cc index a3075e2cd1..4c63fe3c0c 100644 --- a/lily/grob-closure.cc +++ b/lily/grob-closure.cc @@ -1,24 +1,23 @@ #include "grob.hh" #include "simple-closure.hh" +#include "unpure-pure-container.hh" SCM axis_offset_symbol (Axis a) { return a == X_AXIS - ? ly_symbol2scm ("X-offset") - : ly_symbol2scm ("Y-offset"); + ? ly_symbol2scm ("X-offset") + : ly_symbol2scm ("Y-offset"); } SCM axis_parent_positioning (Axis a) { return (a == X_AXIS) - ? Grob::x_parent_positioning_proc - : Grob::y_parent_positioning_proc; + ? Grob::x_parent_positioning_proc + : Grob::y_parent_positioning_proc; } - - /* Replace @@ -27,7 +26,6 @@ axis_parent_positioning (Axis a) by (+ (PROC GROB) (orig-proc GROB)) - */ void add_offset_callback (Grob *g, SCM proc, Axis a) @@ -37,24 +35,23 @@ add_offset_callback (Grob *g, SCM proc, Axis a) && !ly_is_procedure (data) && !is_simple_closure (data)) { - g->internal_set_property (axis_offset_symbol (a), - proc); - return ; + g->set_property (axis_offset_symbol (a), proc); + return; } - if (ly_is_procedure (data)) - data = ly_make_simple_closure (scm_list_1 (data)); + if (ly_is_procedure (data) || is_unpure_pure_container (data)) + data = ly_make_simple_closure (scm_list_1 (data)); else if (is_simple_closure (data)) data = simple_closure_expression (data); SCM plus = ly_lily_module_constant ("+"); - SCM expr = scm_list_3 (plus, - ly_make_simple_closure (scm_list_1 (proc)), - data); - g->internal_set_property (axis_offset_symbol (a), - ly_make_simple_closure (expr)); -} + if (ly_is_procedure (proc)) + proc = ly_make_simple_closure (scm_list_1 (proc)); + + SCM expr = scm_list_3 (plus, proc, data); + g->set_property (axis_offset_symbol (a), ly_make_simple_closure (expr)); +} /* replace @@ -63,25 +60,35 @@ add_offset_callback (Grob *g, SCM proc, Axis a) by - (PROC GROB (orig-proc GROB)) - + (PROC GROB (orig-proc GROB)) */ void -chain_offset_callback (Grob *g, SCM proc, Axis a) +chain_callback (Grob *g, SCM proc, SCM sym) { - SCM data = g->get_property_data (axis_offset_symbol (a)); + SCM data = g->get_property_data (sym); - if (ly_is_procedure (data)) - data = ly_make_simple_closure (scm_list_1 (data)); + if (ly_is_procedure (data) || is_unpure_pure_container (data)) + data = ly_make_simple_closure (scm_list_1 (data)); else if (is_simple_closure (data)) data = simple_closure_expression (data); - else if (!scm_is_number (data)) - data = scm_from_int (0); - + else + /* + Data may be nonnumber. In that case, it is assumed to be + undefined. + */ + + data = SCM_UNDEFINED; + SCM expr = scm_list_2 (proc, data); - g->internal_set_property (axis_offset_symbol (a), - - // twice: one as a wrapper for grob property routines, - // once for the actual delayed binding. - ly_make_simple_closure (ly_make_simple_closure (expr))); + g->set_property (sym, + + // twice: one as a wrapper for grob property routines, + // once for the actual delayed binding. + ly_make_simple_closure (ly_make_simple_closure (expr))); +} + +void +chain_offset_callback (Grob *g, SCM proc, Axis a) +{ + chain_callback (g, proc, axis_offset_symbol (a)); }