X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fgourlay-breaking.cc;h=32839d2433e1233455f0f81754eea5068f840c15;hb=94a1966c72301b8bd1d8bb3b8628c3f089d007cf;hp=2a4f0f14ac8489d24d60a8bb950fc75262b61005;hpb=fe1eb832e9e1e92e2bf98c33011465658192f033;p=lilypond.git diff --git a/lily/gourlay-breaking.cc b/lily/gourlay-breaking.cc index 2a4f0f14ac..32839d2433 100644 --- a/lily/gourlay-breaking.cc +++ b/lily/gourlay-breaking.cc @@ -66,7 +66,6 @@ print_break_nodes (Array const & arr) This algorithms is adapted from the OSU Tech report on breaking lines. this function is longish, but not very complicated. - */ Array Gourlay_breaking::do_solve () const @@ -80,9 +79,11 @@ Gourlay_breaking::do_solve () const Break_node first_node ; optimal_paths.push (first_node); + bool ragged_right = to_boolean (pscore_->paper_->get_scmvar ("raggedright")); + bool ragged_last = to_boolean (pscore_->paper_->get_scmvar ("raggedlast")); + Real worst_force = 0.0; - - for (int break_idx=1; break_idx< breaks.size (); break_idx++) + for (int break_idx = 1; break_idx< breaks.size (); break_idx++) { /* start with a short line, add measures. At some point @@ -94,13 +95,11 @@ Gourlay_breaking::do_solve () const Real minimal_demerits = infinity_f; - bool ragged = to_boolean (pscore_->paper_->get_scmvar ("raggedright")); - for (int start_idx = break_idx; start_idx--;) { Link_array line = all.slice (breaks[start_idx], breaks[break_idx]+1); - line[0] = dynamic_cast (line[0]) ->find_prebroken_piece (RIGHT); + line[0] = dynamic_cast (line[0])->find_prebroken_piece (RIGHT); line.top () = dynamic_cast (line.top ())->find_prebroken_piece (LEFT); Column_x_positions cp; @@ -109,9 +108,17 @@ Gourlay_breaking::do_solve () const Interval line_dims = pscore_->paper_->line_dimensions_int (optimal_paths[start_idx].line_); Simple_spacer * sp = generate_spacing_problem (line, line_dims); + bool last_line = break_idx == breaks.size ()-1; + bool ragged = ragged_right + || (last_line && ragged_last); + sp->solve (&cp, ragged); + delete sp; + if (ragged && last_line) + cp.force_ = 0.0; + if (fabs (cp.force_) > worst_force) worst_force = fabs (cp.force_); @@ -167,7 +174,7 @@ Gourlay_breaking::do_solve () const /* do the last one */ if (breaks.size () % HAPPY_DOTS_I) - progress_indication (String ("[") + to_string (breaks.size()) + "]"); + progress_indication (String ("[") + to_string (breaks.size ()) + "]"); progress_indication ("\n"); @@ -197,7 +204,7 @@ Gourlay_breaking::do_solve () const Column_x_positions cp (optimal_paths[final_breaks[i]].line_config_); lines.push (cp); - if(!cp.satisfies_constraints_) + if (!cp.satisfies_constraints_) warning ("Could not find line breaking that satisfies constraints."); } return lines; @@ -225,10 +232,10 @@ Gourlay_breaking::combine_demerits (Column_x_positions const &prev, Grob * pc = this_one.cols_.top (); if (pc->original_) { - SCM pen = pc->get_grob_property ("penalty"); - if (gh_number_p (pen) && fabs (gh_scm2double (pen)) < 10000) + SCM pen = pc->get_property ("penalty"); + if (ly_number_p (pen) && fabs (ly_scm2double (pen)) < 10000) { - break_penalties += gh_scm2double (pen); + break_penalties += ly_scm2double (pen); } }