X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fengraver.cc;h=c749be110a169b2319d68059070dbb7f5f2bf1de;hb=6a6f4b18d8bff8c4c8e40332fb7a40c3867b8db4;hp=ef13351c2ef4c0f19d80796d6ffc60310e27c064;hpb=5d576b1299d374ae478cb38075cc05d5cb691046;p=lilypond.git

diff --git a/lily/engraver.cc b/lily/engraver.cc
index ef13351c2e..c749be110a 100644
--- a/lily/engraver.cc
+++ b/lily/engraver.cc
@@ -3,15 +3,13 @@
 
   Sourcefile of GNU LilyPond music type setter
 
-  (c) 1997--2006 Han-Wen Nienhuys <hanwen@xs4all.nl>
+  (c) 1997--2007 Han-Wen Nienhuys <hanwen@xs4all.nl>
 */
 
 #include "engraver.hh"
 
 #include "context.hh"
 #include "international.hh"
-#include "item.hh"
-#include "lilypond-key.hh"
 #include "music.hh"
 #include "paper-column.hh"
 #include "score-engraver.hh"
@@ -92,38 +90,41 @@ Engraver::Engraver ()
 static SCM creation_callback = SCM_EOL;
 LY_DEFINE (ly_set_grob_creation_callback, "ly:set-grob-creation-callback",
 	   1, 0, 0, (SCM cb),
-	   "Specify a procedure that will be called every time a new grob "
-	   "is created. The callback will receive as arguments the grob "
-	   "that was created, the name of the C++ source file that caused "
-	   "the grob to be created and the corresponding line number in the "
-	   "C++ source file.")
+	   "Specify a procedure that will be called every time a new grob"
+	   " is created.  The callback will receive as arguments the grob"
+	   " that was created, the name of the C++ source file that caused"
+	   " the grob to be created, and the corresponding line number in"
+	   " the C++ source file.")
 {
-  if (!ly_is_procedure (cb))
-    warning (_ ("not setting creation callback: not a procedure"));
-  else
-    creation_callback = cb;
+  LY_ASSERT_TYPE (ly_is_procedure, cb, 1);
 
-  return SCM_EOL;
+  creation_callback = cb;
+
+  return SCM_UNSPECIFIED;
 }
 #endif
 
 Grob *
 Engraver::internal_make_grob (SCM symbol, SCM cause, char const *name, char const *file, int line, char const *fun)
 {
+  (void) file;
+  (void) fun;
+  (void) line;
+  (void) name;
+  
   SCM props = updated_grob_properties (context (), symbol);
 
-  Object_key const *key = context ()->get_grob_key (name);
   Grob *grob = 0;
 
   SCM handle = scm_sloppy_assq (ly_symbol2scm ("meta"), props);
   SCM klass = scm_cdr (scm_sloppy_assq (ly_symbol2scm ("class"), scm_cdr (handle)));
 
   if (klass == ly_symbol2scm ("Item"))
-    grob = new Item (props, key);
+    grob = new Item (props);
   else if (klass == ly_symbol2scm ("Spanner"))
-    grob = new Spanner (props, key);
+    grob = new Spanner (props);
   else if (klass == ly_symbol2scm ("Paper_column"))
-    grob = new Paper_column (props, key);
+    grob = new Paper_column (props);
 
   assert (grob);
   announce_grob (grob, cause);
@@ -131,8 +132,8 @@ Engraver::internal_make_grob (SCM symbol, SCM cause, char const *name, char cons
 #ifndef NDEBUG
   if (ly_is_procedure (creation_callback))
     scm_apply_0 (creation_callback,
-		 scm_list_n (grob->self_scm (), scm_makfrom0str (file),
-			     scm_from_int (line), scm_makfrom0str (fun), SCM_UNDEFINED));
+		 scm_list_n (grob->self_scm (), scm_from_locale_string (file),
+			     scm_from_int (line), scm_from_locale_string (fun), SCM_UNDEFINED));
 #endif
 
   return grob;
@@ -166,9 +167,16 @@ Engraver::internal_make_spanner (SCM x, SCM cause, char const *name, char const
 #include "translator.icc"
 
 ADD_TRANSLATOR (Engraver,
-		"Base class for engravers. Does nothing, so it is not used.",
-		"",
+		/* doc */
+		"Base class for engravers.  Does nothing, so it is not used.",
+
+		/* create */
 		"",
+
+		/* read */
 		"",
-		"");
+
+		/* write */
+		""
+		);