X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fdot-column-engraver.cc;h=10fd4a54484beacbe78928ac65b3720f50a00fe6;hb=a6ee9dcd388111e842064a8d46ab06c4897a00d2;hp=fa740047680db4f2b1a96660a2da9a67b1395c7c;hpb=df4a7c4a55148e065d878dcc2f7e09ac27ea9c32;p=lilypond.git

diff --git a/lily/dot-column-engraver.cc b/lily/dot-column-engraver.cc
index fa74004768..10fd4a5448 100644
--- a/lily/dot-column-engraver.cc
+++ b/lily/dot-column-engraver.cc
@@ -3,7 +3,7 @@
   
   source file of the GNU LilyPond music typesetter
   
-  (c) 1998--2000 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+  (c) 1998--2002 Han-Wen Nienhuys <hanwen@cs.uu.nl>
   
  */
 
@@ -12,14 +12,16 @@
 #include "dot-column.hh"
 #include "side-position-interface.hh"
 #include "engraver.hh"
+#include "stem.hh"
 
 class Dot_column_engraver : public Engraver
 {
-  Grob *dotcol_p_ ;
-  Link_array<Item> head_l_arr_;
+  Grob *dotcol_ ;
+  Grob * stem_;
+  Link_array<Item> heads_;
 public:
-  VIRTUAL_COPY_CONS(Translator);
-  Dot_column_engraver();
+  TRANSLATOR_DECLARATIONS(
+  Dot_column_engraver );
   
 protected:
   virtual void acknowledge_grob (Grob_info);
@@ -29,40 +31,59 @@ protected:
 
 Dot_column_engraver::Dot_column_engraver ()
 {
-  dotcol_p_ =0;
+  dotcol_ =0;
+  stem_ = 0;
 }
 
 void
 Dot_column_engraver::stop_translation_timestep ()
 {
-  if (dotcol_p_)
+  if (dotcol_)
     {
-      typeset_grob (dotcol_p_);
-      dotcol_p_ =0;
+
+      /*
+	Add the stem to the support so dots stay clear of flags.
+
+	See [Ross, p 171]
+       */
+      if (stem_)
+	dotcol_->set_grob_property ("stem", stem_->self_scm ());
+      
+      typeset_grob (dotcol_);
+      dotcol_ =0;
     }
-  head_l_arr_.clear ();
+  heads_.clear ();
+  stem_ =0;
 }
 
 void
 Dot_column_engraver::acknowledge_grob (Grob_info info)
 {
-  Grob *d = unsmob_element (info.elem_l_->get_grob_property ("dot"));
+  Grob *d = unsmob_grob (info.grob_->get_grob_property ("dot"));
   if (d)
     {
-      if (!dotcol_p_)
+      if (!dotcol_)
 	{
-	  dotcol_p_ = new Item(get_property ("DotColumn"));
-
-	  Dot_column::set_interface (dotcol_p_);
-	  Side_position::set_axis (dotcol_p_, X_AXIS);
-	  Side_position::set_direction (dotcol_p_, RIGHT);      
-	  announce_grob (dotcol_p_, 0);
+	  dotcol_ = new Item (get_property ("DotColumn"));
+	  announce_grob(dotcol_, SCM_EOL);
 	}
 
-      Dot_column::add_head (dotcol_p_, info.elem_l_);
+      Dot_column::add_head (dotcol_, info.grob_);
+    }
+  else if (Stem::has_interface (info.grob_))
+    {
+      stem_ = info.grob_;
     }
 }
 
 
-ADD_THIS_TRANSLATOR(Dot_column_engraver);
 
+
+ENTER_DESCRIPTION(Dot_column_engraver,
+/* descr */       " Engraves dots on dotted notes shifted to the right of the note.
+If omitted, then dots appear on top of the notes.
+",
+/* creats*/       "DotColumn",
+/* acks  */       "rhythmic-head-interface dot-column-interface stem-interface",
+/* reads */       "",
+/* write */       "");