X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fcluster.cc;h=6cb0060e67cc33c28f2ed624d3f03f0ee6881420;hb=585959e4a373db9658d84ace8f3d4f4f6af7b190;hp=f6ca03ab359efbff6f217b748f9973b67689ce53;hpb=2c22efe5a46a37065b10c3f51c5d7db00d07d318;p=lilypond.git diff --git a/lily/cluster.cc b/lily/cluster.cc index f6ca03ab35..6cb0060e67 100644 --- a/lily/cluster.cc +++ b/lily/cluster.cc @@ -3,29 +3,27 @@ source file of the GNU LilyPond music typesetter - (c) 2002--2005 Juergen Reuter + (c) 2002--2006 Juergen Reuter - Han-Wen Nienhuys + Han-Wen Nienhuys */ #include "cluster.hh" - -#include - -#include "spanner.hh" +#include "international.hh" #include "item.hh" -#include "pitch.hh" -#include "staff-symbol-referencer.hh" #include "lookup.hh" #include "output-def.hh" -#include "warn.hh" +#include "pitch.hh" #include "pointer-group-interface.hh" +#include "spanner.hh" +#include "staff-symbol-referencer.hh" +#include "warn.hh" /* TODO: Add support for cubic spline segments. -*/ + */ Stencil -brew_cluster_piece (Grob *me, Array bottom_points, Array top_points) +brew_cluster_piece (Grob *me, vector bottom_points, vector top_points) { Real blotdiameter = Staff_symbol_referencer::staff_space (me) / 2; @@ -36,12 +34,10 @@ brew_cluster_piece (Grob *me, Array bottom_points, Array top_poi Offset hvpadding = 0.5 * hpadding + vpadding; SCM shape_scm = me->get_property ("style"); - String shape; + string shape; if (scm_is_symbol (shape_scm)) - { - shape = ly_symbol2string (shape_scm); - } + shape = ly_symbol2string (shape_scm); else { programming_error ("#'style should be symbol."); @@ -50,10 +46,10 @@ brew_cluster_piece (Grob *me, Array bottom_points, Array top_poi } Stencil out; - Array points; + vector points; points.clear (); int size = bottom_points.size (); - if (String::compare (shape, "leftsided-stairs") == 0) + if (shape == "leftsided-stairs") { for (int i = 0; i < size - 1; i++) { @@ -64,7 +60,7 @@ brew_cluster_piece (Grob *me, Array bottom_points, Array top_poi out.add_stencil (Lookup::round_filled_box (box, blotdiameter)); } } - else if (String::compare (shape, "rightsided-stairs") == 0) + else if (shape == "rightsided-stairs") { for (int i = 0; i < size - 1; i++) { @@ -75,7 +71,7 @@ brew_cluster_piece (Grob *me, Array bottom_points, Array top_poi out.add_stencil (Lookup::round_filled_box (box, blotdiameter)); } } - else if (String::compare (shape, "centered-stairs") == 0) + else if (shape == "centered-stairs") { Real left_xmid = bottom_points[0][X_AXIS]; for (int i = 0; i < size - 1; i++) @@ -98,22 +94,20 @@ brew_cluster_piece (Grob *me, Array bottom_points, Array top_poi + hvpadding); out.add_stencil (Lookup::round_filled_box (box, blotdiameter)); } - else if (String::compare (shape, "ramp") == 0) + else if (shape == "ramp") { - points.push (bottom_points[0] - vpadding + hpadding); + points.push_back (bottom_points[0] - vpadding + hpadding); for (int i = 1; i < size - 1; i++) - points.push (bottom_points[i] - vpadding); - points.push (bottom_points[size - 1] - vpadding - hpadding); - points.push (top_points[size - 1] + vpadding - hpadding); + points.push_back (bottom_points[i] - vpadding); + points.push_back (bottom_points[size - 1] - vpadding - hpadding); + points.push_back (top_points[size - 1] + vpadding - hpadding); for (int i = size - 2; i > 0; i--) - points.push (top_points[i] + vpadding); - points.push (top_points[0] + vpadding + hpadding); + points.push_back (top_points[i] + vpadding); + points.push_back (top_points[0] + vpadding + hpadding); out.add_stencil (Lookup::round_filled_polygon (points, blotdiameter)); } else - { - me->warning (_f ("unknown cluster style `%s'", shape.to_str0 ())); - } + me->warning (_f ("unknown cluster style `%s'", shape.c_str ())); return out; } @@ -135,8 +129,8 @@ Cluster::print (SCM smob) Grob *commonx = left_bound->common_refpoint (right_bound, X_AXIS); - Link_array const &cols = extract_grob_array (me, "columns"); - if (cols.is_empty ()) + vector const &cols = extract_grob_array (me, "columns"); + if (cols.empty ()) { me->warning (_ ("junking empty cluster")); me->suicide (); @@ -146,8 +140,8 @@ Cluster::print (SCM smob) commonx = common_refpoint_of_array (cols, commonx, X_AXIS); Grob *commony = common_refpoint_of_array (cols, me, Y_AXIS); - Array bottom_points; - Array top_points; + vector bottom_points; + vector top_points; Real left_coord = left_bound->relative_coordinate (commonx, X_AXIS); @@ -156,28 +150,28 @@ Cluster::print (SCM smob) line with the center of the note heads? */ - for (int i = 0; i < cols.size (); i++) + for (vsize i = 0; i < cols.size (); i++) { Grob *col = cols[i]; Interval yext = col->extent (commony, Y_AXIS); Real x = col->relative_coordinate (commonx, X_AXIS) - left_coord; - bottom_points.push (Offset (x, yext[DOWN])); - top_points.push (Offset (x, yext[UP])); + bottom_points.push_back (Offset (x, yext[DOWN])); + top_points.push_back (Offset (x, yext[UP])); } /* Across a line break we anticipate on the next pitches. */ - if (spanner->original_) + if (spanner->original ()) { - Spanner *orig = dynamic_cast (spanner->original_); + Spanner *orig = dynamic_cast (spanner->original ()); if (spanner->get_break_index () < orig->broken_intos_.size () - 1) { Spanner *next = orig->broken_intos_[spanner->get_break_index () + 1]; - Link_array const &next_cols = extract_grob_array (next, "columns"); + vector const &next_cols = extract_grob_array (next, "columns"); if (next_cols.size () > 0) { Grob *next_commony = common_refpoint_of_array (next_cols, next, Y_AXIS); @@ -186,14 +180,15 @@ Cluster::print (SCM smob) Interval v = col->extent (next_commony, Y_AXIS); Real x = right_bound->relative_coordinate (commonx, X_AXIS) - left_coord; - bottom_points.insert (Offset (x, v[DOWN]), 0); - top_points.insert (Offset (x, v[UP]), 0); + bottom_points.insert (bottom_points.begin (), + Offset (x, v[DOWN])); + top_points.insert (top_points.begin (), Offset (x, v[UP])); } } } - bottom_points.reverse (); - top_points.reverse (); + reverse (bottom_points); + reverse (top_points); Stencil out = brew_cluster_piece (me, bottom_points, top_points); out.translate_axis (- me->relative_coordinate (commony, Y_AXIS), Y_AXIS); @@ -213,13 +208,13 @@ ADD_INTERFACE (Cluster, "cluster-interface", struct Cluster_beacon { public: - DECLARE_SCHEME_CALLBACK (height, (SCM, SCM)); + DECLARE_SCHEME_CALLBACK (height, (SCM)); static bool has_interface (Grob *); }; -MAKE_SCHEME_CALLBACK (Cluster_beacon, height, 2); +MAKE_SCHEME_CALLBACK (Cluster_beacon, height, 1); SCM -Cluster_beacon::height (SCM g, SCM) +Cluster_beacon::height (SCM g) { Grob *me = unsmob_grob (g); Interval v = robust_scm2interval (me->get_property ("positions"), @@ -231,4 +226,6 @@ ADD_INTERFACE (Cluster_beacon, "cluster-beacon-interface", "A place holder for the cluster spanner to determine the vertical " "extents of a cluster spanner at this X position.", - "positions"); + + /* properties */ + "positions ");