X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fcluster-engraver.cc;h=e8ba45121229d414c83e0449ef07a5d2bd9b322d;hb=97a0169312a260933246ab224e4f8b0969871dd5;hp=cd0c59b8172ffbe4ce932483e861ce1adeb4c01f;hpb=358d6e99ada8019268ade9ba9080b2d0d88eeb7a;p=lilypond.git

diff --git a/lily/cluster-engraver.cc b/lily/cluster-engraver.cc
index cd0c59b817..e8ba451212 100644
--- a/lily/cluster-engraver.cc
+++ b/lily/cluster-engraver.cc
@@ -1,9 +1,21 @@
 /*
-  cluster-engraver.cc -- implement Cluster_engraver
-
-  (c) 2002--2006 Juergen Reuter <reuter@ipd.uka.de>
+  This file is part of LilyPond, the GNU music typesetter.
 
+  Copyright (C) 2002--2015 Juergen Reuter <reuter@ipd.uka.de>
   Han-Wen Nienhuys <hanwen@xs4all.nl>
+
+  LilyPond is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  LilyPond is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with LilyPond.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "engraver.hh"
@@ -13,6 +25,7 @@
 #include "pointer-group-interface.hh"
 #include "pitch.hh"
 #include "stream-event.hh"
+#include "item.hh"
 
 #include "translator.icc"
 
@@ -21,13 +34,13 @@ class Cluster_spanner_engraver : public Engraver
 
 protected:
   TRANSLATOR_DECLARATIONS (Cluster_spanner_engraver);
-  DECLARE_TRANSLATOR_LISTENER (cluster_note);
-  DECLARE_ACKNOWLEDGER (note_column);
+  void listen_cluster_note (Stream_event *);
+  void acknowledge_note_column (Grob_info);
   void stop_translation_timestep ();
   virtual void process_music ();
   virtual void finalize ();
 private:
-  vector<Stream_event*> cluster_notes_;
+  vector<Stream_event *> cluster_notes_;
   Item *beacon_;
 
   void typeset_grobs ();
@@ -35,7 +48,8 @@ private:
   Spanner *finished_spanner_;
 };
 
-Cluster_spanner_engraver::Cluster_spanner_engraver ()
+Cluster_spanner_engraver::Cluster_spanner_engraver (Context *c)
+  : Engraver (c)
 {
   spanner_ = 0;
   finished_spanner_ = 0;
@@ -54,11 +68,20 @@ Cluster_spanner_engraver::finalize ()
 void
 Cluster_spanner_engraver::typeset_grobs ()
 {
-  finished_spanner_ = 0;
+  if (finished_spanner_)
+    {
+      if (!finished_spanner_->get_bound (RIGHT))
+        {
+          finished_spanner_->set_bound (RIGHT,
+                                        finished_spanner_->get_bound (LEFT));
+
+        }
+
+      finished_spanner_ = 0;
+    }
   beacon_ = 0;
 }
 
-IMPLEMENT_TRANSLATOR_LISTENER (Cluster_spanner_engraver, cluster_note);
 void
 Cluster_spanner_engraver::listen_cluster_note (Stream_event *ev)
 {
@@ -77,19 +100,19 @@ Cluster_spanner_engraver::process_music ()
       int pmin = INT_MAX;
 
       for (vsize i = 0; i < cluster_notes_.size (); i++)
-	{
-	  Pitch *pit = unsmob_pitch (cluster_notes_[i]->get_property ("pitch"));
+        {
+          Pitch *pit = unsmob<Pitch> (cluster_notes_[i]->get_property ("pitch"));
 
-	  int p = (pit ? pit->steps () : 0) + c0;
+          int p = (pit ? pit->steps () : 0) + c0;
 
-	  pmax = max (pmax, p);
-	  pmin = min (pmin, p);
-	}
+          pmax = max (pmax, p);
+          pmin = min (pmin, p);
+        }
 
       beacon_ = make_item ("ClusterSpannerBeacon", cluster_notes_[0]->self_scm ());
       beacon_->set_property ("positions",
-			     scm_cons (scm_from_int (pmin),
-				       scm_from_int (pmax)));
+                             scm_cons (scm_from_int (pmin),
+                                       scm_from_int (pmax)));
     }
 
   if (beacon_ && !spanner_)
@@ -112,17 +135,32 @@ Cluster_spanner_engraver::stop_translation_timestep ()
 void
 Cluster_spanner_engraver::acknowledge_note_column (Grob_info info)
 {
-  if (!beacon_ && Note_column::has_interface (info.grob ()))
+  if (!beacon_ && has_interface<Note_column> (info.grob ()))
     {
       finished_spanner_ = spanner_;
       spanner_ = 0;
     }
 }
 
-ADD_ACKNOWLEDGER (Cluster_spanner_engraver, note_column);
+void
+Cluster_spanner_engraver::boot ()
+{
+  ADD_LISTENER (Cluster_spanner_engraver, cluster_note);
+  ADD_ACKNOWLEDGER (Cluster_spanner_engraver, note_column);
+}
+
 ADD_TRANSLATOR (Cluster_spanner_engraver,
-		/* doc */ 	"Engraves a cluster using Spanner notation ",
-		/* create */ 	"ClusterSpanner ClusterSpannerBeacon",
-		/* read */ 	"",
-		/* write */	"");
+                /* doc */
+                "Engrave a cluster using @code{Spanner} notation.",
+
+                /* create */
+                "ClusterSpanner "
+                "ClusterSpannerBeacon ",
+
+                /* read */
+                "",
+
+                /* write */
+                ""
+               );