X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fclef-engraver.cc;h=fa54f7a8dc047cf6de9fee6d1a113d1ce7defd18;hb=f1b93c0d52ef9229f8b58acc2ec8207ed50f5bee;hp=e7a0d003045da9accfed077dc02c672bd29388f0;hpb=02c656d3b0cb895cc81b428d699d960746800e45;p=lilypond.git

diff --git a/lily/clef-engraver.cc b/lily/clef-engraver.cc
index e7a0d00304..fa54f7a8dc 100644
--- a/lily/clef-engraver.cc
+++ b/lily/clef-engraver.cc
@@ -17,6 +17,8 @@
 #include "direction.hh"
 #include "side-position-interface.hh"
 
+#include "translator.icc"
+
 class Clef_engraver : public Engraver
 {
 public:
@@ -25,9 +27,11 @@ public:
   Direction octave_dir_;
 
 protected:
-  virtual void stop_translation_timestep ();
-  virtual void process_music ();
-  virtual void acknowledge_grob (Grob_info);
+  void stop_translation_timestep ();
+  void process_music ();
+  DECLARE_ACKNOWLEDGER (bar_line);
+
+  virtual void derived_mark () const;
 private:
   Item *clef_;
   Item *octavate_;
@@ -40,6 +44,14 @@ private:
   void inspect_clef_properties ();
 };
 
+void
+Clef_engraver::derived_mark () const
+{
+  scm_gc_mark (prev_octavation_);
+  scm_gc_mark (prev_cpos_);
+  scm_gc_mark (prev_glyph_);
+}
+
 Clef_engraver::Clef_engraver ()
 {
   clef_ = 0;
@@ -49,7 +61,7 @@ Clef_engraver::Clef_engraver ()
   /*
     will trigger a clef at the start since #f != ' ()
   */
-  prev_cpos_ = prev_glyph_ = SCM_BOOL_F;
+  prev_octavation_ = prev_cpos_ = prev_glyph_ = SCM_BOOL_F;
 }
 
 void
@@ -69,15 +81,11 @@ Clef_engraver::set_glyph ()
    ie. a breakpoint)
 */
 void
-Clef_engraver::acknowledge_grob (Grob_info info)
+Clef_engraver::acknowledge_bar_line (Grob_info info)
 {
   Item *item = dynamic_cast<Item *> (info.grob ());
-  if (item)
-    {
-      if (Bar_line::has_interface (info.grob ())
-	  && scm_is_string (get_property ("clefGlyph")))
-	create_clef ();
-    }
+  if (item && scm_is_string (get_property ("clefGlyph")))
+    create_clef ();
 }
 
 void
@@ -102,7 +110,7 @@ Clef_engraver::create_clef ()
 	  int dir = sign (abs_oct);
 	  abs_oct = abs (abs_oct) + 1;
 
-	  SCM txt = scm_number_to_string (scm_int2num (abs_oct),
+	  SCM txt = scm_number_to_string (scm_from_int (abs_oct),
 					  scm_from_int (10));
 
 	  g->set_property ("text",
@@ -112,7 +120,7 @@ Clef_engraver::create_clef ()
 
 	  g->set_parent (clef_, Y_AXIS);
 	  g->set_parent (clef_, X_AXIS);
-	  g->set_property ("direction", scm_int2num (dir));
+	  g->set_property ("direction", scm_from_int (dir));
 	  octavate_ = g;
 	}
     }
@@ -131,11 +139,11 @@ Clef_engraver::inspect_clef_properties ()
   SCM octavation = get_property ("clefOctavation");
   SCM force_clef = get_property ("forceClef");
 
-  if (clefpos == SCM_EOL 
-       || scm_equal_p (glyph, prev_glyph_) == SCM_BOOL_F
-       || scm_equal_p (clefpos, prev_cpos_) == SCM_BOOL_F
-       || scm_equal_p (octavation, prev_octavation_) == SCM_BOOL_F
-       || to_boolean (force_clef))
+  if (clefpos == SCM_EOL
+      || scm_equal_p (glyph, prev_glyph_) == SCM_BOOL_F
+      || scm_equal_p (clefpos, prev_cpos_) == SCM_BOOL_F
+      || scm_equal_p (octavation, prev_octavation_) == SCM_BOOL_F
+      || to_boolean (force_clef))
     {
       set_glyph ();
       if (prev_cpos_ != SCM_BOOL_F || to_boolean (get_property ("firstClef")))
@@ -151,7 +159,8 @@ Clef_engraver::inspect_clef_properties ()
 
   if (to_boolean (force_clef))
     {
-      Context *w = context ()->where_defined (ly_symbol2scm ("forceClef"));
+      SCM prev;
+      Context *w = context ()->where_defined (ly_symbol2scm ("forceClef"), &prev);
       w->set_property ("forceClef", SCM_EOL);
     }
 }
@@ -163,17 +172,13 @@ Clef_engraver::stop_translation_timestep ()
     {
       SCM vis = 0;
       if (to_boolean (clef_->get_property ("non-default")))
-	{
-	  vis = get_property ("explicitClefVisibility");
-	}
+	vis = get_property ("explicitClefVisibility");
 
       if (vis)
 	{
 	  clef_->set_property ("break-visibility", vis);
 	  if (octavate_)
-	    {
-	      octavate_->set_property ("break-visibility", vis);
-	    }
+	    octavate_->set_property ("break-visibility", vis);
 	}
 
       clef_ = 0;
@@ -182,10 +187,10 @@ Clef_engraver::stop_translation_timestep ()
     }
 }
 
+ADD_ACKNOWLEDGER (Clef_engraver, bar_line);
 ADD_TRANSLATOR (Clef_engraver,
-		/* descr */ "Determine and set reference point for pitches",
-		/* creats*/ "Clef OctavateEight",
-		/* accepts */ "",
-		/* acks  */ "bar-line-interface",
-		/* reads */ "clefPosition clefGlyph middleCPosition clefOctavation explicitClefVisibility forceClef",
+		/* doc */ "Determine and set reference point for pitches",
+		/* create */ "Clef OctavateEight",
+		/* accept */ "",
+		/* read */ "clefPosition clefGlyph middleCPosition clefOctavation explicitClefVisibility forceClef",
 		/* write */ "");