X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fbeaming-pattern.cc;h=46a46a5d2ea529aa4c1e09836413f4ee0b708d05;hb=8659a99f233f5c4684292728e7ad4206669b35b0;hp=f1408497cd3f0dafc5794faf8b838904caf38571;hpb=9a73c67a79a21b889d67f8d28f2c106de830d936;p=lilypond.git diff --git a/lily/beaming-pattern.cc b/lily/beaming-pattern.cc index f1408497cd..46a46a5d2e 100644 --- a/lily/beaming-pattern.cc +++ b/lily/beaming-pattern.cc @@ -1,7 +1,7 @@ /* This file is part of LilyPond, the GNU music typesetter. - Copyright (C) 1999--2012 Han-Wen Nienhuys + Copyright (C) 1999--2015 Han-Wen Nienhuys LilyPond is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -19,6 +19,7 @@ #include "context.hh" #include "beaming-pattern.hh" +#include "misc.hh" /* Represents a stem belonging to a beam. Sometimes (for example, if the stem @@ -43,8 +44,8 @@ Beam_rhythmic_element::Beam_rhythmic_element () tuplet_start_ = false; } -Beam_rhythmic_element::Beam_rhythmic_element (Moment m, int i, bool inv, - Rational factor, bool tuplet_start) +Beam_rhythmic_element::Beam_rhythmic_element (Moment m, int i, bool inv, + Rational factor, bool tuplet_start) { start_moment_ = m; rhythmic_importance_ = 0; @@ -162,14 +163,27 @@ Beaming_pattern::beamify (Beaming_options const &options) for (int i = 0; i < 2; i++) for (vsize i = 1; i < infos_.size () - 1; i++) { - Direction non_flag_dir = other_dir (flag_directions[i]); + Direction non_flag_dir = -flag_directions[i]; if (non_flag_dir) { - int importance = infos_[i + 1].rhythmic_importance_; - int count = (importance < 0 && options.subdivide_beams_) - ? 1 : min (min (infos_[i].count (non_flag_dir), - infos_[i + non_flag_dir].count (-non_flag_dir)), - infos_[i - non_flag_dir].count (non_flag_dir)); + int count = + (infos_[i + 1].rhythmic_importance_ < 0 && + options.subdivide_beams_) + // we're left of a subdivision + ? (i != infos_.size () - 2) + // respect the beam count for shortened beams ... + ? max (beam_count_for_rhythmic_position (i + 1), + beam_count_for_length (remaining_length (i + 1))) + // ... except if there's only one trailing stem + : beam_count_for_rhythmic_position (i + 1) + + // we're at any other stem + : min (min (infos_[i].count (non_flag_dir), + infos_[i + non_flag_dir].count (-non_flag_dir)), + infos_[i - non_flag_dir].count (non_flag_dir)); + + // Ensure at least one beam is left, even for groups longer than 1/8 + count = max (count, 1); infos_[i].beam_count_drul_[non_flag_dir] = count; } @@ -189,7 +203,6 @@ update_tuplet (Moment start_moment, Rational factor, Moment *tuplet_start_moment *tuplet_start_moment = Moment (-1, 1); } - /* Get the group start position, the next group starting position, and the next beat starting position, given start_moment, base_moment, @@ -209,7 +222,7 @@ find_location (SCM grouping, Moment base_moment, Moment start_moment, while (*next_group_pos < *next_beat_pos) { - int group_count = 1; //default -- 1 base moments in a beam + I64 group_count = 1; //default -- 1 base moments in a beam if (scm_is_pair (grouping)) { group_count = scm_to_int (scm_car (grouping)); @@ -218,17 +231,17 @@ find_location (SCM grouping, Moment base_moment, Moment start_moment, // If we have a tuplet, the count should be determined from // the maximum tuplet size for beamed tuplets. - int tuplet_number = factor.den (); - if (tuplet_number > 1) + U64 tuplet_number = factor.den (); + if (tuplet_number > 1U) { // We use 1/8 as the base moment for the tuplet because it's // the largest beamed value. If the tuplet is shorter, it's // OK, the code still works - int test_count = ( Moment (Rational (1, 8) / factor ) / base_moment).num (); + I64 test_count = ( Moment (Rational (1, 8) / factor) / base_moment).num (); if (test_count > group_count) group_count = test_count; } *group_pos = *next_group_pos; - *next_group_pos = *group_pos + group_count * base_moment; + *next_group_pos = *group_pos + Rational(group_count) * base_moment; } } @@ -239,7 +252,7 @@ Beaming_pattern::find_rhythmic_importance (Beaming_options const &options) Moment next_group_pos (0); Moment next_beat_pos (options.base_moment_); Moment tuplet_start_moment (-1, 1); - int tuplet_number = 1; + I64 tuplet_number = 1; SCM grouping = options.grouping_; vsize i = 0; @@ -282,8 +295,8 @@ Beaming_pattern::find_rhythmic_importance (Beaming_options const &options) // the fraction of the tuplet, instead of the fraction of // a beat. Moment ratio = (tuplet_number == 1) - ? dt / options.base_moment_ - : tuplet_dt / Moment (1, 8) / tuplet_moment; + ? dt / options.base_moment_ + : tuplet_dt / Moment (1, 8) / tuplet_moment; if (infos_[i].rhythmic_importance_ >= 0) infos_[i].rhythmic_importance_ = (int) ratio.den (); @@ -352,11 +365,31 @@ Beaming_pattern::start_moment (int i) const Moment Beaming_pattern::end_moment (int i) const { - Duration *dur = new Duration (2 + max (beamlet_count (i, LEFT), - beamlet_count (i, RIGHT)), - 0); + Duration dur (2 + max (beamlet_count (i, LEFT), + beamlet_count (i, RIGHT)), + 0); + + return infos_.at (i).start_moment_ + + infos_.at (i).factor_ * dur.get_length (); +} + +Moment +Beaming_pattern::remaining_length (int i) const +{ + return end_moment (infos_.size () - 1) - infos_[i].start_moment_; +} - return infos_.at (i).start_moment_ + dur->get_length (); +int +Beaming_pattern::beam_count_for_rhythmic_position (int idx) const +{ + // Calculate number of beams representing the rhythmic position of given stem + return intlog2(infos_[idx].start_moment_.main_part_.den()) - 2; +} + +int +Beaming_pattern::beam_count_for_length (Moment len) const +{ + return intlog2(len.main_part_.den()) - 2 - intlog2(len.main_part_.num()); } bool