X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fbar-number-engraver.cc;h=9f2396504248255304a885ac9d6773718798dfa6;hb=e9a308e9c6002900fc336733950a0175bcbcc333;hp=fb3c13251158eb8538fc59fd83c0343ed96e2ea8;hpb=7f6816438d66f6d70db5b68454d80656a0f3f131;p=lilypond.git

diff --git a/lily/bar-number-engraver.cc b/lily/bar-number-engraver.cc
index fb3c132511..9f23965042 100644
--- a/lily/bar-number-engraver.cc
+++ b/lily/bar-number-engraver.cc
@@ -3,7 +3,7 @@
 
   source file of the GNU LilyPond music typesetter
 
-  (c) 1997--2005 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+  (c) 1997--2007 Han-Wen Nienhuys <hanwen@xs4all.nl>
 */
 
 #include "paper-column.hh"
@@ -20,14 +20,14 @@
   system-start-delims. If we find these, and the top staff is in the
   staff-group, add padding to the bar number.
 */
-
 class Bar_number_engraver : public Engraver
 {
 protected:
   Item *text_;
 protected:
   void stop_translation_timestep ();
-  DECLARE_ACKNOWLEDGER(break_aligned);
+  DECLARE_ACKNOWLEDGER (break_aligned);
+  DECLARE_ACKNOWLEDGER (break_alignment);
   void process_music ();
   void create_items ();
   TRANSLATOR_DECLARATIONS (Bar_number_engraver);
@@ -36,8 +36,6 @@ protected:
 void
 Bar_number_engraver::process_music ()
 {
-  // todo include (&&!time->cadenza_b_)
-
   SCM wb = get_property ("whichBar");
 
   if (scm_is_string (wb))
@@ -53,7 +51,7 @@ Bar_number_engraver::process_music ()
 	      create_items ();
 	      // guh.
 	      text_->set_property
-		("text", scm_makfrom0str (to_string (scm_to_int (bn)).to_str0 ()));
+		("text", scm_number_to_string (bn, scm_from_int (10)));
 	    }
 	}
     }
@@ -64,13 +62,19 @@ Bar_number_engraver::Bar_number_engraver ()
   text_ = 0;
 }
 
+
+/*
+  see rehearsal mark comments.
+ */
 void
 Bar_number_engraver::acknowledge_break_aligned (Grob_info inf)
 {
   Grob *s = inf.grob ();
   if (text_
+      && !text_->get_parent (X_AXIS)
       && dynamic_cast<Item *> (s)
-      && s->get_property ("break-align-symbol") == ly_symbol2scm ("left-edge"))
+      && (s->get_property_data ("break-align-symbol")
+	  == text_->get_property_data ("break-align-symbol")))
     {
       /*
 	By default this would land on the Paper_column -- so why
@@ -79,17 +83,24 @@ Bar_number_engraver::acknowledge_break_aligned (Grob_info inf)
     }
 }
 
+
 void
-Bar_number_engraver::stop_translation_timestep ()
+Bar_number_engraver::acknowledge_break_alignment (Grob_info inf)
 {
-  if (text_)
+  Grob *s = inf.grob ();
+  if (text_
+      && dynamic_cast<Item *> (s))
     {
-      text_->set_object ("side-support-elements",
-			 grob_list_to_grob_array (get_property ("stavesFound")));
-      text_ = 0;
+      text_->set_parent (s, X_AXIS);
     }
 }
 
+void
+Bar_number_engraver::stop_translation_timestep ()
+{
+  text_ = 0;
+}
+
 void
 Bar_number_engraver::create_items ()
 {
@@ -97,16 +108,24 @@ Bar_number_engraver::create_items ()
     return;
 
   text_ = make_item ("BarNumber", SCM_EOL);
-  Side_position_interface::set_axis (text_, Y_AXIS);
 }
 
+
+ADD_ACKNOWLEDGER(Bar_number_engraver,break_aligned);
+ADD_ACKNOWLEDGER(Bar_number_engraver,break_alignment);
+
 ADD_TRANSLATOR (Bar_number_engraver,
-		/* descr */ "A bar number is created whenever measurePosition is zero. It is\n"
+		/* doc */ "A bar number is created whenever measurePosition "
+		"is zero and when there is a bar line (ie. when @code{whichBar} is set. "
+		"It is \n"
 		"put on top of all staves, and appears only at  left side of the staff. "
 		"The staves are taken from @code{stavesFound}, which is maintained by "
 		"@code{@ref{Staff_collecting_engraver}}. ",
 
-		/* creats*/ "BarNumber",
-		/* accepts */ "",
-		/* reads */ "currentBarNumber stavesFound barNumberVisibility",
+		/* create */ "BarNumber",
+		/* read */
+		"currentBarNumber "
+		"whichBar "
+		"stavesFound "
+		"barNumberVisibility ",
 		/* write */ "");