X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fbar-engraver.cc;h=f3b94b25329305ae2334db40a495c8ca7b748cb6;hb=7e72a1e50e94a7f9738d62599de79fe7745f600c;hp=cba7a83573668c23e4bad2f7fab3a72436f7d16e;hpb=a4d7106c75b325441063fd9ba9c4131979784aa5;p=lilypond.git

diff --git a/lily/bar-engraver.cc b/lily/bar-engraver.cc
index cba7a83573..f3b94b2532 100644
--- a/lily/bar-engraver.cc
+++ b/lily/bar-engraver.cc
@@ -3,13 +3,13 @@
 
   source file of the GNU LilyPond music typesetter
 
-  (c)  1997--2000 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+  (c) 1997--2004 Han-Wen Nienhuys <hanwen@cs.uu.nl>
   Jan Nieuwenhuizen <janneke@gnu.org>
 */
 
-#include "bar.hh"
+#include "bar-line.hh"
 #include "score-engraver.hh"
-#include "musical-request.hh"
+#include "event.hh"
 #include "engraver-group-engraver.hh"
 #include "warn.hh"
 #include "item.hh"
@@ -22,108 +22,97 @@
 class Bar_engraver : public Engraver
 {
 public:
-  Bar_engraver();
-  VIRTUAL_COPY_CONS(Translator);
-  void request_bar (String type_str);
+  TRANSLATOR_DECLARATIONS(  Bar_engraver );
+  void request_bar (String type_string);
     
 protected:
-  virtual void do_creation_processing ();
-  virtual void do_removal_processing ();
-  void deprecated_process_music();
-  virtual void do_pre_move_processing();
-  virtual void process_acknowledged ();
+  virtual void finalize ();
+  virtual void stop_translation_timestep ();
+  virtual void process_acknowledged_grobs ();
 
 private:
   void typeset_bar ();
   void create_bar ();
 
-  Item * bar_p_;
+  Item * bar_;
 };
 
-Bar_engraver::Bar_engraver()
+Bar_engraver::Bar_engraver ()
 {
-  bar_p_ =0;
-  do_post_move_processing();
+  bar_ =0;
 }
 
 void
 Bar_engraver::create_bar ()
 {
-  if (!bar_p_)
+  if (!bar_)
     {
-      bar_p_ = new Item (get_property ("BarLine"));
-
+      bar_ = make_item ("BarLine");
       SCM gl = get_property ("whichBar");
-      if (scm_equal_p (gl, bar_p_->get_elt_property ("glyph")) != SCM_BOOL_T)
-	  bar_p_->set_elt_property ("glyph", gl);
+      if (scm_equal_p (gl, bar_->get_grob_property ("glyph")) != SCM_BOOL_T)
+	  bar_->set_grob_property ("glyph", gl);
       
-      announce_element (bar_p_, 0);
+      announce_grob(bar_, SCM_EOL);
     }
 }
 
-void 
-Bar_engraver::do_creation_processing ()
-{
-}
-
 void
-Bar_engraver::do_removal_processing ()
+Bar_engraver::finalize ()
 {
   typeset_bar ();
 }
 
 /*
-  Bar_engraver should come *after* any engravers that expect bars to
-  modify whichBar in  deprecated_process_music () be typeset
+  Bar_engraver should come *after* any engravers that  
+  modify whichBar
+
+  This is a little hairy : whichBar may be set by
+  Repeat_acknowledge_engraver::process_music, which is at score
+  context. This means that grobs could should be created after
+  process_music. We do stuff process_acknowledged_grobs(), just to be
+  on the safe side.
+     
 */
+
 void
-Bar_engraver::deprecated_process_music()
+Bar_engraver::process_acknowledged_grobs ()
 {
-  SCM b =get_property ("whichBar");
-  if (gh_string_p (b))
+  if (!bar_ && gh_string_p (get_property ("whichBar")))
     {
       create_bar ();
     }
 }
 
-void
-Bar_engraver::process_acknowledged ()
-{
-  deprecated_process_music ();
-}
-
 void
 Bar_engraver::typeset_bar ()
 {
-  if (bar_p_) 
+  if (bar_) 
     {
-      typeset_element (bar_p_);
-      bar_p_ =0;
+      typeset_grob (bar_);
+      bar_ =0;
     }
 }
 
 /*
-  lines may only be broken if there is a barline in all staffs 
+  lines may only be broken if there is a barline in all staves 
 */
 void 
-Bar_engraver::do_pre_move_processing()
+Bar_engraver::stop_translation_timestep ()
 {
-  if (!bar_p_)
+  if (!bar_)
     {
-      Score_engraver * e = 0;
-      Translator * t  =  daddy_grav_l ();
-      for (; !e && t;  t = t->daddy_trans_l_)
-	{
-	  e = dynamic_cast<Score_engraver*> (t);
-	}
-
-      if (!e)
-	programming_error ("No score engraver!");
-      else
-	e->forbid_breaks ();	// guh. Use properties!
+      top_engraver ()->forbid_breaks ();	// guh. Use properties!
     }
   else
     typeset_bar ();
 }
 
-ADD_THIS_TRANSLATOR(Bar_engraver);
+
+ENTER_DESCRIPTION(Bar_engraver,
+/* descr */       "Create barlines. This engraver is controlled through the "
+"@code{whichBar} property. If it has no bar line to create, it will forbid a linebreak at this point",
+/* creats*/       "BarLine",
+/* accepts */     "",
+/* acks  */      "",
+/* reads */       "whichBar",
+/* write */       "");