X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fauto-beam-engraver.cc;h=aef96d8da5c3387953fd9aa5c9c74429a5e48222;hb=3fc91138b05cfdd6b8446608eb1764cad85202f8;hp=fd519c340cf011b24f1bfc1e45db4cb783c31807;hpb=43c708d5857fd1a15f0ebcf41d04f5a24441dc9a;p=lilypond.git diff --git a/lily/auto-beam-engraver.cc b/lily/auto-beam-engraver.cc index fd519c340c..aef96d8da5 100644 --- a/lily/auto-beam-engraver.cc +++ b/lily/auto-beam-engraver.cc @@ -3,217 +3,269 @@ source file of the GNU LilyPond music typesetter - (c) 1999 Jan Nieuwenhuizen + (c) 1999--2002 Jan Nieuwenhuizen */ + #include "beaming.hh" -#include "auto-beam-engraver.hh" #include "musical-request.hh" -#include "bar.hh" #include "beam.hh" -#include "rest.hh" #include "stem.hh" #include "debug.hh" -#include "timing-engraver.hh" #include "engraver-group-engraver.hh" +#include "bar-line.hh" +#include "rest.hh" +#include "engraver.hh" +#include "item.hh" +#include "spanner.hh" -ADD_THIS_TRANSLATOR (Auto_beam_engraver); - -Auto_beam_engraver::Auto_beam_engraver () -{ - stem_l_arr_p_ = 0; - shortest_mom_ = Moment (1, 8); - finished_beam_p_ = 0; - finished_grouping_p_ = 0; - grouping_p_ = 0; - timer_l_ =0; -} - -void -Auto_beam_engraver::do_creation_processing () -{ - Translator * t = daddy_grav_l ()->get_simple_translator ("Timing_engraver"); - timer_l_ = dynamic_cast (t); -} - -bool -Auto_beam_engraver::do_try_music (Music*) -{ - return false; -} - -void -Auto_beam_engraver::do_process_requests () -{ - consider_end_and_begin (shortest_mom_); -} +/* + TODO: figure what to do in grace? -void -Auto_beam_engraver::consider_end_and_begin (Moment test_mom) + TODO: documentme. + */ +class Auto_beam_engraver : public Engraver { - if (!timer_l_) - return; - - Time_description const *time = &timer_l_->time_; - int num = time->whole_per_measure_ / time->one_beat_; - int den = time->one_beat_.den_i (); - String time_str = String ("time") + to_str (num) + "_" + to_str (den); - - String type_str; - if (test_mom.num () != 1) - type_str = to_str (test_mom.num ()); - if (test_mom.den () != 1) - type_str = type_str + "_" + to_str (test_mom.den ()); + TRANSLATOR_DECLARATIONS(Auto_beam_engraver); +protected: + virtual void stop_translation_timestep (); + virtual void start_translation_timestep (); + virtual void finalize (); + virtual void acknowledge_grob (Grob_info); + virtual void create_grobs (); + +private: + bool test_moment (Direction, Moment); + void consider_begin (Moment); + void consider_end (Moment); + Spanner* create_beam_p (); + void begin_beam (); + void end_beam (); + void junk_beam (); + bool same_grace_state_b (Grob* e); + void typeset_beam (); /* - URG - - FIXME: SHOULD USE ALIST - + shortest_mom is the shortest note in the beam. */ + Moment shortest_mom_; + Spanner *finished_beam_p_; + Link_array* stem_l_arr_p_; - /* - Determine end moment for auto beaming (and begin, mostly 0==anywhere) - In order of increasing priority: - i. every beat - ii. time_beamAutoEnd - iii. time_beamAutoEnd - iv. beamAutoEnd - v. beamAutoEnd + int count_i_; + Moment last_add_mom_; + /* + Projected ending of the beam we're working on. + */ + Moment extend_mom_; + Moment beam_start_moment_; + Moment beam_start_location_; + bool subdivide_beams_; + + // We act as if beam were created, and start a grouping anyway. + Beaming_info_list*grouping_p_; + Beaming_info_list*finished_grouping_p_; +}; - Rationale: - [to be defined in config file] - i. easy catch-all rule - ii. exceptions for time signature - iii. exceptions for time signature, for specific duration type - [user override] - iv. generic override - v. override for specific duration type +Auto_beam_engraver::Auto_beam_engraver () +{ + count_i_ = 0; + stem_l_arr_p_ = 0; + shortest_mom_ = Moment (Rational (1, 8)); + finished_beam_p_ = 0; + finished_grouping_p_ = 0; + grouping_p_ = 0; +} - The user overrides should be required for common cases. - */ +/* + Determine end moment for auto beaming (or begin moment, but mostly + 0==anywhere) In order of increasing priority: - /* - first guess: begin beam at any position - */ - Moment begin_mom (0); - /* - first guess: end beam at end of beat - */ - Moment end_mom = time->one_beat_; + i. begin anywhere, end at every beat + ii. end * + iii. end + + iv. end * * * + v. end * * + + + Rationale: + + [to be defined in config file] + i. easy catch-all rule + ii. exceptions for time signature + iii. exceptions for time signature, for specific duration type + + [user override] + iv. generic override + v. override for specific duration type + +*/ +bool +Auto_beam_engraver::test_moment (Direction dir, Moment test_mom) +{ + SCM wild = scm_list_n (ly_symbol2scm ("*"), ly_symbol2scm ("*"), SCM_UNDEFINED); + SCM function; + if (dir == START) + function = scm_list_n (ly_symbol2scm ("begin"), SCM_UNDEFINED); + else + function = scm_list_n (ly_symbol2scm ("end"), SCM_UNDEFINED); - /* - second guess: property generic time exception - */ - SCM begin = get_property (time_str + "beamAutoBegin", 0); - if (SMOB_IS_TYPE_B(Moment, begin)) - begin_mom = * SMOB_TO_TYPE(Moment, begin); + Moment one_beat = *unsmob_moment (get_property ("beatLength")); + int num = int ((*unsmob_moment (get_property ("measureLength")) / one_beat).main_part_); + int den = one_beat.den (); + SCM time = scm_list_n (gh_int2scm (num), gh_int2scm (den), SCM_UNDEFINED); - SCM end = get_property (time_str + "beamAutoEnd", 0); - if (SMOB_IS_TYPE_B (Moment, end)) - end_mom = * SMOB_TO_TYPE(Moment,end); + SCM type = scm_list_n (gh_int2scm (test_mom.num ()), + gh_int2scm (test_mom.den ()), SCM_UNDEFINED); - /* - third guess: property time exception, specific for duration type - */ - if (type_str.length_i ()) + SCM settings = get_property ("autoBeamSettings"); + + /* first guess */ + + /* begin beam at any position + (and fallback for end) */ + Moment moment (0); + + /* end beam at end of beat */ + if (dir == STOP) { - SCM end_mult = get_property (time_str + "beamAutoEnd" + type_str, 0); - if (SMOB_IS_TYPE_B (Moment, end_mult)) - end_mom = * SMOB_TO_TYPE (Moment,end_mult); - - SCM begin_mult = get_property (time_str + "beamAutoBegin" + type_str, 0); - if (SMOB_IS_TYPE_B (Moment, begin_mult)) - begin_mom = * SMOB_TO_TYPE (Moment,begin_mult); + SCM beat (get_property ("beatLength")); + + if (unsmob_moment (beat)) + moment = *unsmob_moment (beat); } - /* - fourth guess [user override]: property plain generic - */ - begin = get_property ("beamAutoBegin", 0); - if (SMOB_IS_TYPE_B(Moment, begin)) - begin_mom = * SMOB_TO_TYPE(Moment, begin); - - + /* second guess: property generic time exception */ + SCM m = gh_assoc (gh_append3 (function, wild, time), settings); - end = get_property ("beamAutoEnd", 0); - if (SMOB_IS_TYPE_B (Moment, end)) - end_mom = * SMOB_TO_TYPE (Moment,end); - - /* - fifth guess [user override]: property plain, specific for duration type - */ - if (type_str.length_i ()) + if (m != SCM_BOOL_F && unsmob_moment (ly_cdr (m))) + moment = * unsmob_moment (ly_cdr (m)); + + /* third guess: property time exception, specific for duration type */ + m = gh_assoc (gh_append3 (function, type, time), settings); + if (m != SCM_BOOL_F && unsmob_moment (ly_cdr (m))) + moment = * unsmob_moment (ly_cdr (m)); + + /* fourth guess [user override]: property plain generic */ + m = gh_assoc (gh_append3 (function, wild, wild), settings); + if (m != SCM_BOOL_F && unsmob_moment (ly_cdr (m))) + moment = * unsmob_moment (ly_cdr (m)); + + /* fifth guess [user override]: property plain, specific for duration type */ + m = gh_assoc (gh_append3 (function, type, wild), settings); + if (m != SCM_BOOL_F && unsmob_moment (ly_cdr (m))) + moment = * unsmob_moment (ly_cdr (m)); + + Rational r; + if (moment.to_bool ()) { - SCM end_mult = get_property (String ("beamAutoEnd") + type_str, 0); - if (SMOB_IS_TYPE_B (Moment, end_mult)) - end_mom = * SMOB_TO_TYPE (Moment,end_mult); - - SCM begin_mult = get_property (String ("beamAutoBegin") + type_str, 0); - if (SMOB_IS_TYPE_B (Moment, begin_mult)) - begin_mom = * SMOB_TO_TYPE (Moment,begin_mult); + /* Ugh? measurePosition can be negative, when \partial + We may have to fix this elsewhere (timing translator) + r = unsmob_moment (get_property ("measurePosition"))->mod_rat (moment); + */ + Moment pos = * unsmob_moment (get_property ("measurePosition")); + if (pos < Moment (0)) + { + Moment length = * unsmob_moment (get_property ("measureLength")); + pos = length - pos; + } + r = pos.main_part_.mod_rat (moment.main_part_); } - - Rational r; - if (end_mom) - r = time->whole_in_measure_.mod_rat (end_mom); else - r = Moment (1); + { + if (dir == START) + /* if undefined, starting is ok */ + r = 0; + else + /* but ending is not */ + r = 1; + } + return !r; +} - if (stem_l_arr_p_ && !r) - end_beam (); - - /* - Allow already started autobeam to end - */ - SCM on = get_property ("noAutoBeaming", 0); - if (gh_boolean_p (on) && gh_scm2bool (on)) - return; - - if (begin_mom) - r = time->whole_in_measure_.mod_rat (begin_mom); - if (!stem_l_arr_p_ && (!begin_mom || !r)) - begin_beam (); +void +Auto_beam_engraver::consider_begin (Moment test_mom) +{ + bool off = to_boolean (get_property ("noAutoBeaming")); + if (!stem_l_arr_p_ && ! off) + { + bool b = test_moment (START, test_mom); + if (b) + begin_beam (); + } } - void -Auto_beam_engraver::begin_beam () +Auto_beam_engraver::consider_end (Moment test_mom) { - assert (!stem_l_arr_p_); - stem_l_arr_p_ = new Array; - assert (!grouping_p_); - grouping_p_ = new Beaming_info_list; - beam_start_moment_ = now_mom (); - beam_start_location_ = timer_l_->time_.whole_in_measure_; + if (stem_l_arr_p_) + { + /* Allow already started autobeam to end: + don't check for noAutoBeaming */ + bool b = test_moment (STOP, test_mom); + if (b) + end_beam (); + } } -Beam* +Spanner* Auto_beam_engraver::create_beam_p () { - Beam* beam_p = new Beam; - + if (to_boolean (get_property ("skipTypesetting"))) + { + return 0; + } + + Spanner* beam_p = new Spanner (get_property ("Beam")); for (int i = 0; i < stem_l_arr_p_->size (); i++) { /* watch out for stem tremolos and abbreviation beams */ - if ((*stem_l_arr_p_)[i]->beam_l_) + if (Stem::beam_l ((*stem_l_arr_p_)[i])) { + scm_gc_unprotect_object (beam_p->self_scm ()); return 0; } - beam_p->add_stem ((*stem_l_arr_p_)[i]); + Beam::add_stem (beam_p, (*stem_l_arr_p_)[i]); } - announce_element (Score_element_info (beam_p, 0)); + announce_grob(beam_p, SCM_EOL); return beam_p; } +void +Auto_beam_engraver::begin_beam () +{ + assert (!stem_l_arr_p_); + stem_l_arr_p_ = new Link_array; + assert (!grouping_p_); + grouping_p_ = new Beaming_info_list; + beam_start_moment_ = now_mom (); + beam_start_location_ = *unsmob_moment (get_property ("measurePosition")); + subdivide_beams_ = gh_scm2bool(get_property("subdivideBeams")); +} + + +void +Auto_beam_engraver::junk_beam () +{ + assert (stem_l_arr_p_); + + delete stem_l_arr_p_; + stem_l_arr_p_ = 0; + delete grouping_p_; + grouping_p_ = 0; + + shortest_mom_ = Moment (Rational (1, 8)); +} + void Auto_beam_engraver::end_beam () { @@ -222,6 +274,7 @@ Auto_beam_engraver::end_beam () junk_beam (); } else + { finished_beam_p_ = create_beam_p (); if (finished_beam_p_) @@ -229,18 +282,20 @@ Auto_beam_engraver::end_beam () delete stem_l_arr_p_; stem_l_arr_p_ = 0; grouping_p_ = 0; - shortest_mom_ = Moment (1, 8); } + + shortest_mom_ = Moment (Rational (1, 8)); } - + void Auto_beam_engraver::typeset_beam () { if (finished_beam_p_) { - finished_grouping_p_->beamify (); - finished_beam_p_->set_beaming (finished_grouping_p_); - typeset_element (finished_beam_p_); + finished_grouping_p_->beamify(*unsmob_moment (get_property ("beatLength")), + subdivide_beams_); + Beam::set_beaming (finished_beam_p_, finished_grouping_p_); + typeset_grob (finished_beam_p_); finished_beam_p_ = 0; delete finished_grouping_p_; @@ -249,8 +304,9 @@ Auto_beam_engraver::typeset_beam () } void -Auto_beam_engraver::do_post_move_processing () +Auto_beam_engraver::start_translation_timestep () { + count_i_ = 0; /* don't beam over skips */ @@ -265,13 +321,13 @@ Auto_beam_engraver::do_post_move_processing () } void -Auto_beam_engraver::do_pre_move_processing () +Auto_beam_engraver::stop_translation_timestep () { typeset_beam (); } void -Auto_beam_engraver::do_removal_processing () +Auto_beam_engraver::finalize () { /* finished beams may be typeset */ typeset_beam (); @@ -280,39 +336,31 @@ Auto_beam_engraver::do_removal_processing () junk_beam (); } -bool -Auto_beam_engraver::same_grace_state_b (Score_element* e) -{ - bool gr = e->get_elt_property ("grace") == SCM_BOOL_T; - SCM wg =get_property ("weAreGraceContext",0); - return (gh_boolean_p (wg) && gh_scm2bool (wg)) == gr; -} void -Auto_beam_engraver::acknowledge_element (Score_element_info info) +Auto_beam_engraver::acknowledge_grob (Grob_info info) { - if (!same_grace_state_b (info.elem_l_) || !timer_l_) - return; - if (stem_l_arr_p_) { - if (Beam *b = dynamic_cast (info.elem_l_)) + if (Beam::has_interface (info.grob_l_)) { end_beam (); } - else if (Bar *b = dynamic_cast (info.elem_l_)) + else if (Bar_line::has_interface (info.grob_l_)) { end_beam (); } - else if (Rest* rest_l = dynamic_cast (info.elem_l_)) + else if (Rest::has_interface (info.grob_l_)) { end_beam (); } } - if (Stem* stem_l = dynamic_cast (info.elem_l_)) + if (Stem::has_interface (info.grob_l_)) { - Rhythmic_req *rhythmic_req = dynamic_cast (info.req_l_); + Item* stem_l = dynamic_cast (info.grob_l_); + + Rhythmic_req *rhythmic_req = dynamic_cast (info.music_cause ()); if (!rhythmic_req) { programming_error ("Stem must have rhythmic structure"); @@ -322,21 +370,22 @@ Auto_beam_engraver::acknowledge_element (Score_element_info info) /* Don't (start) auto-beam over empty stems; skips or rests */ - if (!stem_l->head_l_arr_.size ()) + if (!Stem::heads_i (stem_l)) { if (stem_l_arr_p_) end_beam (); return; } - if (stem_l->beam_l_) + if (Stem::beam_l (stem_l)) { if (stem_l_arr_p_) junk_beam (); return ; } - int durlog =rhythmic_req->duration_.durlog_i_; + int durlog = unsmob_duration (rhythmic_req->get_mus_property ("duration"))->duration_log (); + if (durlog <= 2) { if (stem_l_arr_p_) @@ -344,62 +393,93 @@ Auto_beam_engraver::acknowledge_element (Score_element_info info) return; } + /* - if shortest duration would change - reconsider ending/starting beam first. - */ - Moment mom = rhythmic_req->duration_.length_mom (); - consider_end_and_begin (mom); - if (!stem_l_arr_p_) - return; - if (mom < shortest_mom_) + ignore grace notes. + */ + if (bool (beam_start_location_.grace_part_) != bool (now_mom ().grace_part_)) + return ; + + + Moment dur = unsmob_duration (rhythmic_req->get_mus_property ("duration"))->length_mom (); + /* FIXME: + + This comment has been here since long: + + if shortest duration would change + consider ending and beginning beam first. + + but the code didn't match: */ +#if 1 + consider_end (dur); + consider_begin (dur); + + if (dur < shortest_mom_) + shortest_mom_ = dur; +#else + /* I very much suspect that we wanted: */ + + consider_end (shortest_mom_); + if (dur < shortest_mom_) { - if (stem_l_arr_p_->size ()) - { - shortest_mom_ = mom; - consider_end_and_begin (shortest_mom_); - if (!stem_l_arr_p_) - return; - } - shortest_mom_ = mom; + shortest_mom_ = dur; + consider_end (shortest_mom_); } + consider_begin (shortest_mom_); +#endif + + if (!stem_l_arr_p_) + return; + Moment now = now_mom (); grouping_p_->add_stem (now - beam_start_moment_ + beam_start_location_, durlog - 2); stem_l_arr_p_->push (stem_l); last_add_mom_ = now; - extend_mom_ = extend_mom_ >? now + rhythmic_req->length_mom (); + extend_mom_ = (extend_mom_ >? now) + rhythmic_req->length_mom (); } } void -Auto_beam_engraver::junk_beam () +Auto_beam_engraver::create_grobs () { - assert (stem_l_arr_p_); - - delete stem_l_arr_p_; - stem_l_arr_p_ = 0; - delete grouping_p_; - grouping_p_ = 0; - shortest_mom_ = Moment (1, 8); -} - -void -Auto_beam_engraver::process_acknowledged () -{ - if (stem_l_arr_p_) + if (!count_i_) { - Moment now = now_mom (); - if ((extend_mom_ < now) - || ((extend_mom_ == now) && (last_add_mom_ != now ))) - { - end_beam (); - } - else if (!stem_l_arr_p_->size ()) + consider_end (shortest_mom_); + consider_begin (shortest_mom_); + } + else if (count_i_ > 1) + { + if (stem_l_arr_p_) { - junk_beam (); - } + Moment now = now_mom (); + if ((extend_mom_ < now) + || ((extend_mom_ == now) && (last_add_mom_ != now))) + { + end_beam (); + } + else if (!stem_l_arr_p_->size ()) + { + junk_beam (); + } + } } -} + /* + count_i_++ -> + + auto-beam-engraver.cc:459: warning: value computed is not used (gcc: 2.96) */ + count_i_ = count_i_ + 1; +} +ENTER_DESCRIPTION(Auto_beam_engraver, +/* descr */ "Generate beams based on measure characteristics and observed +Stems. Uses beatLength, measureLength and measurePosition to decide +when to start and stop a beam. Overriding beaming is done through +@ref{Stem_engraver} properties stemLeftBeamCount and +stemRightBeamCount. +", +/* creats*/ "Beam", +/* acks */ "stem-interface rest-interface beam-interface bar-line-interface", +/* reads */ "noAutoBeaming autoBeamSettings subdivideBeams", +/* write */ "");