X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Fambitus-engraver.cc;h=221c1e8881ee950c70da5af60b29f202236d30ef;hb=941dff9d2a67080e0dd8474f1e70f0c72ace6424;hp=8606e4c9c11a82adce857c2af1851bead944d442;hpb=278b8a09987a041907f1393127b61056a2a69572;p=lilypond.git diff --git a/lily/ambitus-engraver.cc b/lily/ambitus-engraver.cc index 8606e4c9c1..221c1e8881 100644 --- a/lily/ambitus-engraver.cc +++ b/lily/ambitus-engraver.cc @@ -1,15 +1,27 @@ /* - ambitus-engraver.cc -- implement Ambitus_engraver + This file is part of LilyPond, the GNU music typesetter. - source file of the GNU LilyPond music typesetter - - (c) 2002--2006 Juergen Reuter + Copyright (C) 2002--2011 Juergen Reuter Han-Wen Nienhuys . */ #include "engraver.hh" +#include "accidental-placement.hh" #include "axis-group-interface.hh" #include "item.hh" #include "note-head.hh" @@ -17,7 +29,8 @@ #include "pointer-group-interface.hh" #include "protected-scm.hh" #include "side-position-interface.hh" -#include "staff-symbol-referencer.hh" +#include "separation-item.hh" +#include "staff-symbol-referencer.hh" #include "stream-event.hh" #include "translator.icc" @@ -26,8 +39,10 @@ class Ambitus_engraver : public Engraver { public: TRANSLATOR_DECLARATIONS (Ambitus_engraver); +protected: + DECLARE_ACKNOWLEDGER (note_head); + void process_music (); - void acknowledge_note_head (Grob_info); void stop_translation_timestep (); virtual void finalize (); virtual void derived_mark () const; @@ -38,6 +53,7 @@ private: Item *group_; Drul_array heads_; Drul_array accidentals_; + Drul_array causes_; Pitch_interval pitch_interval_; bool is_typeset_; int start_c0_; @@ -65,7 +81,6 @@ Ambitus_engraver::create_ambitus () accidentals_[d]->self_scm ()); Axis_group_interface::add_element (group_, heads_[d]); Axis_group_interface::add_element (group_, accidentals_[d]); - Side_position_interface::add_support (accidentals_[d], heads_[d]); } while (flip (&d) != DOWN); @@ -78,8 +93,8 @@ Ambitus_engraver::create_ambitus () Ambitus_engraver::Ambitus_engraver () { ambitus_ = 0; - heads_[LEFT] = heads_[RIGHT] = 0; - accidentals_[LEFT] = accidentals_[RIGHT] = 0; + heads_.set (0, 0); + accidentals_.set (0, 0); group_ = 0; is_typeset_ = false; start_key_sig_ = SCM_EOL; @@ -89,10 +104,7 @@ void Ambitus_engraver::process_music () { /* - * Ensure that ambitus is created in the very first timestep (on - * which lily does not call start_translation_timestep ()). - * Otherwise, if a voice begins with a rest, the ambitus grob will - * be placed after the rest. + * Ensure that ambitus is created in the very first timestep */ if (!ambitus_) create_ambitus (); @@ -122,8 +134,19 @@ Ambitus_engraver::acknowledge_note_head (Grob_info info) Stream_event *nr = info.event_cause (); if (nr && nr->in_event_class ("note-event")) { - Pitch pitch = *unsmob_pitch (nr->get_property ("pitch")); - pitch_interval_.add_point (pitch); + SCM p = nr->get_property ("pitch"); + /* + If the engraver is added to a percussion context, + filter out unpitched note heads. + */ + if (!unsmob_pitch (p)) + return; + Pitch pitch = *unsmob_pitch (p); + Drul_array expands = pitch_interval_.add_point (pitch); + if (expands[UP]) + causes_[UP] = nr; + if (expands[DOWN]) + causes_[DOWN] = nr; } } @@ -132,13 +155,16 @@ Ambitus_engraver::finalize () { if (ambitus_ && !pitch_interval_.is_empty ()) { + Grob *accidental_placement = + make_item ("AccidentalPlacement", accidentals_[DOWN]->self_scm ()); + Direction d = DOWN; do { Pitch p = pitch_interval_[d]; + heads_[d]->set_property ("cause", causes_[d]->self_scm()); heads_[d]->set_property ("staff-position", - scm_from_int (start_c0_ - + p.steps ())); + scm_from_int (start_c0_ + p.steps ())); SCM handle = scm_assoc (scm_cons (scm_from_int (p.get_octave ()), scm_from_int (p.get_notename ())), @@ -149,23 +175,33 @@ Ambitus_engraver::finalize () start_key_sig_); Rational sig_alter = (handle != SCM_BOOL_F) - ? ly_scm2rational (scm_cdr (handle)) : Rational (0); + ? robust_scm2rational (scm_cdr (handle), Rational (0)) + : Rational (0); + + const Pitch other = pitch_interval_[-d]; - if (sig_alter == p.get_alteration ()) + if (sig_alter == p.get_alteration () + && !((p.steps () == other.steps ()) + && (p.get_alteration () != other.get_alteration ()))) { accidentals_[d]->suicide (); heads_[d]->set_object ("accidental-grob", SCM_EOL); } else - { - accidentals_[d]->set_property ("alteration", ly_rational2scm (p.get_alteration ())); - } + accidentals_[d]-> + set_property ("alteration", + ly_rational2scm (p.get_alteration ())); + Separation_item::add_conditional_item (heads_[d], + accidental_placement); + Accidental_placement::add_accidental (accidental_placement, + accidentals_[d]); + Pointer_group_interface::add_grob (ambitus_, + ly_symbol2scm ("note-heads"), + heads_[d]); } while (flip (&d) != DOWN); - - Pointer_group_interface::add_grob (ambitus_, ly_symbol2scm ("note-heads"), heads_[DOWN]); - Pointer_group_interface::add_grob (ambitus_, ly_symbol2scm ("note-heads"), heads_[UP]); + Axis_group_interface::add_element (group_, accidental_placement); } else { @@ -174,7 +210,7 @@ Ambitus_engraver::finalize () { accidentals_[d]->suicide (); heads_[d]->suicide (); - } + } while (flip (&d) != DOWN); ambitus_->suicide (); @@ -183,11 +219,20 @@ Ambitus_engraver::finalize () ADD_ACKNOWLEDGER (Ambitus_engraver, note_head); ADD_TRANSLATOR (Ambitus_engraver, - /* doc */ "", + /* doc */ + "Create an ambitus.", + /* create */ + "AccidentalPlacement " "Ambitus " + "AmbitusAccidental " "AmbitusLine " - "AmbitusNoteHead " - "AmbitusAccidental", - /* read */ "", - /* write */ ""); + "AmbitusNoteHead ", + + /* read */ + "keySignature " + "middleCPosition ", + + /* write */ + "" + );