X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Falign-interface.cc;h=7f7b9c3cf645a9eb8df727129309f1039a29335d;hb=5b4b0d6e9a197e8f9eb085b7c2ad78b8be3e5cfc;hp=057e233f443d6522ddf4bddc5d74b7a515881dde;hpb=8927024a06dccf738135319434199cdba64dfab9;p=lilypond.git diff --git a/lily/align-interface.cc b/lily/align-interface.cc index 057e233f44..7f7b9c3cf6 100644 --- a/lily/align-interface.cc +++ b/lily/align-interface.cc @@ -3,7 +3,7 @@ source file of the GNU LilyPond music typesetter - (c) 2000--2007 Han-Wen Nienhuys + (c) 2000--2008 Han-Wen Nienhuys */ #include "align-interface.hh" @@ -91,37 +91,13 @@ get_skylines (Grob *me, bool pure, int start, int end, vector *const ret) { - /* each child's skyline was calculated according to the common refpoint of its - elements. Here we need all the skylines to be positioned with respect to - a single refpoint, so we need the common refpoint of the common refpoints - of the elements of the children */ - vector child_refpoints; - for (vsize i = 0; i < elements->size (); i++) - { - Grob *elt = (*elements)[i]; - Grob *child_common = unsmob_grob ((a == Y_AXIS) - ? elt->get_object ("X-common") - : elt->get_object ("Y-common")); - - if (!child_common) - { - extract_grob_set (elt, "elements", child_elts); - child_common = common_refpoint_of_array (child_elts, elt, other_axis (a)); - } - - child_refpoints.push_back (child_common); - } - - Grob *other_common = common_refpoint_of_array (child_refpoints, me, other_axis (a)); + Grob *other_common = common_refpoint_of_array (*elements, me, other_axis (a)); for (vsize i = elements->size (); i--;) { Grob *g = (*elements)[i]; Skyline_pair skylines; - /* each skyline is calculated relative to (potentially) a different other_axis - coordinate. In order to compare the skylines effectively, we need to shift them - to some absolute reference point */ if (!pure) { Skyline_pair *skys = Skyline_pair::unsmob (g->get_property (a == Y_AXIS @@ -147,7 +123,10 @@ get_skylines (Grob *me, skylines.insert (b, 0, other_axis (a)); } - Real offset = child_refpoints[i]->relative_coordinate (other_common, other_axis (a)); + /* This skyline was calculated relative to the grob g. In order to compare it to + skylines belonging to other grobs, we need to shift it so that it is relative + to the common reference. */ + Real offset = g->relative_coordinate (other_common, other_axis (a)); skylines.shift (offset); } else @@ -403,7 +382,7 @@ ADD_INTERFACE (Align_interface, "Order grobs from top to bottom, left to right, right to left" " or bottom to top. For vertical alignments of staves, the" " @code{break-system-details} of the left" - " @internalsref{NonMusicalPaperColumn} may be set to tune" + " @rinternals{NonMusicalPaperColumn} may be set to tune" " vertical spacing. Set @code{alignment-extra-space} to add" " extra space for staves. Set" " @code{fixed-alignment-extra-space} to force staves in"