X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=lily%2Faccidental-engraver.cc;h=f4c2abdde378841596059c1fc5a62bb16798fa09;hb=1f73f2bb12134ca02a76b2381984d27ee3a0bb86;hp=4558ff33939bbf87e411f87a2279acba5a5b4468;hpb=75eebcb49e52d296b1da3e1074e0825d2c780db4;p=lilypond.git diff --git a/lily/accidental-engraver.cc b/lily/accidental-engraver.cc index 4558ff3393..f4c2abdde3 100644 --- a/lily/accidental-engraver.cc +++ b/lily/accidental-engraver.cc @@ -9,15 +9,18 @@ #include "accidental-placement.hh" #include "arpeggio.hh" +#include "spanner.hh" #include "context.hh" +#include "item.hh" #include "engraver.hh" +#include "international.hh" +#include "pitch.hh" #include "protected-scm.hh" #include "rhythmic-head.hh" #include "side-position-interface.hh" +#include "stream-event.hh" #include "tie.hh" #include "warn.hh" -#include "music.hh" -#include "pitch.hh" #include "translator.icc" @@ -25,7 +28,7 @@ class Accidental_entry { public: bool done_; - Music *melodic_; + Stream_event *melodic_; Grob *accidental_; Context *origin_; Engraver *origin_engraver_; @@ -50,8 +53,8 @@ class Accidental_engraver : public Engraver int get_bar_number (); void update_local_key_signature (); void create_accidental (Accidental_entry *entry, bool, bool); - Grob *make_standard_accidental (Music *note, Grob *note_head, Engraver *trans); - Grob *make_suggested_accidental (Music *note, Grob *note_head, Engraver *trans); + Grob *make_standard_accidental (Stream_event *note, Grob *note_head, Engraver *trans); + Grob *make_suggested_accidental (Stream_event *note, Grob *note_head, Engraver *trans); protected: TRANSLATOR_DECLARATIONS (Accidental_engraver); @@ -76,13 +79,13 @@ public: to store all information before we can really create the accidentals. */ - Link_array left_objects_; - Link_array right_objects_; + vector left_objects_; + vector right_objects_; Grob *accidental_placement_; - Array accidentals_; - Link_array ties_; + vector accidentals_; + vector ties_; }; /* @@ -119,8 +122,7 @@ Accidental_engraver::update_local_key_signature () /* Huh. Don't understand what this is good for. --hwn. */ - SCM val; - while (trans && trans->where_defined (ly_symbol2scm ("localKeySignature"), &val)) + while (trans) { trans->set_property ("localKeySignature", ly_deep_copy (last_keysig_)); trans = trans->get_parent_context (); @@ -191,10 +193,14 @@ number_accidentals_from_sig (bool *different, SCM sig, Pitch *pitch, SCM entry = scm_car (s); if (scm_is_pair (scm_car (entry)) && scm_cdar (entry) == scm_from_int (n)) - from_other_octaves = scm_cdr (entry); + { + from_other_octaves = scm_cdr (entry); + break; + } } - if (from_same_octave != SCM_BOOL_F + if (!ignore_octave + && from_same_octave != SCM_BOOL_F && recent_enough (bar_number, from_same_octave, laziness)) previous_alteration = from_same_octave; else if (ignore_octave @@ -235,7 +241,7 @@ number_accidentals (bool *different, *different = false; if (scm_is_pair (accidentals) && !scm_is_symbol (scm_car (accidentals))) warning (_f ("accidental typesetting list must begin with context-name: %s", - ly_scm2string (scm_car (accidentals)).to_str0 ())); + ly_scm2string (scm_car (accidentals)).c_str ())); for (; scm_is_pair (accidentals) && origin; accidentals = scm_cdr (accidentals)) @@ -263,7 +269,7 @@ number_accidentals (bool *different, } else warning (_f ("ignoring unknown accidental: %s", - ly_symbol2string (type).to_str0 ())); + ly_symbol2string (type).c_str ())); } /* if symbol then it is a context name. Scan parent contexts to @@ -279,7 +285,7 @@ number_accidentals (bool *different, } else warning (_f ("pair or context-name expected for accidental rule, found %s", - ly_scm2string (rule).to_str0 ())); + ly_scm2string (rule).c_str ())); } return number; @@ -288,7 +294,7 @@ number_accidentals (bool *different, int Accidental_engraver::get_bar_number () { - SCM barnum = get_property ("currentBarNumber"); + SCM barnum = get_property ("internalBarNumber"); SCM smp = get_property ("measurePosition"); int bn = robust_scm2int (barnum, 0); @@ -303,19 +309,19 @@ Accidental_engraver::get_bar_number () void Accidental_engraver::process_acknowledged () { - if (accidentals_.size () && !accidentals_.top ().done_) + if (accidentals_.size () && !accidentals_.back ().done_) { SCM accidentals = get_property ("autoAccidentals"); SCM cautionaries = get_property ("autoCautionaries"); int barnum = get_bar_number (); - for (int i = 0; i < accidentals_.size (); i++) + for (vsize i = 0; i < accidentals_.size (); i++) { if (accidentals_[i].done_) continue; accidentals_[i].done_ = true; - Music *note = accidentals_[i].melodic_; + Stream_event *note = accidentals_[i].melodic_; Context *origin = accidentals_[i].origin_; Pitch *pitch = unsmob_pitch (note->get_property ("pitch")); @@ -332,8 +338,8 @@ Accidental_engraver::process_acknowledged () pitch, origin, cautionaries, barnum); - bool cautionary = to_boolean (note->get_property ("cautionary")); + bool cautionary = to_boolean (note->get_property ("cautionary")); if (num_caut > num) { num = num_caut; @@ -341,13 +347,19 @@ Accidental_engraver::process_acknowledged () cautionary = true; } - if (num == 0 && to_boolean (note->get_property ("force-accidental"))) + bool forced = to_boolean (note->get_property ("force-accidental")); + if (num == 0 && forced) num = 1; /* Cannot look for ties: it's not guaranteed that they reach us before the notes. */ - if (num) + if (num + && !note->in_event_class ("trill-span-event")) create_accidental (&accidentals_[i], num > 1, cautionary); + + + if (forced || cautionary) + accidentals_[i].accidental_->set_property ("forced", SCM_BOOL_T); } } } @@ -357,7 +369,7 @@ Accidental_engraver::create_accidental (Accidental_entry *entry, bool restore_natural, bool cautionary) { - Music *note = entry->melodic_; + Stream_event *note = entry->melodic_; Grob *support = entry->head_; Pitch *pitch = unsmob_pitch (note->get_property ("pitch")); @@ -385,53 +397,54 @@ Accidental_engraver::create_accidental (Accidental_entry *entry, } Grob * -Accidental_engraver::make_standard_accidental (Music *note, - Grob *support, +Accidental_engraver::make_standard_accidental (Stream_event *note, + Grob *note_head, Engraver *trans) { + (void)note; /* We construct the accidentals at the originating Voice level, so that we get the property settings for Accidental from the respective Voice. */ - Grob *a - = make_grob_from_properties (trans, - ly_symbol2scm ("Accidental"), - note->self_scm (), - "Accidental"); + Grob *a = trans->make_item ("Accidental", note_head->self_scm ()); /* We add the accidentals to the support of the arpeggio, so it is put left of the accidentals. */ - for (int i = 0; i < left_objects_.size (); i++) - Side_position_interface::add_support (left_objects_[i], a); - for (int i = 0; i < right_objects_.size (); i++) + for (vsize i = 0; i < left_objects_.size (); i++) + { + if (left_objects_[i]->get_property ("side-axis") == scm_from_int (X_AXIS)) + Side_position_interface::add_support (left_objects_[i], a); + } + + /* + Hmm. Junkme? + */ + for (vsize i = 0; i < right_objects_.size (); i++) Side_position_interface::add_support (a, right_objects_[i]); - a->set_parent (support, Y_AXIS); + a->set_parent (note_head, Y_AXIS); if (!accidental_placement_) accidental_placement_ = make_item ("AccidentalPlacement", a->self_scm ()); Accidental_placement::add_accidental (accidental_placement_, a); - support->set_object ("accidental-grob", a->self_scm ()); + note_head->set_object ("accidental-grob", a->self_scm ()); return a; } Grob * -Accidental_engraver::make_suggested_accidental (Music *note, - Grob *note_head, Engraver *trans) +Accidental_engraver::make_suggested_accidental (Stream_event *note, + Grob *note_head, + Engraver *trans) { - - Grob *a - = make_grob_from_properties (trans, - ly_symbol2scm ("AccidentalSuggestion"), - note->self_scm (), - "AccidentalSuggestion"); + (void) note; + Grob *a = trans->make_item ("AccidentalSuggestion", note_head->self_scm ()); Side_position_interface::add_support (a, note_head); if (Grob *stem = unsmob_grob (a->get_object ("stem"))) @@ -450,10 +463,10 @@ Accidental_engraver::finalize () void Accidental_engraver::stop_translation_timestep () { - for (int j = ties_.size (); j--;) + for (vsize j = ties_.size (); j--;) { Grob *r = Tie::head (ties_[j], RIGHT); - for (int i = accidentals_.size (); i--;) + for (vsize i = accidentals_.size (); i--;) if (accidentals_[i].head_ == r) { if (Grob *g = accidentals_[i].accidental_) @@ -461,16 +474,16 @@ Accidental_engraver::stop_translation_timestep () g->set_object ("tie", ties_[j]->self_scm ()); accidentals_[i].tied_ = true; } - ties_.del (j); + ties_.erase (ties_.begin () + j); break; } } - for (int i = accidentals_.size (); i--;) + for (vsize i = accidentals_.size (); i--;) { int barnum = get_bar_number (); - Music *note = accidentals_[i].melodic_; + Stream_event *note = accidentals_[i].melodic_; Context *origin = accidentals_[i].origin_; Pitch *pitch = unsmob_pitch (note->get_property ("pitch")); @@ -526,12 +539,13 @@ Accidental_engraver::stop_translation_timestep () void Accidental_engraver::acknowledge_rhythmic_head (Grob_info info) { - Music *note = info.music_cause (); + Stream_event *note = info.event_cause (); if (note - && note->is_mus_type ("note-event")) + && (note->in_event_class ("note-event") + || note->in_event_class ("trill-span-event"))) { /* - String harmonics usually don't have accidentals. + string harmonics usually don't have accidentals. */ if (to_boolean (get_property ("harmonicAccidentals")) || !ly_is_equal (info.grob ()->get_property ("style"), @@ -543,7 +557,7 @@ Accidental_engraver::acknowledge_rhythmic_head (Grob_info info) entry.origin_ = entry.origin_engraver_->context (); entry.melodic_ = note; - accidentals_.push (entry); + accidentals_.push_back (entry); } } } @@ -551,19 +565,19 @@ Accidental_engraver::acknowledge_rhythmic_head (Grob_info info) void Accidental_engraver::acknowledge_tie (Grob_info info) { - ties_.push (dynamic_cast (info.grob ())); + ties_.push_back (dynamic_cast (info.grob ())); } void Accidental_engraver::acknowledge_arpeggio (Grob_info info) { - left_objects_.push (info.grob ()); + left_objects_.push_back (info.grob ()); } void Accidental_engraver::acknowledge_finger (Grob_info info) { - left_objects_.push (info.grob ()); + left_objects_.push_back (info.grob ()); } void @@ -582,6 +596,7 @@ ADD_ACKNOWLEDGER (Accidental_engraver, rhythmic_head); ADD_ACKNOWLEDGER (Accidental_engraver, tie); ADD_TRANSLATOR (Accidental_engraver, + "Make accidentals. " "Catch note heads, ties and notices key-change events. " "This engraver usually lives at Staff level, but " @@ -589,10 +604,9 @@ ADD_TRANSLATOR (Accidental_engraver, "so you can @code{\\override} them at @code{Voice}. ", "Accidental AccidentalSuggestion", - "", - "autoAccidentals " "autoCautionaries " + "internalBarNumber " "extraNatural " "harmonicAccidentals " "localKeySignature",