X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=keyboards%2Finfinity60%2Fled_controller.c;h=f319f8c68830b355f9527933d30de58ad0c50cd5;hb=58898f77e311588e15f78d3f6ed829b6010055d9;hp=eb3ccafc116a3acd7ec4c6cbfcb264b48b36d197;hpb=1b1adf35bb746a875c2b846e1b1b405075c94847;p=qmk_firmware.git

diff --git a/keyboards/infinity60/led_controller.c b/keyboards/infinity60/led_controller.c
index eb3ccafc1..f319f8c68 100644
--- a/keyboards/infinity60/led_controller.c
+++ b/keyboards/infinity60/led_controller.c
@@ -1,5 +1,6 @@
 /*
 Copyright 2016 flabbergast <s3+flabbergast@sdfeu.org>
+Copyright 2017 jpetermans <tibcmhhm@gmail.com>
 
 This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
@@ -17,7 +18,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 /*
  * LED controller code
- * WF uses IS31FL3731C matrix LED driver from ISSI
+ * IS31FL3731C matrix LED driver from ISSI
  * datasheet: http://www.issi.com/WW/pdf/31FL3731C.pdf
  */
 
@@ -25,6 +26,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "hal.h"
 #include "print.h"
 #include "led.h"
+#include "host.h"
 
 #include "led_controller.h"
 
@@ -54,9 +56,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
     order same as above (CA 1st row (8bytes), CB 1st row (8bytes), ...)
 */
 
-/* Which LED should be used for CAPS LOCK indicator
- * The usual Caps Lock position is C4-6, so the address is
- * 0x24 + (4-1)*0x10 + (8-1) = 0x59 */
+// Which LED should be used for CAPS LOCK indicator
 #if !defined(CAPS_LOCK_LED_ADDRESS)
 #define CAPS_LOCK_LED_ADDRESS 46
 #endif
@@ -88,7 +88,6 @@ uint8_t rx[1] __attribute__((aligned(2)));
 uint8_t full_page[0xB4+1] = {0};
 
 // LED mask (which LEDs are present, selected by bits)
-// See page comment above, control alternates CA matrix/CB matrix
 // IC60 pcb uses only CA matrix.
 // Each byte is a control pin for 8 leds ordered 8-1
 const uint8_t all_on_leds_mask[0x12] = {
@@ -146,16 +145,19 @@ void is31_init(void) {
   palSetPad(GPIOB, 16);
   chThdSleepMilliseconds(10);
   // software shutdown
-  is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, 0);
+  is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_ON);
+  chThdSleepMilliseconds(10);
+  // zero function page, all registers
+  is31_write_data(IS31_FUNCTIONREG, full_page, 0xD + 1);
   chThdSleepMilliseconds(10);
   // software shutdown disable (i.e. turn stuff on)
-  is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_ON);
+  is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_OFF);
   chThdSleepMilliseconds(10);
   // zero all LED registers on all 8 pages
   uint8_t i;
   for(i=0; i<8; i++) {
     is31_write_data(i, full_page, 0xB4 + 1);
-    chThdSleepMilliseconds(1);
+    chThdSleepMilliseconds(5);
   }
 }
 
@@ -170,286 +172,274 @@ static THD_FUNCTION(LEDthread, arg) {
   (void)arg;
   chRegSetThreadName("LEDthread");
 
-  uint8_t i, page;
-  uint8_t control_register_word[2] = {0};
+  uint8_t i;
+  uint8_t control_register_word[2] = {0};//2 bytes: register address, byte to write
   uint8_t led_control_reg[0x13] = {0};//led control register start address + 0x12 bytes
 
   //persistent status variables
-  uint8_t backlight_status, led_step_status, layer_status;
+  uint8_t pwm_step_status, page_status, capslock_status, numlock_status;
 
   //mailbox variables
-  uint8_t temp, msg_type, msg_led;
+  uint8_t temp, msg_type;
+  uint8_t msg_args[3];
   msg_t msg;
 
-/*  //control register variables
-  uint8_t page, save_page, save_breath1, save_breath2;
-  msg_t msg, retval;
-*/
-
-// initialize persistent variables
-backlight_status = 0;
-led_step_status = 4; //full brightness
-layer_status = 0;
+  // initialize persistent variables
+  pwm_step_status = 4; //full brightness
+  page_status = 0; //start frame 0 (all off/on)
+  numlock_status = (host_keyboard_leds() & (1<<USB_LED_NUM_LOCK)) ? 1 : 0;
+  capslock_status = (host_keyboard_leds() & (1<<USB_LED_CAPS_LOCK)) ? 1 : 0;
 
   while(true) {
     // wait for a message (asynchronous)
     // (messages are queued (up to LED_MAILBOX_NUM_MSGS) if they can't
-    //  be processed right away)
+    //  be processed right away
     chMBFetch(&led_mailbox, &msg, TIME_INFINITE);
-    msg_type = (msg >> 8) & 0xFF; //first byte is msg type
-    msg_led = (msg) & 0xFF; //second byte is action information
-
-    xprintf("--------------------\n");
-    xprintf("mailbox fetch\nmsg: %X\n", msg);
-    xprintf("type: %X - led: %X\n", msg_type, msg_led); //test if msg_type is 1 or 2 bytes after mask
-  switch (msg_type){
-    case KEY_LIGHT:
-    //TODO: lighting key led on keypress
-    break;
-    
-    //turn on/off/toggle single led, msg_led = row/col of led
-    case OFF_LED:      
-    xprintf("OFF_LED\n");
-      set_led_bit(7, control_register_word, msg_led, 0);
-      is31_write_data (7, control_register_word, 0x02);
-      if (layer_status > 0) {//check current led page to prevent double blink
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 7);
-      }
-      layer_status = 7;
-      break;
-    case ON_LED:      
-    xprintf("ON_LED\n");
-      set_led_bit(7, control_register_word, msg_led, 1);
-      is31_write_data (7, control_register_word, 0x02);
-      if (layer_status > 7) {
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 7);
-      }
-      layer_status = 7;
-      break;
-    case TOGGLE_LED:      
-    xprintf("TOGGLE_LED\n");
-      set_led_bit(7, control_register_word, msg_led, 2);
-
-      is31_write_data (7, control_register_word, 0x02);
-      if (layer_status > 7) {
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 7);
-      }
-      layer_status = 7;
-      break;
+    msg_type = msg & 0xFF; //first byte is action information
+    msg_args[0] = (msg >> 8) & 0xFF;
+    msg_args[1] = (msg >> 16) & 0XFF;
+    msg_args[2] = (msg >> 24) & 0xFF;
 
-    case TOGGLE_ALL:
-    xprintf("TOGGLE_ALL\n");
-      //msg_led = unused, TODO: consider using msg_led to toggle layer display
 
-      is31_read_register(0, 0x00, &temp);//if first byte is on, then toggle frame 1 off
+    switch (msg_type){
+      case SET_FULL_ROW:
+      //write full byte to pin address, msg_args[1] = pin #, msg_args[0] = 8 bits to write
+      //writes only to currently displayed page
+        write_led_byte(page_status, msg_args[1], msg_args[0]);
+        break;
 
-      led_control_reg[0] = 0;
-      if (temp==0) {
-    xprintf("all leds on");
-        __builtin_memcpy(led_control_reg+1, all_on_leds_mask, 0x12);
-      } else {
-    xprintf("all leds off");
-        __builtin_memset(led_control_reg+1, 0, 0x12);
-      }
-
-      is31_write_data(0, led_control_reg, 0x13);
-      if (layer_status > 0) {
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 0);
-      }
-      layer_status=0;
-      //TODO: Double blink when all on
-      break;
+      case OFF_LED:
+      //on/off/toggle single led, msg_args[0] = row/col of led, msg_args[1] = page
+        set_led_bit(msg_args[1], control_register_word, msg_args[0], 0);
+        break;
+      case ON_LED:
+        set_led_bit(msg_args[1], control_register_word, msg_args[0], 1);
+        break;
+      case TOGGLE_LED:
+        set_led_bit(msg_args[1], control_register_word, msg_args[0], 2);
+        break;
 
-    case TOGGLE_BACKLIGHT:
-      //msg_led = unused
-      //TODO: consider Frame 0 as on/off layer and toggle led control register here
-      //TODO: need to test tracking of active layer with layer_state from qmk
-    xprintf("TOGGLE_BACKLIGHT\n");
-      backlight_status ^= 1;
-      is31_read_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, &temp);
-      layer_status = temp;
-
-      page = backlight_status == 0 ? 0 : layer_status;
-      is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, page);
-      break;
+      case BLINK_OFF_LED:
+      //on/off/toggle single led, msg_args[0] = row/col of led
+        set_led_bit(msg_args[1], control_register_word, msg_args[0], 4);
+        break;
+      case BLINK_ON_LED:
+        set_led_bit(msg_args[1], control_register_word, msg_args[0], 5);
+        break;
+      case BLINK_TOGGLE_LED:
+        set_led_bit(msg_args[1], control_register_word, msg_args[0], 6);
+        break;
 
-    case TOGGLE_LAYER_LEDS://show layer indicator or full map of layer keys.
-      //TODO: change so user can flag which they want, indiv or full map in fn_actions
-      //msg_led = layer to toggle on
-    xprintf("TOGGLE_LAYER_LEDS\n");
-      is31_read_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, &temp);
-
-      if(temp == msg_led) {
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 7);
-        layer_status = 7;
-      } else {
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, msg_led);
-        layer_status = msg_led;
-      }
-      break;
-      
-    case TOGGLE_NUM_LOCK:
-      //msg_led = 0 or 1, off/on
-      //TODO: confirm toggling works and doesn't get out of sync
-      set_lock_leds(USB_LED_NUM_LOCK, msg_led);
-      break;
-    
-    case TOGGLE_CAPS_LOCK:
-      //msg_led = 0 or 1, off/on
-      //TODO: confirm toggling works and doesn't get out of sync
-      set_lock_leds(USB_LED_CAPS_LOCK, msg_led);
-      break;
+      case TOGGLE_ALL:
+      //turn on/off all leds, msg_args = unused
+        is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_ON);
+        chThdSleepMilliseconds(5);
+        is31_read_register(0, 0x00, &temp);
+        is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_OFF);
 
-    case MODE_BREATH:
-      break;
-    case STEP_BRIGHTNESS:
-      //TEST: Step brightness code
-      //pwm_levels[] bounds checking, loop through array
-      //TODO: find a cleaner way to walk through this logic
-      if (msg_led == 0 && led_step_status == 0) {
-        led_step_status = 4;
-      } else {
-        led_step_status--;
-      }
-      
-      if (msg_led == 1 && led_step_status == 4) {
-        led_step_status = 0;
-      } else {
-        led_step_status++;
-      }
-
-      //TODO: this seems a messy way to populate the pwm register
-      //mimic whitefox init which uses memcpy
-      //populate the 9 byte rows to be written to each pin, first byte is register (pin) address
-      for(i=1; i<9; i++) {
-        pwm_register_array[i]=pwm_levels[led_step_status]; 
-      }
-      for(i=0; i<8; i++) {
-        pwm_register_array[0] = 0x24 + (i * 0x10);//first byte of 9 bytes must be register address
-        is31_write_data(0, pwm_register_array, 9);//first page controls pwm in all pages (init Display Option register)
-      }
-      break;
+        led_control_reg[0] = 0;
+
+        //toggle led mask based on current state (temp)
+        if (temp==0 || page_status > 0) {
+          __builtin_memcpy(led_control_reg+1, all_on_leds_mask, 0x12);
+        } else {
+          __builtin_memset(led_control_reg+1, 0, 0x12);
+        }
+        is31_write_data(0, led_control_reg, 0x13);
+
+        if (page_status > 0) {
+          is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 0);
+
+          page_status=0;
 
-/*      case LED_MSG_SLEEP_LED_ON:
-        // save current settings
-        is31_read_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, &save_page);
-        is31_read_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL1, &save_breath1);
-        is31_read_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL2, &save_breath2);
-        // use pages 7 and 8 for (hardware) breathing (assuming they're empty)
-        is31_write_register(6, BREATHE_LED_ADDRESS, 0xFF);
-        is31_write_register(7, BREATHE_LED_ADDRESS, 0x00);
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL1, (6<<4)|6);
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL2, IS31_REG_BREATHCTRL2_ENABLE|3);
-        retval = MSG_TIMEOUT;
-        temp = 6;
-        while(retval == MSG_TIMEOUT) {
-          // switch to the other page
-          is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, temp);
-          temp = (temp == 6 ? 7 : 6);
-          // the times should be sufficiently long for IS31 to finish switching pages
-          retval = chMBFetch(&led_mailbox, &msg, MS2ST(temp == 6 ? 4000 : 6000));
+          //maintain lock leds, reset to off and force recheck to blink of all leds toggled on
+          numlock_status = 0;
+          capslock_status = 0;
+          led_set(host_keyboard_leds());
         }
-        // received a message (should be a wakeup), so restore previous state
-        chThdSleepMilliseconds(3000); // need to wait until the page change finishes
-        // note: any other messages are queued
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL1, save_breath1);
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL2, save_breath2);
-        is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, save_page);
         break;
-      case LED_MSG_SLEEP_LED_OFF: 
-        // should not get here; wakeup should be received in the branch above break;
+
+      case TOGGLE_BACKLIGHT:
+        //msg_args[0] = on/off
+
+        //populate 9 byte rows to be written to each pin, first byte is register (pin) address
+        if (msg_args[0] == 1) {
+          __builtin_memset(pwm_register_array+1, pwm_levels[pwm_step_status], 8);
+        } else {
+          __builtin_memset(pwm_register_array+1, 0, 8);
+        }
+
+        for(i=0; i<8; i++) {
+        //first byte is register address, every 0x10 9 bytes is A-matrix pwm pins
+          pwm_register_array[0] = 0x24 + (i * 0x10);
+          is31_write_data(0,pwm_register_array,9);
+        }
+        break;
+
+      case DISPLAY_PAGE:
+      //msg_args[0] = page to toggle on
+        if (page_status != msg_args[0]) {
+          is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, msg_args[0]);
+          page_status = msg_args[0];
+
+          //maintain lock leds, reset to off and force recheck for new page
+          numlock_status = 0;
+          capslock_status = 0;
+          led_set(host_keyboard_leds());
+        }
+        break;
+
+      case RESET_PAGE:
+      //led_args[0] = page to reset
+        led_control_reg[0] = 0;
+        __builtin_memset(led_control_reg+1, 0, 0x12);
+        is31_write_data(msg_args[0], led_control_reg, 0x13);
+
+        //repeat for blink register
+        led_control_reg[0] = 0x12;
+        is31_write_data(msg_args[0], led_control_reg, 0x13);
+        break;
+
+      case TOGGLE_NUM_LOCK:
+      //msg_args[0] = 0 or 1, off/on
+        if (numlock_status != msg_args[0]) {
+          set_lock_leds(NUM_LOCK_LED_ADDRESS, msg_args[0], page_status);
+          numlock_status = msg_args[0];
+        }
+        break;
+      case TOGGLE_CAPS_LOCK:
+      //msg_args[0] = 0 or 1, off/on
+        if (capslock_status != msg_args[0]) {
+          set_lock_leds(CAPS_LOCK_LED_ADDRESS, msg_args[0], page_status);
+          capslock_status = msg_args[0];
+        }
+        break;
+
+      case STEP_BRIGHTNESS:
+      //led_args[0] = step up (1) or down (0)
+        switch (msg_args[0]) {
+          case 0:
+            if (pwm_step_status == 0) {
+              pwm_step_status = 4;
+            } else {
+              pwm_step_status--;
+            }
+            break;
+
+          case 1:
+            if (pwm_step_status == 4) {
+              pwm_step_status = 0;
+            } else {
+              pwm_step_status++;
+            }
+            break;
+        }
+
+        //populate 8 byte arrays to write on each pin
+        //first byte is register address, every 0x10 9 bytes are A-matrix pwm pins
+        __builtin_memset(pwm_register_array+1, pwm_levels[pwm_step_status], 8);
+
+        for(i=0; i<8; i++) {
+          pwm_register_array[0] = 0x24 + (i * 0x10);
+          is31_write_data(0,pwm_register_array,9);
+        }
         break;
-*/
     }
-    xprintf("--------------------\n");
   }
 }
 
-
 /* ==============================
  *    led processing functions
  * ============================== */
 
-void set_led_bit (uint8_t page, uint8_t *led_control_reg, uint8_t led_addr, uint8_t action) {
-  //returns 2 bytes led control register address and byte mask to write
+void set_led_bit (uint8_t page, uint8_t *led_control_word, uint8_t led_addr, uint8_t action) {
+  //returns 2 bytes: led control register address and byte to write
+  //action: 0 - off, 1 - on, 2 - toggle, 4 - blink on, 5 - blink off, 6 - toggle blink
 
-  uint8_t control_reg_addr, column_bit, column_byte, temp;
-  //first byte is led control register address 0x00
-  //msg_led tens column is pin#, ones column is bit position in 8-bit mask
-  control_reg_addr = ((led_addr / 10) % 10 - 1 ) * 0x02;// A-register is every other byte
-  column_bit = 1<<(led_addr % 10 - 1);
+  uint8_t control_reg_addr, column_bit, column_byte, temp, blink_bit;
+
+  //check for valid led address
+  if (led_addr < 0 || led_addr > 87 || led_addr % 10 > 8) {
+    return;
+  }
+
+  blink_bit = action>>2;//check for blink bit
+  action &= ~(1<<2); //strip blink bit
 
-  is31_read_register(page,control_reg_addr,&temp);//need to maintain status of leds in this row (1 byte)
+  //led_addr tens column is pin#, ones column is bit position in 8-bit mask
+  control_reg_addr = ((led_addr / 10) % 10 - 1 ) * 0x02;// A-matrix is every other byte
+  control_reg_addr += blink_bit == 1 ? 0x12 : 0x00;//if blink_bit, shift 12 bytes to blink register
+
+  is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_ON);
+  chThdSleepMilliseconds(5);
+  is31_read_register(page, control_reg_addr, &temp);//maintain status of leds on this byte
+  is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_OFF);
+
+  column_bit = 1<<(led_addr % 10 - 1);
   column_byte = temp;
 
   switch(action) {
     case 0:
-      column_byte &= ~1<<(column_bit);
+      column_byte &= ~column_bit;
       break;
     case 1:
-      column_byte |= 1<<(column_bit);
+      column_byte |= column_bit;
       break;
     case 2:
-      column_byte ^= 1<<(column_bit);
+      column_byte ^= column_bit;
       break;
   }
 
-  led_control_reg[0] = control_reg_addr;
-  led_control_reg[1] = column_byte;
+  //return word to be written in register
+  led_control_word[0] = control_reg_addr;
+  led_control_word[1] = column_byte;
+  is31_write_data (page, led_control_word, 0x02);
 }
 
-void set_lock_leds(uint8_t lock_type, uint8_t led_on) {
-  uint8_t page, led_addr;
-  uint8_t led_control_write[2] = {0};
-  //TODO: consolidate control register to top level array vs. three scattered around
-
-  switch(lock_type) {
-      case USB_LED_NUM_LOCK:
-          led_addr = NUM_LOCK_LED_ADDRESS;
-          break;
-      case USB_LED_CAPS_LOCK:
-          led_addr = CAPS_LOCK_LED_ADDRESS;
-          break;
-      #ifdef SCROLL_LOCK_LED_ADDRESS
-      case USB_LED_SCROLL_LOCK:
-          led_addr = SCROLL_LOCK_LED_ADDRESS;
-          break;
-      #endif
-      #ifdef COMPOSE_LED_ADDRESS
-      case USB_LED_COMPOSE:
-          led_addr = COMPOSE_LED_ADDRESS;
-          break;
-      #endif
-      #ifdef SCROLL_LOCK_LED_ADDRESS
-      case USB_LED_KANA:
-          led_addr = KANA_LED_ADDRESS;
-          break;
-      #endif
-  }          
-
-  for(page=BACKLIGHT_OFF_LOCK_LED_OFF; page<8; page++) { //set in led_controller.h
-  //TODO: check if frame2 (or frame1, first byte all on), and ignore if true
-  //also if BACKLIGHT_OFF_LOCK_LED_OFF set
-    set_led_bit(page,led_control_write,led_addr,led_on);
-    is31_write_data (page, led_control_write, 0x02);
-  }
+void write_led_byte (uint8_t page, uint8_t row, uint8_t led_byte) {
+  uint8_t led_control_word[2] = {0};//register address and on/off byte
+
+  led_control_word[0] = (row - 1 ) * 0x02;// A-matrix is every other byte
+  led_control_word[1] = led_byte;
+  is31_write_data(page, led_control_word, 0x02);
 }
 
-void write_led_page (uint8_t page, const uint8_t *led_array, uint8_t led_count) {
+void write_led_page (uint8_t page, uint8_t *user_led_array, uint8_t led_count) {
   uint8_t i;
-  uint8_t row, col;
-  uint8_t led_control_register[0x13] = {0};//led control register start address + 0x12 bytes
+  uint8_t pin, col;
+  uint8_t led_control_register[0x13] = {0};
+
+  __builtin_memset(led_control_register,0,13);
 
   for(i=0;i<led_count;i++){
-    row = ((led_array[i] / 10) % 10 - 1 ) * 2 + 1;//includes 1 byte shift for led register 0x00 address
-    col = led_array[i] % 10 - 1;
-    
-    led_control_register[row] |= 1<<(col);
+    //shift pin by 1 for led register 0x00 address
+    pin = ((user_led_array[i] / 10) % 10 - 1 ) * 2 + 1;
+    col = user_led_array[i] % 10 - 1;
+    led_control_register[pin] |= 1<<(col);
   }
 
   is31_write_data(page, led_control_register, 0x13);
 }
 
+void set_lock_leds(uint8_t led_addr, uint8_t led_action, uint8_t page) {
+  uint8_t temp;
+  uint8_t led_control_word[2] = {0};
+
+  //blink if all leds are on
+  if (page == 0) {
+    is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_ON);
+    chThdSleepMilliseconds(5);
+    is31_read_register(0, 0x00, &temp);
+    is31_write_register(IS31_FUNCTIONREG, IS31_REG_SHUTDOWN, IS31_REG_SHUTDOWN_OFF);
+
+    if (temp == 0xFF) {
+      led_action |= (1<<2); //set blink bit
+    }
+  }
+
+  set_led_bit(page,led_control_word,led_addr,led_action);
+}
+
 /* =====================
  * hook into user keymap
  * ===================== */
@@ -472,63 +462,26 @@ void led_controller_init(void) {
   /* initialise IS31 chip */
   is31_init();
 
-  //set Display Option Register so all pwm intensity is controlled from Frame 1
-  is31_write_register(IS31_FUNCTIONREG, IS31_REG_DISPLAYOPT, IS31_REG_DISPLAYOPT_INTENSITY_SAME);
+  //set Display Option Register so all pwm intensity is controlled from page 0
+  //enable blink and set blink period to 0.27s x rate
+  is31_write_register(IS31_FUNCTIONREG, IS31_REG_DISPLAYOPT, IS31_REG_DISPLAYOPT_INTENSITY_SAME + IS31_REG_DISPLAYOPT_BLINK_ENABLE + 4);
 
-  /* set full pwm on Frame 1 */
-  for(i=1; i<9; i++) {
-    pwm_register_array[i]=0xFF; 
-  }
+  /* set full pwm on page 1 */
+  pwm_register_array[0] = 0;
+  __builtin_memset(pwm_register_array+1, 0xFF, 8);
   for(i=0; i<8; i++) {
     pwm_register_array[0] = 0x24 + (i * 0x10);//first byte of 9 bytes must be register address
     is31_write_data(0, pwm_register_array, 9);
     chThdSleepMilliseconds(5);
   }
 
-  //set all led bits on for Frame 2 LEDS_ALL
-  //TODO: set all off in init
-  full_page[0] = 0;
-  __builtin_memset(full_page+1, 0, 0x12);
-  is31_write_data(1, full_page, 1+0x12);
-
   /* enable breathing when the displayed page changes */
   // Fade-in Fade-out, time = 26ms * 2^N, N=3
   is31_write_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL1, (3<<4)|3);
   is31_write_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL2, IS31_REG_BREATHCTRL2_ENABLE|3);
 
-  // clean up the lock LEDs
-  set_lock_leds(USB_LED_NUM_LOCK, 0);
-  set_lock_leds(USB_LED_CAPS_LOCK, 0);
-
   /* more time consuming LED processing should be offloaded into
    * a thread, with asynchronous messaging. */
   chMBObjectInit(&led_mailbox, led_mailbox_queue, LED_MAILBOX_NUM_MSGS);
   chThdCreateStatic(waLEDthread, sizeof(waLEDthread), LOWPRIO, LEDthread, NULL);
 }
-
-//TODO: Don't know equivalent QMK hooks for these
-//
-//void hook_usb_suspend_entry(void) {
-//#ifdef SLEEP_LED_ENABLE
-//  chSysLockFromISR();
-//  chMBPostI(&led_mailbox, LED_MSG_SLEEP_LED_ON);
-//  chSysUnlockFromISR();
-//#endif /* SLEEP_LED_ENABLE */
-//}
-//
-//void hook_usb_suspend_loop(void) {
-//  chThdSleepMilliseconds(100);
-//  /* Remote wakeup */
-//  if((USB_DRIVER.status & 2) && suspend_wakeup_condition()) {
-//    send_remote_wakeup(&USB_DRIVER);
-//  }
-//}
-//
-//void hook_usb_wakeup(void) {
-//#ifdef SLEEP_LED_ENABLE
-//  chSysLockFromISR();
-//  chMBPostI(&led_mailbox, LED_MSG_SLEEP_LED_OFF);
-//  chSysUnlockFromISR();
-//#endif /* SLEEP_LED_ENABLE */
-//}
-//*/