X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=keyboard%2Fplanck%2Fmatrix.c;h=e3926caecee9ccb4900b1c7cf27f05b9d9c0c890;hb=65680819df13585a563296f008be1a4b0ee8045a;hp=ca59f7c73b83ea24ef2295d79534de389dae94cd;hpb=d6f2f878f90ce033a2495aa9ad82cfa1578429b9;p=qmk_firmware.git

diff --git a/keyboard/planck/matrix.c b/keyboard/planck/matrix.c
index ca59f7c73..e3926caec 100644
--- a/keyboard/planck/matrix.c
+++ b/keyboard/planck/matrix.c
@@ -27,6 +27,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "debug.h"
 #include "util.h"
 #include "matrix.h"
+#include "backlight.h" // TODO fix this dependency 
 
 
 #ifndef DEBOUNCE
@@ -57,6 +58,13 @@ uint8_t matrix_cols(void)
 
 void matrix_init(void)
 {
+    // To use PORTF disable JTAG with writing JTD bit twice within four cycles.
+    MCUCR |= (1<<JTD);
+    MCUCR |= (1<<JTD);
+
+    // TODO fix this dependency 
+    backlight_init_ports();
+    
     // initialize row and col
     unselect_rows();
     init_cols();
@@ -134,61 +142,77 @@ uint8_t matrix_key_count(void)
     return count;
 }
 
+//
+// Planck PCB Rev 1 Pin Assignments
+//
+// Column: 0,  1,  2,  3,  4,  5,  6,  7,  8,  9,  10, 11
+// Pin:    F1, F0, B0, C7, F4, F5, F6, F7, D4, D6, B4, D7
+//
+
 static void init_cols(void)
 {
-    DDRB &= ~(1<<7 | 1<<4 | 1<<5 | 1<<6);
-    PORTB |= (1<<7 | 1<<4 | 1<<5 | 1<<6);
-    DDRC &= ~(1<<6);
-    PORTC |= (1<<6);
-    DDRD &= ~(1<<0 | 1<<1 | 1<<2 | 1<<3 | 1<<7);
-    PORTD |= (1<<0 | 1<<1 | 1<<2 | 1<<3 | 1<<7);
-    DDRF &= ~(1<<7 | 1<<6);
-    PORTF |= (1<<7 | 1<<6);
+    DDRB &= ~(1<<4 | 1<<0);
+    PORTB |= (1<<4 | 1<<0);
+    DDRC &= ~(1<<7);
+    PORTC |= (1<<7);
+    DDRD &= ~(1<<7 | 1<<6 | 1<<4);
+    PORTD |= (1<<7 | 1<<6 | 1<<4);
+    DDRF &= ~(1<<0 | 1<<1 | 1<<4 | 1<<5 | 1<<6 | 1<<7);
+    PORTF |= (1<<0 | 1<<1 | 1<<4 | 1<<5 | 1<<6 | 1<<7);
     
 }
 
 static matrix_row_t read_cols(void)
 {
-  return (PINB&(1<<7) ? 0 : (1<<0)) |
-         (PIND&(1<<0) ? 0 : (1<<1)) |
-         (PIND&(1<<1) ? 0 : (1<<2)) |
-         (PIND&(1<<2) ? 0 : (1<<3)) |
-         (PIND&(1<<3) ? 0 : (1<<4)) |
-         (PINC&(1<<6) ? 0 : (1<<5)) |
-         (PIND&(1<<7) ? 0 : (1<<6)) |
-         (PINB&(1<<4) ? 0 : (1<<7)) |
-         (PINB&(1<<5) ? 0 : (1<<8)) |
-         (PINB&(1<<6) ? 0 : (1<<9)) |
-         (PINF&(1<<7) ? 0 : (1<<10)) |
-         (PINF&(1<<6) ? 0 : (1<<11));
+  return (PINF&(1<<1) ? 0 : (1<<0)) |
+         (PINF&(1<<0) ? 0 : (1<<1)) |
+         (PINB&(1<<0) ? 0 : (1<<2)) |
+         (PINC&(1<<7) ? 0 : (1<<3)) |
+         (PINF&(1<<4) ? 0 : (1<<4)) |
+         (PINF&(1<<5) ? 0 : (1<<5)) |
+         (PINF&(1<<6) ? 0 : (1<<6)) |
+         (PINF&(1<<7) ? 0 : (1<<7)) |
+         (PIND&(1<<4) ? 0 : (1<<8)) |
+         (PIND&(1<<6) ? 0 : (1<<9)) |
+         (PINB&(1<<4) ? 0 : (1<<10)) |
+         (PIND&(1<<7) ? 0 : (1<<11));
          
 }
 
 static void unselect_rows(void)
 {
-    DDRF &= ~(1<<0 | 1<<1 | 1<<4 | 1<<5);
-    PORTF |= (1<<0 | 1<<1 | 1<<4 | 1<<5);
+    DDRB &= ~(1<<5 | 1<<6);
+    PORTB |= (1<<5 | 1<<6);
+    DDRD &= ~(1<<0 | 1<<5);
+    PORTD |= (1<<0 | 1<<5);
     
 }
 
+//
+// Planck PCB Rev 1 Pin Assignments
+//
+// Row: 0,  1,  2,  3
+// Pin: D0, D5, B5, B6
+//
+
 static void select_row(uint8_t row)
 {
     switch (row) {
         case 0:
-            DDRF  |= (1<<0);
-            PORTF &= ~(1<<0);
+            DDRD  |= (1<<0);
+            PORTD &= ~(1<<0);
             break;
         case 1:
-            DDRF  |= (1<<1);
-            PORTF &= ~(1<<1);
+            DDRD  |= (1<<5);
+            PORTD &= ~(1<<5);
             break;
         case 2:
-            DDRF  |= (1<<4);
-            PORTF &= ~(1<<4);
+            DDRB  |= (1<<5);
+            PORTB &= ~(1<<5);
             break;
         case 3:
-            DDRF  |= (1<<5);
-            PORTF &= ~(1<<5);
+            DDRB  |= (1<<6);
+            PORTB &= ~(1<<6);
             break;
         
     }