X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=installer%2Ftest.php;h=2dd330531e5c36837fa7ba06a8e199dedef8a15d;hb=48e244a464574aa732ef5ab3fe759f1e05665b3d;hp=5be343a318ea13ffebb5f4bfea7dbfb63227274e;hpb=92c39ec46fd8ad15a83b42a19fab7cb2e9a59ec9;p=roundcube.git
diff --git a/installer/test.php b/installer/test.php
index 5be343a..2dd3305 100644
--- a/installer/test.php
+++ b/installer/test.php
@@ -3,10 +3,8 @@
Check config files
config)) {
$RCI->pass('main.inc.php');
@@ -29,16 +27,79 @@ else if (!$read_db) {
$RCI->fail('db.inc.php', 'Unable to read file. Did you create the config files?');
}
+if ($RCI->configured && ($messages = $RCI->check_config())) {
+
+ if (is_array($messages['missing'])) {
+ echo 'Missing config options ';
+ echo 'The following config options are not present in the current configuration. ';
+ echo 'Please check the default config files and add the missing properties to your local config files.
';
+
+ echo '';
+ foreach ($messages['missing'] as $msg) {
+ echo html::tag('li', null, html::span('propname', $msg['prop']) . ($msg['name'] ? ': ' . $msg['name'] : ''));
+ }
+ echo ' ';
+ }
+
+ if (is_array($messages['replaced'])) {
+ echo 'Replaced config options ';
+ echo 'The following config options have been replaced or renamed. ';
+ echo 'Please update them accordingly in your config files.
';
+
+ echo '';
+ foreach ($messages['replaced'] as $msg) {
+ echo html::tag('li', null, html::span('propname', $msg['prop']) .
+ ' was replaced by ' . html::span('propname', $msg['replacement']));
+ }
+ echo ' ';
+ }
+
+ if (is_array($messages['obsolete'])) {
+ echo 'Obsolete config options ';
+ echo 'You still have some obsolete or inexistent properties set. This isn\'t a problem but should be noticed.
';
+
+ echo '';
+ foreach ($messages['obsolete'] as $msg) {
+ echo html::tag('li', null, html::span('propname', $msg['prop']) . ($msg['name'] ? ': ' . $msg['name'] : ''));
+ }
+ echo ' ';
+ }
+
+ echo 'OK, lazy people can download the updated config files here: ';
+ echo html::a(array('href' => './?_mergeconfig=main'), 'main.inc.php') . ' ';
+ echo html::a(array('href' => './?_mergeconfig=db'), 'db.inc.php');
+ echo "
";
+
+
+ if (is_array($messages['dependencies'])) {
+ echo 'Dependency check failed ';
+ echo 'Some of your configuration settings require other options to be configured or additional PHP modules to be installed
';
+
+ echo '';
+ foreach ($messages['dependencies'] as $msg) {
+ echo html::tag('li', null, html::span('propname', $msg['prop']) . ': ' . $msg['explain']);
+ }
+ echo ' ';
+ }
+
+
+}
+
?>
Check if directories are writable
-RoundCube may need to write/save files into these directories
+Roundcube may need to write/save files into these directories
configured) {
$pass = false;
- foreach (array($RCI->config['temp_dir'],$RCI->config['log_dir']) as $dir) {
- $dirpath = $dir{0} == '/' ? $dir : $docroot . '/' . $dir;
+
+ $dirs[] = $RCI->config['temp_dir'] ? $RCI->config['temp_dir'] : 'temp';
+ if($RCI->config['log_driver'] != 'syslog')
+ $dirs[] = $RCI->config['log_dir'] ? $RCI->config['log_dir'] : 'logs';
+
+ foreach ($dirs as $dir) {
+ $dirpath = $dir[0] == '/' ? $dir : INSTALL_PATH . $dir;
if (is_writable(realpath($dirpath))) {
$RCI->pass($dir);
$pass = true;
@@ -58,20 +119,14 @@ else {
?>
-Check configured database settings
+Check DB config
configured) {
- if (!empty($RCI->config['db_backend']) && !empty($RCI->config['db_dsnw'])) {
+ if (!empty($RCI->config['db_dsnw'])) {
- echo 'Backend: ';
- echo 'PEAR::' . strtoupper($RCI->config['db_backend']) . ' ';
-
- $_class = 'rcube_' . strtolower($RCI->config['db_backend']);
- require_once 'include/' . $_class . '.inc';
-
- $DB = new $_class($RCI->config['db_dsnw'], '', false);
+ $DB = new rcube_mdb2($RCI->config['db_dsnw'], '', false);
$DB->db_connect('w');
if (!($db_error_msg = $DB->is_error())) {
$RCI->pass('DSN (write)');
@@ -82,8 +137,6 @@ if ($RCI->configured) {
$RCI->fail('DSN (write)', $db_error_msg);
echo 'Make sure that the configured database exists and that the user has write privileges ';
echo 'DSN: ' . $RCI->config['db_dsnw'] . '
';
- if ($RCI->config['db_backend'] == 'mdb2')
- echo 'There are known problems with MDB2 running on PHP 4. Try setting db_backend to \'db\' instead
';
}
}
else {
@@ -103,18 +156,35 @@ if ($db_working && $_POST['initdb']) {
}
}
+else if ($db_working && $_POST['updatedb']) {
+ if (!($success = $RCI->update_db($DB, $_POST['version']))) {
+ $updatefile = INSTALL_PATH . 'SQL/' . (isset($RCI->db_map[$DB->db_provider]) ? $RCI->db_map[$DB->db_provider] : $DB->db_provider) . '.update.sql';
+ echo 'Please manually execute the SQL statements from '.$updatefile.' on your database. ';
+ echo 'See comments in the file and execute queries below the comment with the currently installed version number.
';
+ }
+}
+
// test database
if ($db_working) {
$db_read = $DB->query("SELECT count(*) FROM {$RCI->config['db_table_users']}");
- if (!$db_read) {
+ if ($DB->db_error) {
$RCI->fail('DB Schema', "Database not initialized");
- $db_working = false;
echo '
';
+ $db_working = false;
+ }
+ else if ($err = $RCI->db_schema_check($DB, $update = !empty($_POST['updatedb']))) {
+ $RCI->fail('DB Schema', "Database schema differs");
+ echo '";
+ $select = $RCI->versions_select(array('name' => 'version'));
+ echo 'You should run the update queries to get the schmea fixed. Version to update from: ' . $select->show() . '
';
+// echo 'Please manually execute the SQL statements from '.$updatefile.' on your database. ';
+// echo 'See comments in the file and execute queries that are superscribed with the currently installed version number.
';
+ $db_working = false;
}
else {
$RCI->pass('DB Schema');
+ echo ' ';
}
- echo ' ';
}
// more database tests
@@ -130,7 +200,7 @@ if ($db_working) {
else {
$RCI->fail('DB Write', $RCI->get_error());
}
- echo ' ';
+ echo ' ';
// check timezone settings
$tz_db = 'SELECT ' . $DB->unixtimestamp($DB->now()) . ' AS tz_db';
@@ -151,10 +221,10 @@ if ($db_working) {
?>
-Test SMTP settings
+Test SMTP config
-Server: getprop('smtp_server', 'PHP mail()'); ?>
+Server: getprop('smtp_server', 'PHP mail()')); ?>
Port: getprop('smtp_port'); ?>
getprop('smtp_server')) {
$pass = $RCI->getprop('smtp_pass', '(none)');
if ($user == '%u') {
- $user_field = new textfield(array('name' => '_smtp_user'));
+ $user_field = new html_inputfield(array('name' => '_smtp_user'));
$user = $user_field->show($_POST['_smtp_user']);
}
if ($pass == '%p') {
- $pass_field = new passwordfield(array('name' => '_smtp_pass'));
+ $pass_field = new html_passwordfield(array('name' => '_smtp_pass'));
$pass = $pass_field->show();
}
@@ -176,37 +246,37 @@ if ($RCI->getprop('smtp_server')) {
echo "Password: $pass ";
}
-$from_field = new textfield(array('name' => '_from', 'id' => 'sendmailfrom'));
-$to_field = new textfield(array('name' => '_to', 'id' => 'sendmailto'));
+$from_field = new html_inputfield(array('name' => '_from', 'id' => 'sendmailfrom'));
+$to_field = new html_inputfield(array('name' => '_to', 'id' => 'sendmailto'));
?>
Trying to send email... ';
-
- if (preg_match('/^' . $RCI->email_pattern . '$/i', trim($_POST['_from'])) &&
- preg_match('/^' . $RCI->email_pattern . '$/i', trim($_POST['_to']))) {
-
+
+ $from = idn_to_ascii(trim($_POST['_from']));
+ $to = idn_to_ascii(trim($_POST['_to']));
+
+ if (preg_match('/^' . $RCI->email_pattern . '$/i', $from) &&
+ preg_match('/^' . $RCI->email_pattern . '$/i', $to)
+ ) {
$headers = array(
- 'From' => trim($_POST['_from']),
- 'To' => trim($_POST['_to']),
- 'Subject' => 'Test message from RoundCube',
+ 'From' => $from,
+ 'To' => $to,
+ 'Subject' => 'Test message from Roundcube',
);
- $body = 'This is a test to confirm that RoundCube can send email.';
+ $body = 'This is a test to confirm that Roundcube can send email.';
$smtp_response = array();
-
+
// send mail using configured SMTP server
if ($RCI->getprop('smtp_server')) {
$CONFIG = $RCI->config;
-
+
if (!empty($_POST['_smtp_user'])) {
$CONFIG['smtp_user'] = $_POST['_smtp_user'];
}
@@ -214,12 +284,17 @@ if (isset($_POST['sendmail']) && !empty($_POST['_from']) && !empty($_POST['_to']
$CONFIG['smtp_pass'] = $_POST['_smtp_pass'];
}
- $mail_object = new rc_mail_mime();
+ $mail_object = new Mail_mime();
$send_headers = $mail_object->headers($headers);
-
- $status = smtp_mail($headers['From'], $headers['To'],
- ($foo = $mail_object->txtHeaders($send_headers)),
- $body, $smtp_response);
+
+ $SMTP = new rcube_smtp();
+ $SMTP->connect(rcube_parse_host($RCI->getprop('smtp_server')),
+ $RCI->getprop('smtp_port'), $CONFIG['smtp_user'], $CONFIG['smtp_pass']);
+
+ $status = $SMTP->send_mail($headers['From'], $headers['To'],
+ ($foo = $mail_object->txtHeaders($send_headers)), $body);
+
+ $smtp_response = $SMTP->get_response();
}
else { // use mail()
$header_str = 'From: ' . $headers['From'];
@@ -243,10 +318,10 @@ if (isset($_POST['sendmail']) && !empty($_POST['_from']) && !empty($_POST['_to']
else {
$RCI->fail('SMTP send', 'Invalid sender or recipient');
}
+
+ echo '';
}
-echo '';
-
?>
@@ -265,21 +340,21 @@ echo '';
-Test IMAP configuration
+Test IMAP config
get_hostlist();
if (!empty($default_hosts)) {
- $host_field = new select(array('name' => '_host', 'id' => 'imaphost'));
+ $host_field = new html_select(array('name' => '_host', 'id' => 'imaphost'));
$host_field->add($default_hosts);
}
else {
- $host_field = new textfield(array('name' => '_host', 'id' => 'imaphost'));
+ $host_field = new html_inputfield(array('name' => '_host', 'id' => 'imaphost'));
}
-$user_field = new textfield(array('name' => '_user', 'id' => 'imapuser'));
-$pass_field = new passwordfield(array('name' => '_pass', 'id' => 'imappass'));
+$user_field = new html_inputfield(array('name' => '_user', 'id' => 'imapuser'));
+$pass_field = new html_passwordfield(array('name' => '_pass', 'id' => 'imappass'));
?>
@@ -307,24 +382,27 @@ $pass_field = new passwordfield(array('name' => '_pass', 'id' => 'imappass'));
Connecting to ' . Q($_POST['_host']) . '... ';
-
- $a_host = parse_url($_POST['_host']);
+
+ $imap_host = trim($_POST['_host']);
+ $imap_port = $RCI->getprop('default_port');
+ $a_host = parse_url($imap_host);
+
if ($a_host['host']) {
$imap_host = $a_host['host'];
- $imap_ssl = (isset($a_host['scheme']) && in_array($a_host['scheme'], array('ssl','imaps','tls'))) ? $a_host['scheme'] : null;
- $imap_port = isset($a_host['port']) ? $a_host['port'] : ($imap_ssl ? 993 : $CONFIG['default_port']);
- }
- else {
- $imap_host = trim($_POST['_host']);
- $imap_port = $RCI->getprop('default_port');
+ $imap_ssl = (isset($a_host['scheme']) && in_array($a_host['scheme'], array('ssl','imaps','tls'))) ? $a_host['scheme'] : null;
+ if (isset($a_host['port']))
+ $imap_port = $a_host['port'];
+ else if ($imap_ssl && $imap_ssl != 'tls' && (!$imap_port || $imap_port == 143))
+ $imap_port = 993;
}
-
+
+ $imap_host = idn_to_ascii($imap_host);
+ $imap_user = idn_to_ascii($_POST['_user']);
+
$imap = new rcube_imap(null);
- if ($imap->connect($imap_host, $_POST['_user'], $_POST['_pass'], $imap_port, $imap_ssl)) {
+ if ($imap->connect($imap_host, $imap_user, $_POST['_pass'], $imap_port, $imap_ssl)) {
$RCI->pass('IMAP connect', 'SORT capability: ' . ($imap->get_capability('SORT') ? 'yes' : 'no'));
$imap->close();
}
@@ -344,7 +422,8 @@ if (isset($_POST['imaptest']) && !empty($_POST['_host']) && !empty($_POST['_user
After completing the installation and the final tests please remove the whole
-installer folder from the document root of the webserver.
+installer folder from the document root of the webserver or make sure that
+enable_installer option in config/main.inc.php is disabled.
These files may expose sensitive configuration data like server passwords and encryption keys