X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=flower%2Frational.cc;h=559e1646a0cade47b932d7cfab048f0feb641da8;hb=a6a51abfd0195a3cf7d6ea095cf69808852f21ce;hp=724f0d99ca5b526dfc5f067decfbaf2066f7796c;hpb=16cb456cabf477f6d398ff731aa0f10b60913394;p=lilypond.git

diff --git a/flower/rational.cc b/flower/rational.cc
index 724f0d99ca..559e1646a0 100644
--- a/flower/rational.cc
+++ b/flower/rational.cc
@@ -1,9 +1,20 @@
 /*
-  rational.cc -- implement Rational
+  This file is part of LilyPond, the GNU music typesetter.
 
-  source file of the Flower Library
+  Copyright (C) 1997--2015 Han-Wen Nienhuys <hanwen@xs4all.nl>
 
-  (c) 1997--2007 Han-Wen Nienhuys <hanwen@xs4all.nl>
+  LilyPond is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  LilyPond is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with LilyPond.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "rational.hh"
@@ -20,7 +31,7 @@ double
 Rational::to_double () const
 {
   if (sign_ == -1 || sign_ == 1 || sign_ == 0)
-    return ((double)sign_) * num_ / den_;
+    return (double)sign_ * (double)num_ / (double)den_;
   if (sign_ == -2)
     return -HUGE_VAL;
   else if (sign_ == 2)
@@ -31,7 +42,6 @@ Rational::to_double () const
   return 0.0;
 }
 
-
 #ifdef STREAM_SUPPORT
 ostream &
 operator << (ostream &o, Rational r)
@@ -50,7 +60,9 @@ Rational::abs () const
 Rational
 Rational::trunc_rat () const
 {
-  return Rational (num_ - (num_ % den_), den_);
+  if (is_infinity ())
+    return *this;
+  return Rational ((num_ - (num_ % den_)) * sign_, den_);
 }
 
 Rational::Rational ()
@@ -59,7 +71,7 @@ Rational::Rational ()
   num_ = den_ = 1;
 }
 
-Rational::Rational (int n, int d)
+Rational::Rational (I64 n, I64 d)
 {
   sign_ = ::sign (n) * ::sign (d);
   num_ = ::abs (n);
@@ -67,18 +79,32 @@ Rational::Rational (int n, int d)
   normalize ();
 }
 
-Rational::Rational (int n)
+Rational::Rational (I64 n)
 {
   sign_ = ::sign (n);
   num_ = ::abs (n);
   den_ = 1;
 }
 
+Rational::Rational (U64 n)
+{
+  sign_ = 1;
+  num_ = n;
+  den_ = 1;
+}
+
+Rational::Rational (int n)
+{
+  sign_ = ::sign (n);
+  num_ = ::abs (n);
+  den_ = 1;
+}
 
 void
 Rational::set_infinite (int s)
 {
   sign_ = ::sign (s) * 2;
+  num_ = 1;
 }
 
 Rational
@@ -105,54 +131,52 @@ Rational::mod_rat (Rational div) const
   return r;
 }
 
-
 /*
   copy & paste from scm_gcd (GUILE).
  */
-static int
-gcd (long u, long v) 
+static I64
+gcd (I64 u, I64 v)
 {
-  long result = 0;
+  I64 result = 0;
   if (u == 0)
     result = v;
   else if (v == 0)
     result = u;
   else
     {
-      long k = 1;
-      long t;
+      I64 k = 1;
+      I64 t;
       /* Determine a common factor 2^k */
       while (!(1 & (u | v)))
-	{
-	  k <<= 1;
-	  u >>= 1;
-	  v >>= 1;
-	}
+        {
+          k <<= 1;
+          u >>= 1;
+          v >>= 1;
+        }
       /* Now, any factor 2^n can be eliminated */
       if (u & 1)
-	t = -v;
+        t = -v;
       else
-	{
-	  t = u;
-	b3:
-	  t = t >> 1;
-	}
+        {
+          t = u;
+b3:
+          t = t >> 1;
+        }
       if (!(1 & t))
-	goto b3;
+        goto b3;
       if (t > 0)
-	u = t;
+        u = t;
       else
-	v = -t;
+        v = -t;
       t = u - v;
       if (t != 0)
-	goto b3;
+        goto b3;
       result = u * k;
     }
 
   return result;
 }
 
-
 void
 Rational::normalize ()
 {
@@ -173,7 +197,7 @@ Rational::normalize ()
     }
   else
     {
-      int g = gcd (num_, den_);
+      I64 g = gcd (num_, den_);
 
       num_ /= g;
       den_ /= g;
@@ -192,11 +216,11 @@ Rational::compare (Rational const &r, Rational const &s)
     return -1;
   else if (r.sign_ > s.sign_)
     return 1;
-  else if (r.is_infinity ())
+  else if (r.is_infinity ()) // here s is also infinite with the same sign
     return 0;
-  else if (r.sign_ == 0)
+  else if (r.sign_ == 0) // here s.sign_ is also zero
     return 0;
-  return r.sign_ * ::sign (int (r.num_ * s.den_) - int (s.num_ * r.den_));
+  return ::sign (r - s);
 }
 
 int
@@ -221,9 +245,9 @@ Rational::operator += (Rational r)
     *this = r;
   else
     {
-      int lcm = (den_ / gcd (r.den_, den_)) * r.den_;
-      int n = sign_ * num_ * (lcm / den_) + r.sign_ * r.num_ * (lcm / r.den_);
-      int d = lcm;
+      I64 lcm = (den_ / gcd (r.den_, den_)) * r.den_;
+      I64 n = sign_ * num_ * (lcm / den_) + r.sign_ * r.num_ * (lcm / r.den_);
+      I64 d = lcm;
       sign_ = ::sign (n) * ::sign (d);
       num_ = ::abs (n);
       den_ = ::abs (d);
@@ -248,20 +272,20 @@ Rational::Rational (double x)
       const int FACT = 1 << 20;
 
       /*
-	Thanks to Afie for this too simple  idea.
+        Thanks to Afie for this too simple  idea.
 
-	do not blindly substitute by libg++ code, since that uses
-	arbitrary-size integers.  The rationals would overflow too
-	easily.
+        do not blindly substitute by libg++ code, since that uses
+        arbitrary-size integers.  The rationals would overflow too
+        easily.
       */
 
-      num_ = (unsigned int) (mantissa * FACT);
-      den_ = (unsigned int) FACT;
+      num_ = (U64) (mantissa * FACT);
+      den_ = (U64) FACT;
       normalize ();
       if (expt < 0)
-	den_ <<= -expt;
+        den_ <<= -expt;
       else
-	num_ <<= expt;
+        num_ <<= expt;
       normalize ();
     }
   else
@@ -276,7 +300,7 @@ Rational::Rational (double x)
 void
 Rational::invert ()
 {
-  int r (num_);
+  I64 r (num_);
   num_ = den_;
   den_ = r;
 }
@@ -295,7 +319,7 @@ Rational::operator *= (Rational r)
   den_ *= r.den_;
 
   normalize ();
- exit_func:
+exit_func:
   return *this;
 }
 
@@ -337,7 +361,7 @@ Rational::to_string () const
 int
 Rational::to_int () const
 {
-  return (int) num () / den ();
+  return (int) (num () / den ());
 }
 
 int