X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=cgi%2Fbugreport.cgi;h=856a35be4e8c27c785a9ab0c55da7b433e9fa648;hb=475b01877ca41713d789298a00d22fc02defa3ed;hp=0d0726c7d1da4a5bfc0594f45cf39463d51adec7;hpb=2ff9ac96459ffad3fbd66eff23eab419100e63ed;p=debbugs.git diff --git a/cgi/bugreport.cgi b/cgi/bugreport.cgi index 0d0726c..856a35b 100755 --- a/cgi/bugreport.cgi +++ b/cgi/bugreport.cgi @@ -1,7 +1,5 @@ #!/usr/bin/perl -wT -package debbugs; - use warnings; use strict; use POSIX qw(strftime tzset); @@ -10,48 +8,65 @@ use MIME::Decoder; use IO::Scalar; use IO::File; -use Debbugs::Config qw(:globals); -#require '/usr/lib/debbugs/errorlib'; -require './common.pl'; - -require '/etc/debbugs/text'; +use Debbugs::Config qw(:globals :text); # for read_log_records -use Debbugs::Log; +use Debbugs::Log qw(read_log_records); use Debbugs::MIME qw(convert_to_utf8 decode_rfc1522 create_mime_message); -use Debbugs::CGI qw(:url :html); +use Debbugs::CGI qw(:url :html :util); +use Debbugs::Common qw(buglog getmaintainers); +use Debbugs::Packages qw(getpkgsrc); +use Debbugs::Status qw(splitpackages get_bug_status isstrongseverity); use Scalar::Util qw(looks_like_number); - -my %param = readparse(); +use CGI::Simple; +my $q = new CGI::Simple; + +my %param = cgi_parameters(query => $q, + single => [qw(bug msg att boring terse), + qw(reverse mbox mime trim), + qw(mboxstat mboxmaint archive), + qw(repeatmerged) + ], + default => {msg => '', + boring => 'no', + terse => 'no', + reverse => 'no', + mbox => 'no', + mime => 'no', + mboxstat => 'no', + mboxmaint => 'no', + archive => 'no', + repeatmerged => 'yes', + }, + ); +# This is craptacular. my $tail_html; -my $ref = $param{'bug'} || quitcgi("No bug number"); +my $ref = $param{bug} or quitcgi("No bug number"); $ref =~ /(\d+)/ or quitcgi("Invalid bug number"); $ref = $1; my $short = "#$ref"; -my $msg = $param{'msg'} || ""; +my $msg = $param{'msg'}; my $att = $param{'att'}; -my $boring = ($param{'boring'} || 'no') eq 'yes'; -my $terse = ($param{'terse'} || 'no') eq 'yes'; -my $reverse = ($param{'reverse'} || 'no') eq 'yes'; -my $mbox = ($param{'mbox'} || 'no') eq 'yes'; -my $mime = ($param{'mime'} || 'yes') eq 'yes'; +my $boring = $param{'boring'} eq 'yes'; +my $terse = $param{'terse'} eq 'yes'; +my $reverse = $param{'reverse'} eq 'yes'; +my $mbox = $param{'mbox'} eq 'yes'; +my $mime = $param{'mime'} eq 'yes'; my $trim_headers = ($param{trim} || ($msg?'no':'yes')) eq 'yes'; -my $mbox_status_message = ($param{mboxstat}||'no') eq 'yes'; -my $mbox_maint = ($param{mboxmaint}||'no') eq 'yes'; +my $mbox_status_message = $param{mboxstat} eq 'yes'; +my $mbox_maint = $param{mboxmaint} eq 'yes'; $mbox = 1 if $mbox_status_message or $mbox_maint; # Not used by this script directly, but fetch these so that pkgurl() and # friends can propagate them correctly. -my $archive = ($param{'archive'} || 'no') eq 'yes'; -my $repeatmerged = ($param{'repeatmerged'} || 'yes') eq 'yes'; -set_option('archive', $archive); -set_option('repeatmerged', $repeatmerged); +my $archive = $param{'archive'} eq 'yes'; +my $repeatmerged = $param{'repeatmerged'} eq 'yes'; my $buglog = buglog($ref); @@ -91,11 +106,11 @@ sub display_entity ($$$$\$\@) { foreach (qw(From To Cc Subject Date)) { my $head_field = $head->get($_); next unless defined $head_field and $head_field ne ''; - push @headers, qq($_: ) . htmlsanit(decode_rfc1522($head_field)); + push @headers, qq($_: ) . html_escape(decode_rfc1522($head_field)); } $$this .= join(qq(), @headers) unless $terse; } else { - $$this .= htmlsanit(decode_rfc1522($entity->head->stringify)); + $$this .= html_escape(decode_rfc1522($entity->head->stringify)); } $$this .= "\n"; } @@ -103,14 +118,14 @@ sub display_entity ($$$$\$\@) { unless (($top and $type =~ m[^text(?:/plain)?(?:;|$)]) or ($type =~ m[^multipart/])) { push @$attachments, $entity; - my @dlargs = ($ref, "msg=$xmessage", "att=$#$attachments"); - push @dlargs, "filename=$filename" if $filename ne ''; + my @dlargs = ($ref, msg=>$xmessage, att=>$#$attachments); + push @dlargs, (filename=>$filename) if $filename ne ''; my $printname = $filename; $printname = 'Message part ' . ($#$attachments + 1) if $filename eq ''; - $$this .= '
[$printname } .
+	$$this .= '
[$printname } .
 		  "($type, $disposition)]
\n"; - if ($msg and defined($att) and $att eq $#$attachments) { + if ($msg and defined($att) and $att == $#$attachments) { my $head = $entity->head; chomp(my $type = $entity->effective_type); my $body = $entity->stringify_body; @@ -160,12 +175,18 @@ sub display_entity ($$$$\$\@) { my ($charset) = $content_type =~ m/charset\s*=\s*\"?([\w-]+)\"?/i; my $body = $entity->bodyhandle->as_string; $body = convert_to_utf8($body,$charset) if defined $charset; - $body = htmlsanit($body); + $body = html_escape($body); + # Attempt to deal with format=flowed + if ($content_type =~ m/format\s*=\s*\"?flowed\"?/i) { + $body =~ s{^\ }{}mgo; + # we ignore the other things that you can do with + # flowed e-mails cause they don't really matter. + } # Add links to URLs $body =~ s,((ftp|http|https)://[\S~-]+?/?)((\>\;)?[)]?[']?[:.\,]?(\s|$)),$1$3,go; # Add links to bug closures $body =~ s[(closes:\s*(?:bug)?\#?\s?\d+(?:,?\s*(?:bug)?\#?\s?\d+)*) - ][my $temp = $1; $temp =~ s{(\d+)}{qq($1)}ge; $temp;]gxie; + ][my $temp = $1; $temp =~ s{(\d+)}{qq($1)}ge; $temp;]gxie; $$this .= qq(
$body
\n); } } @@ -181,20 +202,20 @@ my $tpack; my $tmain; my $dtime = strftime "%a, %e %b %Y %T UTC", gmtime; -$tail_html = $debbugs::gHTMLTail; +$tail_html = $gHTMLTail; $tail_html =~ s/SUBSTITUTE_DTIME/$dtime/; -my %status = %{getbugstatus($ref)}; +my %status = %{get_bug_status(bug=>$ref)}; unless (%status) { print < -$short - $debbugs::gProject $debbugs::gBug report logs +$short - $gProject $gBug report logs -

$debbugs::gProject $debbugs::gBug report logs - $short

-

There is no record of $debbugs::gBug $short. +

$gProject $gBug report logs - $short

+

There is no record of $gBug $short. Try the search page instead.

$tail_html EOF @@ -214,29 +235,45 @@ if ($status{severity} eq 'normal') { $showseverity = "Severity: $status{severity};\n"; } +if (@{$status{found_versions}} or @{$status{fixed_versions}}) { + $indexentry.= q(
version graph
}; +} + + $indexentry .= "
\n"; -$indexentry .= htmlpackagelinks($status{package}, 0) . ";\n"; +$indexentry .= htmlize_packagelinks($status{package}, 0) . ";\n"; foreach my $pkg (@tpacks) { my $tmaint = defined($maintainer{$pkg}) ? $maintainer{$pkg} : '(unknown)'; my $tsrc = defined($pkgsrc{$pkg}) ? $pkgsrc{$pkg} : '(unknown)'; $indexentry .= - htmlmaintlinks(sub { $_[0] == 1 ? "Maintainer for $pkg is\n" + htmlize_maintlinks(sub { $_[0] == 1 ? "Maintainer for $pkg is\n" : "Maintainers for $pkg are\n" }, $tmaint); $indexentry .= ";\nSource for $pkg is\n". - '$tsrc" if ($tsrc ne "(unknown)"); + '$tsrc" if ($tsrc ne "(unknown)"); $indexentry .= ".\n"; } $indexentry .= "
"; -$indexentry .= htmladdresslinks("Reported by: ", \&submitterurl, +$indexentry .= htmlize_addresslinks("Reported by: ", \&submitterurl, $status{originator}) . ";\n"; $indexentry .= sprintf "Date: %s.\n", (strftime "%a, %e %b %Y %T UTC", localtime($status{date})); -$indexentry .= "
Owned by: " . htmlsanit($status{owner}) . ".\n" +$indexentry .= "
Owned by: " . html_escape($status{owner}) . ".\n" if length $status{owner}; $indexentry .= "
\n"; @@ -245,7 +282,7 @@ my @descstates; $indexentry .= "

$showseverity"; $indexentry .= sprintf "Tags: %s;\n", - htmlsanit(join(", ", sort(split(/\s+/, $status{tags})))) + html_escape(join(", ", sort(split(/\s+/, $status{tags})))) if length($status{tags}); $indexentry .= "
" if (length($showseverity) or length($status{tags})); @@ -254,7 +291,7 @@ if (@merged) { my $descmerged = 'Merged with '; my $mseparator = ''; for my $m (@merged) { - $descmerged .= $mseparator."#$m"; + $descmerged .= $mseparator."#$m"; $mseparator= ",\n"; } push @descstates, $descmerged; @@ -263,40 +300,53 @@ if (@merged) { if (@{$status{found_versions}}) { my $foundtext = 'Found in '; $foundtext .= (@{$status{found_versions}} == 1) ? 'version ' : 'versions '; - $foundtext .= join ', ', map htmlsanit($_), @{$status{found_versions}}; + $foundtext .= join ', ', map html_escape($_), @{$status{found_versions}}; push @descstates, $foundtext; } - if (@{$status{fixed_versions}}) { my $fixedtext = 'Fixed in '; $fixedtext .= (@{$status{fixed_versions}} == 1) ? 'version ' : 'versions '; - $fixedtext .= join ', ', map htmlsanit($_), @{$status{fixed_versions}}; + $fixedtext .= join ', ', map html_escape($_), @{$status{fixed_versions}}; if (length($status{done})) { - $fixedtext .= ' by ' . htmlsanit(decode_rfc1522($status{done})); + $fixedtext .= ' by ' . html_escape(decode_rfc1522($status{done})); } push @descstates, $fixedtext; -} elsif (length($status{done})) { - push @descstates, "Done: ".htmlsanit(decode_rfc1522($status{done})); -} elsif (length($status{forwarded})) { - push @descstates, "Forwarded to ".maybelink($status{forwarded}); +} + +if (@{$status{found_versions}} or @{$status{fixed_versions}}) { + push @descstates, 'Version Graph}; +} + +if (length($status{done})) { + push @descstates, "Done: ".html_escape(decode_rfc1522($status{done})); +} + +if (length($status{forwarded})) { + my $forward_link = $status{forwarded}; + $forward_link =~ s,((ftp|http|https)://[\S~-]+?/?)((\>\;)?[)]?[']?[:.\,]?(\s|$)),$1$3,go; + push @descstates, "Forwarded to $forward_link"; } my @blockedby= split(/ /, $status{blockedby}); if (@blockedby && $status{"pending"} ne 'fixed' && ! length($status{done})) { for my $b (@blockedby) { - my %s = %{getbugstatus($b)}; + my %s = %{get_bug_status($b)}; next if $s{"pending"} eq 'fixed' || length $s{done}; - push @descstates, "Fix blocked by #$b: ".htmlsanit($s{subject}); + push @descstates, "Fix blocked by #$b: ".html_escape($s{subject}); } } my @blocks= split(/ /, $status{blocks}); if (@blocks && $status{"pending"} ne 'fixed' && ! length($status{done})) { for my $b (@blocks) { - my %s = %{getbugstatus($b)}; + my %s = %{get_bug_status($b)}; next if $s{"pending"} eq 'fixed' || length $s{done}; - push @descstates, "Blocking fix for #$b: ".htmlsanit($s{subject}); + push @descstates, "Blocking fix for #$b: ".html_escape($s{subject}); } } @@ -325,7 +375,7 @@ eval{ @records = read_log_records($buglogfh); }; if ($@) { - quitcgi("Bad bug log for $debbugs::gBug $ref. Unable to read records: $@"); + quitcgi("Bad bug log for $gBug $ref. Unable to read records: $@"); } undef $buglogfh; @@ -374,6 +424,8 @@ sub handle_record{ my $output = ''; local $_ = $record->{type}; if (/html/) { + my ($time) = $record->{text} =~ //; + my $class = $record->{text} =~ /^(?:Acknowledgement|Reply|Information|Report|Notification)/ ? 'infmessage':'msgreceived'; $output .= decode_rfc1522($record->{text}); # Link to forwarded http:// urls in the midst of the report # (even though these links already exist at the top) @@ -383,16 +435,19 @@ sub handle_record{ # Add links to merged bugs $output =~ s{(?<=Merged )([\d\s]+)(?=\.)}{join(' ',map {bug_links($_)} (split /\s+/, $1))}eo; # Add links to blocked bugs - $output =~ s{(?<=Blocking bugs)(?:(of )(\d+))?( (?:added|set to|removed):\s+)([\d\s]+)} + $output =~ s{(?<=Blocking bugs)(?:( of )(\d+))?( (?:added|set to|removed):\s+)([\d\s\,]+)} {(defined $2?$1.bug_links($2):'').$3. - join(' ',map {bug_links($_)} (split /\s+/, $4))}eo; + join(' ',map {bug_links($_)} (split /\,?\s+/, $4))}eo; # Add links to reassigned packages - $output =~ s{(Bug reassigned from package \`)([^\']+)(' to \`)([^\']+)(')} - {$1.q($2).$3.q($4).$5}eo; - $output .= 'Full text and rfc822 format available.'; + $output =~ s{(Bug reassigned from package \`)([^']+)((?:'|\&\#39;) to \`)([^']+)((?:'|\&\#39;))} + {$1.q($2).$3.q($4).$5}eo; + if (defined $time) { + $output .= ' ('.strftime('%a, %d %b %Y %T GMT',gmtime($time)).') '; + } + $output .= 'Full text and rfc822 format available.'; - $output = qq(\n"; + $output = qq(

\n
\n) . $output . "
\n"; } elsif (/recips/) { my ($msg_id) = $record->{text} =~ /^Message-Id:\s+<(.+)>/im; @@ -402,8 +457,8 @@ sub handle_record{ elsif (defined $msg_id) { $$seen_msg_ids{$msg_id} = 1; } - $output .= qq(\n); - $output .= 'View this message in rfc822 format'; + $output .= qq(

\n); + $output .= 'View this message in rfc822 format

'; $output .= handle_email_message($record->{text}, ref => $bug_number, msg_number => $msg_number, @@ -422,8 +477,10 @@ sub handle_record{ } # Incomming Mail Message my ($received,$hostname) = $record->{text} =~ m/Received: \(at (\S+)\) by (\S+)\;/; - $output .= qq|

Message received at |. - htmlsanit("$received\@$hostname") . q| (full text'.q|, mbox)'.":

\n"; + $output .= qq|

Message received at |. + html_escape("$received\@$hostname") . + q| (full text'. + q|, mbox)'.":

\n"; $output .= handle_email_message($record->{text}, ref => $bug_number, msg_number => $msg_number, @@ -472,10 +529,10 @@ if ( $mbox ) { } } print STDOUT qq(From unknown $date\n), - create_mime_message([From => "$debbugs::gBug#$ref <$ref\@$debbugs::gEmailDomain>", - To => "$debbugs::gBug#$ref <$ref\@$debbugs::gEmailDomain>", + create_mime_message([From => "$gBug#$ref <$ref\@$gEmailDomain>", + To => "$gBug#$ref <$ref\@$gEmailDomain>", Subject => "Status: $status{subject}", - "Reply-To" => "$debbugs::gBug#$ref <$ref\@$debbugs::gEmailDomain>", + "Reply-To" => "$gBug#$ref <$ref\@$gEmailDomain>", ], <{text} =~ /^Message-Id:\s+<(.+)>/im; next if exists $seen_message_ids{$msg_id}; - $seen_message_ids{$msg_id} = 1; - next if $msg_id =~/handler\..+\.ack(?:info)?\@/; + next if $msg_id =~/handler\..+\.ack(?:info|done)?\@/; $record_wanted_anyway = 1 if $record->{text} =~ /^Received: \(at control\)/; - next if not $boring and $record->{type} ne $wanted_type and not $record_wanted_anyway and @records > 1; + next if not $boring and not $record->{type} eq $wanted_type and not $record_wanted_anyway and @records > 1; + $seen_message_ids{$msg_id} = 1; my @lines = split( "\n", $record->{text}, -1 ); if ( $lines[ 1 ] =~ m/^From / ) { my $tmp = $lines[ 0 ]; @@ -526,33 +583,58 @@ else { } @log = reverse @log if $reverse; -$log = join('
',@log); +$log = join("\n",@log); print "Content-Type: text/html; charset=utf-8\n\n"; -my $title = htmlsanit($status{subject}); +my $title = html_escape($status{subject}); -my $dummy2 = $debbugs::gWebHostBugDir; +my $dummy2 = $gWebHostBugDir; print "\n"; -print "\n" . - "$short - $title - $debbugs::gProject $debbugs::gBug report logs\n" . - ''. - "" . - "\n" . - '' . - "\n"; -print "

" . "$debbugs::gProject $debbugs::gBug report logs - $short" . +print < +$short - $title - $gProject $gBug report logs + + + + + +END +print "

" . "$gProject $gBug report logs - $short" . "
" . $title . "

\n"; - print "$descriptivehead\n"; -printf qq(

View this report as an mbox folder, ). - qq(status mbox, maintainer mbox

\n), - html_escape(bug_url($ref, mbox=>'yes')), - html_escape(bug_url($ref, mbox=>'yes',mboxstatus=>'yes')), - html_escape(bug_url($ref, mbox=>'yes',mboxmaint=>'yes')); -print "
"; + +if (looks_like_number($msg)) { + printf qq(

Full log

),html_escape(bug_url($ref)); +} +else { + print qq(

Reply ), + qq(or subscribe ), + qq(to this bug.

\n); + print qq(

Toggle useless messages

); + printf qq(

View this report as an mbox folder, ). + qq(status mbox, maintainer mbox

\n), + html_escape(bug_url($ref, mbox=>'yes')), + html_escape(bug_url($ref, mbox=>'yes',mboxstatus=>'yes')), + html_escape(bug_url($ref, mbox=>'yes',mboxmaint=>'yes')); +} print "$log"; print "
"; print "

Send a report that this bug log contains spam.

\n
\n";