X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=bin%2Fwanna-build;h=313bc0b7d490a773bfc657fdad4eea3e0d7e9cfe;hb=166ff5a00320bdce3b06dd34a5dfcd9e567568bd;hp=8401dff42a9b8d93bd25682eb1c20cb53c4b9424;hpb=01e44aadfe82d4150966442c74c75aeb03d5f6cc;p=wannabuild.git

diff --git a/bin/wanna-build b/bin/wanna-build
index 8401dff..313bc0b 100755
--- a/bin/wanna-build
+++ b/bin/wanna-build
@@ -25,7 +25,7 @@ $basedir ||= "/var/lib/debbuild";
 $dbbase ||= "build-db";
 $transactlog ||= "transactions.log";
 $mailprog ||= "/usr/sbin/sendmail";
-require "/etc/wanna-build.conf";
+require "/org/wanna-build/etc/wanna-build.conf";
 die "$conf::basedir is not a directory\n" if ! -d $conf::basedir;
 die "dbbase is empty\n" if ! $dbbase;
 die "transactlog is empty\n" if ! $transactlog;
@@ -39,6 +39,7 @@ use POSIX;
 use FileHandle;
 use File::Copy;
 use DBI;
+use lib '/org/wanna-build/bin';
 use WannaBuild;
 
 our ($verbose, $mail_logs, $list_order, $list_state,
@@ -172,13 +173,12 @@ my %options =
 						 code => sub {
 							 die "Argument of --min-age must be a non-zero number\n"
 								 if $list_min_age == 0;
-							 $list_min_age *= 24*60*60;
 						 } },
 	 "max-age"      => { arg => \$list_min_age,
 						 code => sub {
 							 die "Argument of --max-age must be a non-zero number\n"
 								 if $list_min_age == 0;
-							 $list_min_age *= -24*60*60;
+							 $list_min_age *= -1;
 						 } },
 	 # special actions
 	 import         => { arg => \$import_from, mode => "import" },
@@ -301,8 +301,17 @@ END {
 	}
 }
 
-$dbh = DBI->connect("DBI:Pg:database=wanna-build") || 
-	die "FATAL: Cannot open database: $DBI::errstr\n";
+my $schema_suffix = '';
+if (isin( $op_mode, qw(list info)) && $distribution !~ /security/ && !(not -t and $user =~ /-/)) {
+	$dbh = DBI->connect("DBI:Pg:service=wanna-build") || 
+		die "FATAL: Cannot open database: $DBI::errstr\n";
+	$schema_suffix = '_public';
+}
+else
+{
+	$dbh = DBI->connect("DBI:Pg:service=wanna-build-privileged") || 
+		die "FATAL: Cannot open database: $DBI::errstr\n";
+}
 
 # TODO: This shouldn't be needed, file a bug.
 $dbh->{pg_server_prepare} = 0;
@@ -927,7 +936,8 @@ sub add_one_needsbuild {
 		}
 	}
 	if (defined ($pkg->{'builder'}) && $user ne $pkg->{'builder'} &&
-		    !($pkg->{'builder'} =~ /^(\w+)-\w+/ && $1 eq $user)) {
+		!($pkg->{'builder'} =~ /^(\w+)-\w+/ && $1 eq $user) &&
+		!$opt_override) {
 		print "$name: not taken by you, but by ".
 			  "$pkg->{'builder'}. Skipping.\n";
 		return;
@@ -1749,19 +1759,10 @@ sub list_packages {
 	my %scnt;
 	my $ctime = time;
 
-	my $db = get_all_source_info();
+ 	my $db = get_all_source_info(state => $state, user => $user, category => $category, list_min_age => $list_min_age);
 	foreach $name (keys %$db) {
 		next if $name =~ /^_/;
-		$pkg = $db->{$name};
-		next if $state ne "all" && $pkg->{'state'} !~ /^\Q$state\E$/i;
-		next if $user && (lc($state) ne 'needs-build' and $pkg->{'builder'} ne $user);
-		next if $category && $pkg->{'state'} eq "Failed" &&
-				$pkg->{'failed_category'} ne $category;
-		next if ($list_min_age > 0 &&
-				 ($ctime-parse_date($pkg->{'State-Change'})) < $list_min_age)||
-				($list_min_age < 0 &&
-				 ($ctime-parse_date($pkg->{'State-Change'})) > -$list_min_age);
-		push( @list, $pkg );
+		push @list, $db->{$name};
 	}
 
 	foreach $pkg (sort sort_list_func @list) {
@@ -1790,7 +1791,7 @@ sub list_packages {
 		          join("\n    ",split("\n",$pkg->{'bd_problem'})), "\n"
 			if $pkg->{'state'} eq "BD-Uninstallable";
 		print "  Previous state was $pkg->{'previous_state'} until ",
-			  "$pkg->{'State-Change'}\n"
+			  "$pkg->{'state_change'}\n"
 			if $verbose && $pkg->{'previous_state'};
 		print "  No previous state recorded\n"
 			if $verbose && !$pkg->{'previous_state'};
@@ -1820,7 +1821,7 @@ sub info_packages {
 		foreach $dist (@dists) {
 			my $pname = "$name" . ($info_all_dists ? "($dist)" : "");
 			
-			$pkg = get_source_info($name);
+			$pkg = get_readonly_source_info($name);
 			if (!defined( $pkg )) {
 				print "$pname: not registered\n";
 				next;
@@ -1833,15 +1834,39 @@ sub info_packages {
 				chomp( $val );
 				$val = "\n$val" if isin( $key, qw(Failed Old-Failed));
 				$val =~ s/\n/\n    /g;
-				printf "  %-20s: %s\n", $key, $val;
+				my $print_key = $key;
+				$print_key = 'Package' if ($key eq 'package');
+				$print_key = 'Version' if ($key eq 'version');
+				$print_key = 'Builder' if ($key eq 'builder');
+				$print_key = 'State' if ($key eq 'state');
+				$print_key = 'Section' if ($key eq 'section');
+				$print_key = 'Priority' if ($key eq 'priority');
+				$print_key = 'Installed-Version' if ($key eq 'installed_version');
+				$print_key = 'Previous-State' if ($key eq 'previous_state');
+				$print_key = 'State-Change' if ($key eq 'state_change');
+				printf "  %-20s: %s\n", $print_key, $val;
 			}
 			foreach $key (sort keys %$pkg) {
 				next if isin( $key, @firstkeys );
 				my $val = $pkg->{$key};
+				next if !defined($val);
 				chomp( $val );
 				$val = "\n$val" if isin( $key, qw(Failed Old-Failed));
 				$val =~ s/\n/\n    /g;
-				printf "  %-20s: %s\n", $key, $val;
+				my $print_key = $key;
+				$print_key = 'BD-Problem' if ($key eq 'bd_problem');
+				$print_key = 'Binary-NMU-Changelog' if ($key eq 'binary_nmu_changelog');
+				$print_key = 'Binary-NMU-Version' if ($key eq 'binary_nmu_version');
+				$print_key = 'BuildPri' if ($key eq 'buildpri');
+				$print_key = 'Depends' if ($key eq 'depends');
+				$print_key = 'Failed' if ($key eq 'failed');
+				$print_key = 'Failed-Category' if ($key eq 'failed_category');
+				$print_key = 'Notes' if ($key eq 'notes');
+				$print_key = 'Distribution' if ($key eq 'distribution');
+				$print_key = 'Old-Failed' if ($key eq 'old_failed');
+				$print_key = 'PermBuildPri' if ($key eq 'permbuildpri');
+				$print_key = 'Rel' if ($key eq 'rel');
+				printf "  %-20s: %s\n", $print_key, $val;
 			}
 		}
 	}
@@ -1938,14 +1963,14 @@ sub check_entry {
 			  join( "\n", map { "$_: $pkg->{$_}" } keys %$pkg ), "\n";
 		die "Database entry lacks package or username field\n";
 	}
-	if (!exists $pkg->{'version'}) {
-		die "Database entry for $pkg->{'package'} lacks Version: field\n";
-	}
 	# if no State: field, generate one (for old db compat)
 	if (!exists($pkg->{'state'})) {
 		$pkg->{'state'} =
 			exists $pkg->{'failed'} ? 'Failed' : 'Building';
 	}
+	if (!exists $pkg->{'version'} and $pkg->{'state'} ne 'Not-For-Us') {
+		die "Database entry for $pkg->{'package'} lacks Version: field\n";
+	}
 	# check state field
 	die "Bad state $pkg->{'state'} of package $pkg->{Package}\n"
 		if !isin( $pkg->{'state'},
@@ -1962,7 +1987,7 @@ sub change_state {
 	
 	return if defined($$state) and $$state eq $newstate;
         $pkg->{'previous_state'} = $$state if defined($$state);
-	$pkg->{'State-Change'} = $curr_date;
+	$pkg->{'state_change'} = $curr_date;
 
 	if (defined($$state) and $$state eq 'Failed') {
 		$pkg->{'old_failed'} =
@@ -2314,6 +2339,7 @@ sub usage {
 Usage: $prgname <options...> <package_version...>
 Options:
     -v, --verbose: Verbose execution.
+    -A arch: Architecture this operation is for.
     --take: Take package for building [default operation]
     -f, --failed: Record in database that a build failed due to
         deficiencies in the package (that aren't fixable without a new
@@ -2374,14 +2400,14 @@ sub pkg_version_eq {
 }
 
 sub table_name {
-	return '"' . $arch . '".packages';
+	return '"' . $arch . $schema_suffix . '".packages';
 }
 
 sub user_table_name {
-	return '"' . $arch . '".users';
+	return '"' . $arch . $schema_suffix . '".users';
 }
 
-sub get_source_info {
+sub get_readonly_source_info {
 	my $name = shift;
 	my $pkg = $dbh->selectrow_hashref('SELECT * FROM ' . 
 		table_name() . ' WHERE package = ? AND distribution = ?',
@@ -2389,10 +2415,50 @@ sub get_source_info {
 	return $pkg;
 }
 
+sub get_source_info {
+	my $name = shift;
+	my $pkg = $dbh->selectrow_hashref('SELECT * FROM ' . 
+		table_name() . ' WHERE package = ? AND distribution = ?' .
+		'FOR UPDATE',
+		undef, $name, $distribution);
+	return $pkg;
+}
+
 sub get_all_source_info {
-	my $db = $dbh->selectall_hashref('SELECT * FROM ' . table_name() .
-		' WHERE distribution = ?',
-		'package', undef, $distribution);
+	my %options = @_;
+
+	my $q = 'SELECT * FROM ' . table_name()
+		. ' WHERE distribution = ? ';
+	my @args = ($distribution);
+	if (uc($options{state}) ne "ALL") {
+		$q .= ' AND upper(state) = ? ';
+		push @args, uc($options{state});
+	}
+
+	if ($options{user}) {
+		#this basically means "this user, or no user at all":
+		$q .= ' AND (builder = ? OR upper(state) = ?)';
+		push @args, $options{user};
+		push @args, "NEEDS-BUILD";
+	}
+
+	if ($options{category}) {
+		$q .= ' AND failed_category <> ? AND upper(state) = ? ';
+		push @args, $options{category};
+		push @args, "FAILED";
+	}
+
+	if ($options{list_min_age} > 0) {
+		$q .= ' AND age(state_change::timestamp) > ? ';
+		push @args, $options{list_min_age} . " days";
+	}
+
+	if ($options{list_min_age} < 0) {
+		$q .= ' AND age(state_change::timestamp) < ? days ';
+		push @args, -$options{list_min_age} . " days";
+	}
+
+	my $db = $dbh->selectall_hashref($q, 'package', undef, @args);
 	return $db;
 }