X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=autorandr.py;h=e9bf2086f7fbc7324938f112046ff5ebb941bb0c;hb=c40615f054fb85ef2702113f2735831f3fa42a0d;hp=4187932632c1bb008c3d88cad62a31f1f1912611;hpb=3a1b5c484ea8a184a0ce6cdd61808d655e002746;p=deb_pkgs%2Fautorandr.git diff --git a/autorandr.py b/autorandr.py index 4187932..e9bf208 100755 --- a/autorandr.py +++ b/autorandr.py @@ -48,7 +48,7 @@ if sys.version_info.major == 2: else: import configparser -__version__ = "1.6" +__version__ = "1.8.1" try: input = raw_input @@ -140,7 +140,7 @@ class XrandrOutput(object): # This regular expression is used to parse an output in `xrandr --verbose' XRANDR_OUTPUT_REGEXP = """(?x) - ^(?P[^ ]+)\s+ # Line starts with output name + ^\s*(?P\S[^ ]*)\s+ # Line starts with output name (?: # Differentiate disconnected and connected disconnected | # in first line unknown\ connection | @@ -317,6 +317,12 @@ class XrandrOutput(object): else: edid = "%s-%s" % (XrandrOutput.EDID_UNAVAILABLE, match["output"]) + # An output can be disconnected but still have a mode configured. This can only happen + # as a residual situation after a disconnect, you cannot associate a mode with an disconnected + # output. + # + # This code needs to be careful not to mix the two. An output should only be configured to + # "off" if it doesn't have a mode associated with it, which is modelled as "not a width" here. if not match["width"]: options["off"] = None else: @@ -326,10 +332,11 @@ class XrandrOutput(object): options["mode"] = "%sx%s" % (match["mode_width"], match["mode_height"]) else: if match["rotate"] not in ("left", "right"): - options["mode"] = "%sx%s" % (match["width"], match["height"]) + options["mode"] = "%sx%s" % (match["width"] or 0, match["height"] or 0) else: - options["mode"] = "%sx%s" % (match["height"], match["width"]) - options["rotate"] = match["rotate"] + options["mode"] = "%sx%s" % (match["height"] or 0, match["width"] or 0) + if match["rotate"]: + options["rotate"] = match["rotate"] if match["primary"]: options["primary"] = None if match["reflect"] == "X": @@ -338,7 +345,8 @@ class XrandrOutput(object): options["reflect"] = "y" elif match["reflect"] == "X and Y": options["reflect"] = "xy" - options["pos"] = "%sx%s" % (match["x"], match["y"]) + if match["x"] or match["y"]: + options["pos"] = "%sx%s" % (match["x"] or "0", match["y"] or "0") if match["panning"]: panning = [match["panning"]] if match["tracking"]: @@ -571,6 +579,17 @@ def profile_blocked(profile_path, meta_information=None): return not exec_scripts(profile_path, "block", meta_information) +def check_configuration_pre_save(configuration): + "Check that a configuration is safe for saving." + outputs = sorted(configuration.keys(), key=lambda x: configuration[x].sort_key) + for output in outputs: + if "off" not in configuration[output].options and not configuration[output].edid: + return ("`%(o)s' is not off (has a mode configured) but is disconnected (does not have an EDID).\n" + "This typically means that it has been recently unplugged and then not properly disabled\n" + "by the user. Please disable it (e.g. using `xrandr --output %(o)s --off`) and then rerun\n" + "this command.") % {"o": output} + + def output_configuration(configuration, config): "Write a configuration file" outputs = sorted(configuration.keys(), key=lambda x: configuration[x].sort_key) @@ -638,13 +657,17 @@ def get_fb_dimensions(configuration): if "off" in output.options or not output.edid: continue # This won't work with all modes -- but it's a best effort. - o_width, o_height = map(int, output.options["mode"].split("x")) + o_mode = re.search("[0-9]{3,}x[0-9]{3,}", output.options["mode"]).group(0) + o_width, o_height = map(int, o_mode.split("x")) if "transform" in output.options: a, b, c, d, e, f, g, h, i = map(float, output.options["transform"].split(",")) w = (g * o_width + h * o_height + i) x = (a * o_width + b * o_height + c) / w y = (d * o_width + e * o_height + f) / w o_width, o_height = x, y + if "rotate" in output.options: + if output.options["rotate"] in ("left", "right"): + o_width, o_height = o_height, o_width if "pos" in output.options: o_left, o_top = map(int, output.options["pos"].split("x")) o_width += o_left @@ -652,9 +675,9 @@ def get_fb_dimensions(configuration): if "panning" in output.options: match = re.match("(?P[0-9]+)x(?P[0-9]+)(?:\+(?P[0-9]+))?(?:\+(?P[0-9]+))?.*", output.options["panning"]) if match: - detail = match.groupdict() - o_width = int(detail.get("w")) + int(detail.get("x", "0")) - o_height = int(detail.get("h")) + int(detail.get("y", "0")) + detail = match.groupdict(default="0") + o_width = int(detail.get("w")) + int(detail.get("x")) + o_height = int(detail.get("h")) + int(detail.get("y")) width = max(width, o_width) height = max(height, o_height) return int(width), int(height) @@ -703,6 +726,9 @@ def apply_configuration(new_configuration, current_configuration, dry_run=False) if not new_configuration[output].edid or "off" in new_configuration[output].options: disable_outputs.append(new_configuration[output].option_vector) else: + if output not in current_configuration: + raise AutorandrException("New profile configures output %s which does not exist in current xrandr --verbose output. " + "Don't know how to proceed." % output) if "off" not in current_configuration[output].options: remain_active_count += 1 @@ -1181,6 +1207,11 @@ def main(argv): if options["--save"] in (x[0] for x in virtual_profiles): raise AutorandrException("Cannot save current configuration as profile '%s':\n" "This configuration name is a reserved virtual configuration." % options["--save"]) + error = check_configuration_pre_save(config) + if error: + print("Cannot save current configuration as profile '%s':" % options["--save"]) + print(error) + sys.exit(1) try: profile_folder = os.path.join(profile_path, options["--save"]) save_configuration(profile_folder, config)