X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=Debbugs%2FLog.pm;h=2ae7af7b919705b1e859f55cfc686a0741ab980c;hb=cc7a9cb5803ed32b8f76921c97cae873f851ab50;hp=af80f7ab5e6f5d86b734bb27a6612f71e738ebf4;hpb=6edbdb47edfa0db4c2cd290a7f6cf8b2c9b2b121;p=debbugs.git

diff --git a/Debbugs/Log.pm b/Debbugs/Log.pm
index af80f7a..2ae7af7 100644
--- a/Debbugs/Log.pm
+++ b/Debbugs/Log.pm
@@ -39,6 +39,7 @@ use Carp;
 
 use Debbugs::Common qw(getbuglocation getbugcomponent make_list);
 use Params::Validate qw(:types validate_with);
+use Encode qw(encode is_utf8);
 
 =head1 NAME
 
@@ -50,6 +51,11 @@ The Debbugs::Log module provides a convenient way for scripts to read and
 write the .log files used by debbugs to store the complete textual records
 of all bug transactions.
 
+Debbugs::Log does not decode utf8 into perl's internal encoding or
+encode into utf8 from perl's internal encoding. For html records and
+all recips, this should probably be done. For other records, this should
+not be needed.
+
 =head2 The .log File Format
 
 .log files consist of a sequence of records, of one of the following four
@@ -382,6 +388,9 @@ sub write_log_records
     for my $record (@records) {
 	my $type = $record->{type};
 	croak "record type '$type' with no text field" unless defined $record->{text};
+	# I am not sure if we really want to croak here; but this is
+	# almost certainly a bug if is_utf8 is on.
+	# croak "probably wrong encoding" if is_utf8($record->{text});
 	my ($text) = escape_log($record->{text});
 	if ($type eq 'autocheck') {
 	    print {$logfh} "\01\n$text\03\n" or
@@ -426,7 +435,7 @@ Applies the log escape regex to the passed logfile.
 
 sub escape_log {
 	my @log = @_;
-	return map { s/^([\01-\07\030])/\030$1/gm; $_ } @log;
+	return map {s/^([\01-\07\030])/\030$1/gm; $_ } @log;
 }