X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=Debbugs%2FCGI.pm;h=c70f6829483e0a020b1f042c740384f2ddbd4c04;hb=1c4ce01f78b112c2247a08f1a0dc9efb5ab3adca;hp=cd5f6e3f40f4ee5171443e3b803d398d2a331423;hpb=b891e91a269d4fdf0655dc33ed9a5acd5ba90612;p=debbugs.git

diff --git a/Debbugs/CGI.pm b/Debbugs/CGI.pm
index cd5f6e3..c70f682 100644
--- a/Debbugs/CGI.pm
+++ b/Debbugs/CGI.pm
@@ -49,7 +49,7 @@ use Mail::Address;
 use POSIX qw(ceil);
 use Storable qw(dclone);
 
-use List::Util qw(max);
+use List::AllUtils qw(max);
 use File::stat;
 use Digest::MD5 qw(md5_hex);
 use Carp;
@@ -292,7 +292,9 @@ sub cgi_parameters {
 
 
 sub quitcgi {
-    my $msg = shift;
+    my ($msg, $status) = @_;
+    $status //= '500 Internal Server Error';
+    print "Status: $status\n";
     print "Content-Type: text/html\n\n";
     print fill_in_template(template=>'cgi/quit',
 			   variables => {msg => $msg}
@@ -622,10 +624,6 @@ sub htmlize_maintlinks {
     return htmlize_addresslinks($prefixfunc, \&mainturl, $maints);
 }
 
-
-our $_maintainer;
-our $_maintainer_rev;
-
 =head2 bug_linklist
 
      bug_linklist($separator,$class,@bugs)
@@ -841,7 +839,6 @@ sub option_form{
      for my $key (keys %{$param{form_option}}) {
 	  # strip out leader; shouldn't be anything here without one,
 	  # but skip stupid things anyway
-	  my $o_key = $key;
 	  next unless $key =~ s/^\Q$form_option_leader\E//;
 	  if ($key =~ /^add_(.+)$/) {
 	       # this causes a specific parameter to be added