X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=3rdparty%2Fmodules%2Fkeystone%2Fspec%2Funit%2Fprovider%2Fkeystone_role%2Fopenstack_spec.rb;h=09e229b82fc1ada90e13ec2f0b41c8425d8dfc27;hb=71a236efd9f45828d875a0a5fd025108bb1dcada;hp=179574fea3b4b9c98635b131721b8ade8287ef58;hpb=b8fa2c1a5ec9dbcd1d2f9e9b41afdde4c603aa35;p=dsa-puppet.git

diff --git a/3rdparty/modules/keystone/spec/unit/provider/keystone_role/openstack_spec.rb b/3rdparty/modules/keystone/spec/unit/provider/keystone_role/openstack_spec.rb
index 179574fe..09e229b8 100644
--- a/3rdparty/modules/keystone/spec/unit/provider/keystone_role/openstack_spec.rb
+++ b/3rdparty/modules/keystone/spec/unit/provider/keystone_role/openstack_spec.rb
@@ -6,96 +6,81 @@ provider_class = Puppet::Type.type(:keystone_role).provider(:openstack)
 
 describe provider_class do
 
-  describe 'when creating a role' do
+  shared_examples 'authenticated with environment variables' do
+    ENV['OS_USERNAME']     = 'test'
+    ENV['OS_PASSWORD']     = 'abc123'
+    ENV['OS_PROJECT_NAME'] = 'test'
+    ENV['OS_AUTH_URL']     = 'http://127.0.0.1:5000'
+  end
 
-    let(:role_attrs) do
-      {
-        :name         => 'foo',
-        :ensure       => 'present',
-        :auth         => {
-          'username'    => 'test',
-          'password'    => 'abc123',
-          'tenant_name' => 'foo',
-          'auth_url'    => 'http://127.0.0.1:5000/v2.0',
+  describe 'when creating a role' do
+    it_behaves_like 'authenticated with environment variables' do
+      let(:role_attrs) do
+        {
+          :name         => 'foo',
+          :ensure       => 'present',
         }
-      }
-    end
-
-    let(:resource) do
-      Puppet::Type::Keystone_role.new(role_attrs)
-    end
-
-    let(:provider) do
-      provider_class.new(resource)
-    end
-
-    describe '#create' do
-      it 'creates a role' do
-        provider.class.stubs(:openstack)
-                      .with('role', 'list', '--quiet', '--format', 'csv', [['--os-username', 'test', '--os-password', 'abc123', '--os-tenant-name', 'foo', '--os-auth-url', 'http://127.0.0.1:5000/v2.0']])
-                      .returns('"ID","Name"
-"1cb05cfed7c24279be884ba4f6520262","foo"
-')
-        provider.class.stubs(:openstack)
-                      .with('role', 'create', '--format', 'shell', [['foo', '--os-username', 'test', '--os-password', 'abc123', '--os-tenant-name', 'foo', '--os-auth-url', 'http://127.0.0.1:5000/v2.0']])
-                      .returns('name="foo"')
-        provider.create
-        expect(provider.exists?).to be_truthy
       end
-    end
 
-    describe '#destroy' do
-      it 'destroys a role' do
-        provider.class.stubs(:openstack)
-                      .with('role', 'list', '--quiet', '--format', 'csv', [['--os-username', 'test', '--os-password', 'abc123', '--os-tenant-name', 'foo', '--os-auth-url', 'http://127.0.0.1:5000/v2.0']])
-                      .returns('"ID","Name"')
-        provider.class.stubs(:openstack)
-                      .with('role', 'delete', [['foo', '--os-username', 'test', '--os-password', 'abc123', '--os-tenant-name', 'foo', '--os-auth-url', 'http://127.0.0.1:5000/v2.0']])
-        provider.destroy
-        expect(provider.exists?).to be_falsey
+      let(:resource) do
+        Puppet::Type::Keystone_role.new(role_attrs)
       end
 
-    end
-
-    describe '#exists' do
-      context 'when role exists' do
+      let(:provider) do
+        provider_class.new(resource)
+      end
 
-        subject(:response) do
+      describe '#create' do
+        it 'creates a role' do
           provider.class.stubs(:openstack)
-                        .with('role', 'list', '--quiet', '--format', 'csv', [['--os-username', 'test', '--os-password', 'abc123', '--os-tenant-name', 'foo', '--os-auth-url', 'http://127.0.0.1:5000/v2.0']])
+                        .with('role', 'list', '--quiet', '--format', 'csv', [])
                         .returns('"ID","Name"
 "1cb05cfed7c24279be884ba4f6520262","foo"
 ')
-          response = provider.exists?
+          provider.class.stubs(:openstack)
+                        .with('role', 'create', '--format', 'shell', 'foo')
+                        .returns('name="foo"')
+          provider.create
+          expect(provider.exists?).to be_truthy
         end
-
-        it { is_expected.to be_truthy }
       end
 
-      context 'when role does not exist' do
-
-        subject(:response) do
+      describe '#destroy' do
+        it 'destroys a role' do
           provider.class.stubs(:openstack)
-                        .with('role', 'list', '--quiet', '--format', 'csv', [['--os-username', 'test', '--os-password', 'abc123', '--os-tenant-name', 'foo', '--os-auth-url', 'http://127.0.0.1:5000/v2.0']])
-                      .returns('"ID","Name"')
-          response = provider.exists?
+                        .with('role', 'list', '--quiet', '--format', 'csv', [])
+                        .returns('"ID","Name"')
+          provider.class.stubs(:openstack)
+                        .with('role', 'delete', [])
+          provider.destroy
+          expect(provider.exists?).to be_falsey
         end
 
-        it { is_expected.to be_falsey }
       end
-    end
 
-    describe '#instances' do
-      it 'finds every role' do
-        provider.class.stubs(:openstack)
-                      .with('role', 'list', '--quiet', '--format', 'csv', [['--os-username', 'test', '--os-password', 'abc123', '--os-tenant-name', 'foo', '--os-auth-url', 'http://127.0.0.1:5000/v2.0']])
-                      .returns('"ID","Name"
+      describe '#exists' do
+        context 'when role does not exist' do
+          subject(:response) do
+            provider.class.stubs(:openstack)
+                          .with('role', 'list', '--quiet', '--format', 'csv', [])
+                        .returns('"ID","Name"')
+            response = provider.exists?
+          end
+          it { is_expected.to be_falsey }
+        end
+      end
+
+      describe '#instances' do
+        it 'finds every role' do
+          provider.class.stubs(:openstack)
+                        .with('role', 'list', '--quiet', '--format', 'csv', [])
+                        .returns('"ID","Name"
 "1cb05cfed7c24279be884ba4f6520262","foo"
 ')
-        instances = provider.instances
-        expect(instances.count).to eq(1)
+          instances = Puppet::Type::Keystone_role::ProviderOpenstack.instances
+          expect(instances.count).to eq(1)
+        end
       end
     end
-
   end
 end