X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;ds=sidebyside;f=lily%2Fpiano-pedal-engraver.cc;h=829b9c12bab698c03cfa9238d81e2f984e6ee35f;hb=c7be17948fb3aec4e57e21027a0eb98f05be43bb;hp=5204f51f68e4683468252beac344157907eb8726;hpb=f0da063c7a52889d36d0ee293b76c390096b0a1f;p=lilypond.git diff --git a/lily/piano-pedal-engraver.cc b/lily/piano-pedal-engraver.cc index 5204f51f68..829b9c12ba 100644 --- a/lily/piano-pedal-engraver.cc +++ b/lily/piano-pedal-engraver.cc @@ -1,28 +1,28 @@ /* - piano-pedal-engraver.cc -- implement Piano_pedal_engraver + piano-pedal-engraver.cc -- implement Piano_pedal_engraver - source file of the GNU LilyPond music typesetter + source file of the GNU LilyPond music typesetter - (c) 2000--2003 Jan Nieuwenhuizen + (c) 2000--2004 Jan Nieuwenhuizen - Chris Jackson - extended to support - bracketed pedals. + Chris Jackson - extended to support + bracketed pedals. */ #include "engraver.hh" -#include "event.hh" -#include "grob.hh" -#include "item.hh" #include "lily-guile.hh" #include "side-position-interface.hh" #include "staff-symbol-referencer.hh" -#include "item.hh" #include "axis-group-interface.hh" -#include "translator-group.hh" +#include "context.hh" #include "directional-element-interface.hh" #include "note-column.hh" #include "warn.hh" +/* + Urgh. This engraver is too complex. rewrite. --hwn +*/ + struct Pedal_info { char const * name_; @@ -31,19 +31,20 @@ struct Pedal_info Event for currently running pedal. */ Music* current_bracket_ev_; + /* Event for currently starting pedal, (necessary? distinct from current_bracket_ev_, since current_bracket_ev_ only necessary for brackets, not for text style. - */ + */ Music* start_ev_; /* Events that were found in this timestep. - */ + */ Drul_array event_drul_; Item* item_; Spanner* bracket_; // A single portion of a pedal bracket @@ -51,7 +52,7 @@ struct Pedal_info /* This grob contains all the pedals of the same type on the same staff - */ + */ Spanner* line_spanner_; Spanner* finished_line_spanner_; }; @@ -67,7 +68,6 @@ protected: virtual void finalize (); virtual bool try_music (Music*); virtual void stop_translation_timestep (); - virtual void start_translation_timestep (); virtual void acknowledge_grob (Grob_info); virtual void process_music (); @@ -81,12 +81,11 @@ private: */ Link_array previous_; - - + void del_linespanner (Spanner*); void create_text_grobs (Pedal_info *p, bool); void create_bracket_grobs (Pedal_info *p, bool); - void typeset_all (); + void typeset_all (Pedal_info*p); }; @@ -98,8 +97,6 @@ Piano_pedal_engraver::Piano_pedal_engraver () void Piano_pedal_engraver::initialize () { - previous_.clear (); - char * names [] = { "Sostenuto", "Sustain", "UnaCorda", 0 }; info_list_ = new Pedal_info[sizeof (names)/ sizeof (const char*)]; @@ -130,9 +127,9 @@ Piano_pedal_engraver::~Piano_pedal_engraver () } /* - Urg: Code dup - I'm a script - */ + Urg: Code dup + I'm a script +*/ void Piano_pedal_engraver::acknowledge_grob (Grob_info info) { @@ -146,8 +143,9 @@ Piano_pedal_engraver::acknowledge_grob (Grob_info info) add_bound_item (p->line_spanner_,info.grob_); } if (p->bracket_) - add_bound_item (p->bracket_,info.grob_); - + add_bound_item (p->bracket_,info.grob_); + if (p->finished_bracket_) + add_bound_item (p->finished_bracket_,info.grob_); } } } @@ -155,27 +153,15 @@ Piano_pedal_engraver::acknowledge_grob (Grob_info info) bool Piano_pedal_engraver::try_music (Music *m) { - if (m->is_mus_type ("abort-event")) - { - for (Pedal_info*p = info_list_; p->name_; p ++) - { - p->event_drul_[START] = 0; - p->event_drul_[STOP] = 0; - - if (p->bracket_) - p->bracket_->suicide (); - p->bracket_ = 0; - } - } - else if (m->is_mus_type ("pedal-event")) + if (m->is_mus_type ("pedal-event")) { for (Pedal_info*p = info_list_; p->name_; p ++) { String nm = p->name_ + String ("Event"); - if (gh_equal_p (m->get_mus_property ("name") , - gh_symbol2scm (nm.to_str0()))) + if (ly_c_equal_p (m->get_property ("name") , + scm_str2symbol(nm.to_str0()))) { - Direction d = to_dir (m->get_mus_property ("span-direction")); + Direction d = to_dir (m->get_property ("span-direction")); p->event_drul_[d] = m; return true; } @@ -194,41 +180,40 @@ Piano_pedal_engraver::process_music () if (!p->line_spanner_) { String name = String (p->name_) + "PedalLineSpanner"; - p->line_spanner_ = new Spanner (get_property (name.to_str0 ())); + Music * rq = (p->event_drul_[START] ? p->event_drul_[START] : p->event_drul_[STOP]); + p->line_spanner_ = make_spanner (name.to_str0 (), rq->self_scm ()); + - Music * rq = (p->event_drul_[START] ? p->event_drul_[START] : p->event_drul_[STOP]); - announce_grob (p->line_spanner_, rq->self_scm ()); } /* Choose the appropriate grobs to add to the line spanner - These can be text items or text-spanners + These can be text items or text-spanners */ /* ugh, code dup, should read grob to create from other property. - bracket: |_________/\____| - text: Ped. *Ped. * - mixed: Ped. _____/\____| - */ + bracket: |_________/\____| + text: Ped. *Ped. * + mixed: Ped. _____/\____| + */ String prop = String ("pedal") + p->name_ + "Style"; SCM style = get_property (prop.to_str0 ()); + bool mixed = style == ly_symbol2scm ("mixed"); - if (style == ly_symbol2scm ("text") || - mixed) - { - if (! p->item_) - create_text_grobs (p, mixed); - } - if (style == ly_symbol2scm ("bracket") || - mixed) - { - create_bracket_grobs (p, mixed); - } + bool bracket = (mixed + || style == ly_symbol2scm ("bracket")); + bool text = (style == ly_symbol2scm ("text") + || mixed); + + if (text && !p->item_) + create_text_grobs (p, mixed); + if (bracket) + create_bracket_grobs (p, mixed); } } } @@ -246,7 +231,7 @@ Piano_pedal_engraver::create_text_grobs (Pedal_info *p, bool mixed) String msg = _ ("Need 3 strings for piano pedals. No pedal made. "); if (m) - m->origin()->warning (msg); + m->origin ()->warning (msg); else warning (msg); @@ -263,7 +248,7 @@ Piano_pedal_engraver::create_text_grobs (Pedal_info *p, bool mixed) } else { - s = ly_cadr (strings); + s = scm_cadr (strings); } p->start_ev_ = p->event_drul_[START]; } @@ -278,9 +263,7 @@ Piano_pedal_engraver::create_text_grobs (Pedal_info *p, bool mixed) } else { - s = ly_caddr (strings); - if (previous_.size ()) - previous_.pop(); + s = scm_caddr (strings); } p->start_ev_ = 0; } @@ -288,7 +271,7 @@ Piano_pedal_engraver::create_text_grobs (Pedal_info *p, bool mixed) else if (p->event_drul_[START]) { p->start_ev_ = p->event_drul_[START]; - s = ly_car (strings); + s = scm_car (strings); if (!mixed) { /* @@ -298,25 +281,22 @@ Piano_pedal_engraver::create_text_grobs (Pedal_info *p, bool mixed) // add extra space below the previous already-occuring pedal Side_position_interface::add_support (p->line_spanner_, previous_.top ()); - previous_.push ( p->line_spanner_); + previous_.push (p->line_spanner_); } } - if (gh_string_p (s)) + if (scm_is_string (s)) { String propname = String (p->name_) + "Pedal"; - SCM b = get_property (propname.to_str0 ()); - p->item_ = new Item (b); - p->item_->set_grob_property ("text", s); + p->item_ = make_item (propname.to_str0 (), (p->event_drul_[START] + ? p->event_drul_[START] + : p->event_drul_[STOP])->self_scm ()); + + p->item_->set_property ("text", s); Axis_group_interface::add_element (p->line_spanner_, p->item_); - - announce_grob (p->item_, - (p->event_drul_[START] - ? p->event_drul_[START] - : p->event_drul_[STOP])->self_scm ()); } - + if (!mixed) { p->event_drul_[START] = 0; @@ -324,39 +304,36 @@ Piano_pedal_engraver::create_text_grobs (Pedal_info *p, bool mixed) } } + void Piano_pedal_engraver::create_bracket_grobs (Pedal_info *p, bool mixed) { if (!p->bracket_ && p->event_drul_[STOP]) { - String msg =_f ("can't find start of piano pedal bracket: `%s'", p->name_); + String msg = _f ("can't find start of piano pedal bracket: `%s'", p->name_); p->event_drul_[STOP]->origin ()->warning (msg); p->event_drul_[STOP] = 0; } if (p->event_drul_[STOP]) { - if (!p->event_drul_[START]) - { - if (previous_.size()) - previous_.pop(); - } - assert (!p->finished_bracket_); Grob *cmc = unsmob_grob (get_property ("currentMusicalColumn")); - p->bracket_->set_bound (RIGHT, cmc); + + if (!p->bracket_->get_bound (RIGHT)) + p->bracket_->set_bound (RIGHT, cmc); /* - Set properties so that the molecule-creating function will + Set properties so that the stencil-creating function will know whether the right edge should be flared ___/ - */ + */ if (!p->event_drul_[START]) { - SCM flare = p->bracket_->get_grob_property ("bracket-flare"); - p->bracket_->set_grob_property ("bracket-flare", scm_cons (gh_car (flare), - gh_double2scm (0))); + SCM flare = p->bracket_->get_property ("bracket-flare"); + p->bracket_->set_property ("bracket-flare", scm_cons (scm_car (flare), + scm_make_real (0))); } p->finished_bracket_ = p->bracket_; @@ -369,22 +346,22 @@ Piano_pedal_engraver::create_bracket_grobs (Pedal_info *p, bool mixed) p->start_ev_ = p->event_drul_[START]; p->current_bracket_ev_ = p->event_drul_[START]; - p->bracket_ = new Spanner (get_property ("PianoPedalBracket")); + p->bracket_ = make_spanner ("PianoPedalBracket", p->event_drul_[START]->self_scm ()); /* - Set properties so that the molecule-creating function will + Set properties so that the stencil-creating function will know whether the left edge should be flared \___ */ if (!p->finished_bracket_) { - SCM flare = p->bracket_->get_grob_property ("bracket-flare"); - p->bracket_->set_grob_property ("bracket-flare", scm_cons (gh_double2scm (0),gh_cdr (flare))); + SCM flare = p->bracket_->get_property ("bracket-flare"); + p->bracket_->set_property ("bracket-flare", scm_cons (scm_make_real (0),scm_cdr (flare))); } /* Set this property for 'mixed style' pedals, Ped._______/\ , - so the molecule function will shorten the ____ line by the length of the Ped. text. + so the stencil function will shorten the ____ line by the length of the Ped. text. */ if (mixed) @@ -399,7 +376,7 @@ Piano_pedal_engraver::create_bracket_grobs (Pedal_info *p, bool mixed) WTF is pedal-text not the bound of the object? --hwn */ if (p->item_) - p->bracket_->set_grob_property ("pedal-text", p->item_->self_scm ()); + p->bracket_->set_property ("pedal-text", p->item_->self_scm ()); } @@ -416,9 +393,8 @@ Piano_pedal_engraver::create_bracket_grobs (Pedal_info *p, bool mixed) what about the right span point? - */ + */ Axis_group_interface::add_element (p->line_spanner_, p->bracket_); - announce_grob (p->bracket_, p->event_drul_[START]->self_scm ()); if (!p->event_drul_[STOP]) { @@ -427,9 +403,9 @@ Piano_pedal_engraver::create_bracket_grobs (Pedal_info *p, bool mixed) code dup. --hwn. // position new pedal spanner below the current one - */ - if (previous_.size()) - Side_position_interface::add_support (p->line_spanner_, previous_.top()); + */ + if (previous_.size ()) + Side_position_interface::add_support (p->line_spanner_, previous_.top ()); previous_.push (p->line_spanner_); } @@ -446,30 +422,48 @@ Piano_pedal_engraver::finalize () { /* suicide? - */ + */ if (p->line_spanner_ - && !p->line_spanner_->live()) + && !p->line_spanner_->is_live ()) p->line_spanner_ = 0; - if (p->line_spanner_) - { - p->finished_line_spanner_ = p->line_spanner_; - typeset_all (); - } if (p->bracket_ - && !p->bracket_->live()) + && !p->bracket_->is_live ()) p->bracket_ = 0; if (p->bracket_) { - p->current_bracket_ev_->origin ()->warning (_ ("unterminated pedal bracket")); - p->bracket_->suicide (); + SCM cc = get_property ("currentCommandColumn"); + Item *c = unsmob_item (cc); + if (p->line_spanner_) + { + p->line_spanner_->set_bound (RIGHT, c); + } + p->bracket_ ->set_bound (RIGHT, c); + + p->finished_bracket_ = p->bracket_; p->bracket_ = 0; + p->finished_line_spanner_ = p->line_spanner_; + p->line_spanner_ = 0; + typeset_all (p); + } + + if (p->line_spanner_) + { + p->finished_line_spanner_ = p->line_spanner_; + typeset_all (p); } } } - +void +Piano_pedal_engraver::del_linespanner (Spanner *g) +{ + int idx = previous_.find_index (g); + if (idx >= 0) + previous_.del (idx); +} + void Piano_pedal_engraver::stop_translation_timestep () { @@ -479,97 +473,78 @@ Piano_pedal_engraver::stop_translation_timestep () { p->finished_line_spanner_ = p->line_spanner_; p->line_spanner_ = 0; + del_linespanner (p->finished_line_spanner_); } + + typeset_all (p); } - typeset_all (); + + for (Pedal_info*p = info_list_; p->name_; p ++) + { + p->event_drul_[STOP] = 0; + p->event_drul_[START] = 0; + } } void -Piano_pedal_engraver::typeset_all () +Piano_pedal_engraver::typeset_all (Pedal_info * p) { - Item * sustain = 0; - for (Pedal_info*p = info_list_; p->name_; p ++) - { - /* - Handle suicide. - */ - if (p->finished_line_spanner_ - && !p->finished_line_spanner_->live ()) - p->finished_line_spanner_ = 0; - if (p->finished_bracket_ - && !p->finished_bracket_->live()) - p->finished_bracket_ = 0; - + /* + Handle suicide. + */ + if (p->finished_line_spanner_ + && !p->finished_line_spanner_->is_live ()) + p->finished_line_spanner_ = 0; + if (p->finished_bracket_ + && !p->finished_bracket_->is_live ()) + p->finished_bracket_ = 0; - if (p->name_ == String ("Sustain")) - sustain = p->item_; - if (p->item_) - { - /* - Hmm. - */ - if (p->name_ != String ("Sustain")) - { - if (sustain) - { - Side_position_interface::add_support (p->item_,sustain); - } - } - typeset_grob (p->item_); - p->item_ = 0; - } + if (p->item_) + { + p->item_ = 0; + } - if (p->finished_bracket_) + if (p->finished_bracket_) + { + Grob * r = p->finished_bracket_->get_bound (RIGHT); + if (!r) { - Grob * r = p->finished_bracket_->get_bound (RIGHT); - if (!r) - { - p->finished_bracket_->set_bound (RIGHT, unsmob_grob (get_property ("currentMusicalColumn"))); - } - - typeset_grob (p->finished_bracket_); - p->finished_bracket_ =0; + p->finished_bracket_->set_bound (RIGHT, unsmob_grob (get_property ("currentMusicalColumn"))); } - if (p->finished_line_spanner_) - { - Side_position_interface::add_staff_support (p->finished_line_spanner_); - Grob * l = p->finished_line_spanner_->get_bound (LEFT); - Grob * r = p->finished_line_spanner_->get_bound (RIGHT); - if (!r && l) - p->finished_line_spanner_->set_bound (RIGHT, l); - else if (!l && r) - p->finished_line_spanner_->set_bound (LEFT, r); - else if (!r && !l) - { - Grob * cc = unsmob_grob (get_property ("currentMusicalColumn")); - Item * ci = dynamic_cast (cc); - p->finished_line_spanner_->set_bound (RIGHT, ci); - p->finished_line_spanner_->set_bound (LEFT, ci); - } - typeset_grob (p->finished_line_spanner_); - p->finished_line_spanner_ = 0; - } + p->finished_bracket_ = 0; } -} -void -Piano_pedal_engraver::start_translation_timestep () -{ - for (Pedal_info*p = info_list_; p->name_; p ++) + if (p->finished_line_spanner_) { - p->event_drul_[STOP] = 0; - p->event_drul_[START] = 0; + Grob * l = p->finished_line_spanner_->get_bound (LEFT); + Grob * r = p->finished_line_spanner_->get_bound (RIGHT); + if (!r && l) + p->finished_line_spanner_->set_bound (RIGHT, l); + else if (!l && r) + p->finished_line_spanner_->set_bound (LEFT, r); + else if (!r && !l) + { + Grob * cc = unsmob_grob (get_property ("currentMusicalColumn")); + Item * ci = dynamic_cast (cc); + p->finished_line_spanner_->set_bound (RIGHT, ci); + p->finished_line_spanner_->set_bound (LEFT, ci); + } + + p->finished_line_spanner_ = 0; } } -ENTER_DESCRIPTION (Piano_pedal_engraver, -/* descr */ "Engrave piano pedal symbols and brackets.", -/* creats*/ "SostenutoPedal SustainPedal UnaCordaPedal SostenutoPedalLineSpanner SustainPedalLineSpanner UnaCordaPedalLineSpanner", -/* accepts */ "pedal-event abort-event", -/* acks */ "note-column-interface", -/* reads */ "pedalSostenutoStrings pedalSustainStrings pedalUnaCordaStrings pedalSostenutoStyle pedalSustainStyle pedalUnaCordaStyle", -/* write */ ""); +ADD_TRANSLATOR (Piano_pedal_engraver, + /* descr */ "Engrave piano pedal symbols and brackets.", + /* creats*/ "SostenutoPedal SustainPedal UnaCordaPedal SostenutoPedalLineSpanner SustainPedalLineSpanner UnaCordaPedalLineSpanner", + /* accepts */ "pedal-event", + /* acks */ "note-column-interface", + /* reads */ "currentCommandColumn " + "pedalSostenutoStrings pedalSustainStrings " + "pedalUnaCordaStrings pedalSostenutoStyle " + "pedalSustainStyle pedalUnaCordaStyle", + /* write */ "");